| Message ID | 20230310144704.1542045-1-robh@kernel.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | firmware: Use of_property_present() for testing DT property presence | expand |
On Fri, Mar 10, 2023 at 08:47:04AM -0600, Rob Herring wrote: > It is preferred to use typed property access functions (i.e. > of_property_read_<type> functions) rather than low-level > of_get_property/of_find_property functions for reading properties. As > part of this, convert of_get_property/of_find_property calls to the > recently added of_property_present() helper when we just want to test > for presence of a property and nothing more. > > Signed-off-by: Rob Herring <robh@kernel.org> > --- > drivers/firmware/arm_scmi/optee.c | 2 +- Acked-by: Sudeep Holla <sudeep.holla@arm.com>(for the SCMI part) I am assuming you will route this as it has other changes as well in the patch.
On Thu, Mar 23, 2023 at 12:00:30PM +0000, Sudeep Holla wrote: > On Fri, Mar 10, 2023 at 08:47:04AM -0600, Rob Herring wrote: > > It is preferred to use typed property access functions (i.e. > > of_property_read_<type> functions) rather than low-level > > of_get_property/of_find_property functions for reading properties. As > > part of this, convert of_get_property/of_find_property calls to the > > recently added of_property_present() helper when we just want to test > > for presence of a property and nothing more. > > > > Signed-off-by: Rob Herring <robh@kernel.org> > > --- > > drivers/firmware/arm_scmi/optee.c | 2 +- > > Acked-by: Sudeep Holla <sudeep.holla@arm.com>(for the SCMI part) > > I am assuming you will route this as it has other changes as well in the > patch. I can also pick this up along with the Tegra changes if Rob doesn't want to take it. But also feel free to take this through whatever tree works best, for the Tegra parts: Acked-by: Thierry Reding <treding@nvidia.com>
On Tue, Apr 04, 2023 at 03:30:02PM +0200, Thierry Reding wrote: > On Thu, Mar 23, 2023 at 12:00:30PM +0000, Sudeep Holla wrote: > > On Fri, Mar 10, 2023 at 08:47:04AM -0600, Rob Herring wrote: > > > It is preferred to use typed property access functions (i.e. > > > of_property_read_<type> functions) rather than low-level > > > of_get_property/of_find_property functions for reading properties. As > > > part of this, convert of_get_property/of_find_property calls to the > > > recently added of_property_present() helper when we just want to test > > > for presence of a property and nothing more. > > > > > > Signed-off-by: Rob Herring <robh@kernel.org> > > > --- > > > drivers/firmware/arm_scmi/optee.c | 2 +- > > > > Acked-by: Sudeep Holla <sudeep.holla@arm.com>(for the SCMI part) > > > > I am assuming you will route this as it has other changes as well in the > > patch. > > I can also pick this up along with the Tegra changes if Rob doesn't > want to take it. But also feel free to take this through whatever tree > works best, for the Tegra parts: > > Acked-by: Thierry Reding <treding@nvidia.com> You can take it. Thanks. Rob
On Tue, Apr 04, 2023 at 11:58:46AM -0500, Rob Herring wrote: > On Tue, Apr 04, 2023 at 03:30:02PM +0200, Thierry Reding wrote: > > On Thu, Mar 23, 2023 at 12:00:30PM +0000, Sudeep Holla wrote: > > > On Fri, Mar 10, 2023 at 08:47:04AM -0600, Rob Herring wrote: > > > > It is preferred to use typed property access functions (i.e. > > > > of_property_read_<type> functions) rather than low-level > > > > of_get_property/of_find_property functions for reading properties. As > > > > part of this, convert of_get_property/of_find_property calls to the > > > > recently added of_property_present() helper when we just want to test > > > > for presence of a property and nothing more. > > > > > > > > Signed-off-by: Rob Herring <robh@kernel.org> > > > > --- > > > > drivers/firmware/arm_scmi/optee.c | 2 +- > > > > > > Acked-by: Sudeep Holla <sudeep.holla@arm.com>(for the SCMI part) > > > > > > I am assuming you will route this as it has other changes as well in the > > > patch. > > > > I can also pick this up along with the Tegra changes if Rob doesn't > > want to take it. But also feel free to take this through whatever tree > > works best, for the Tegra parts: > > > > Acked-by: Thierry Reding <treding@nvidia.com> > > You can take it. Thanks. Applied now, thanks. Thierry
From: Thierry Reding <treding@nvidia.com> On Fri, 10 Mar 2023 08:47:04 -0600, Rob Herring wrote: > It is preferred to use typed property access functions (i.e. > of_property_read_<type> functions) rather than low-level > of_get_property/of_find_property functions for reading properties. As > part of this, convert of_get_property/of_find_property calls to the > recently added of_property_present() helper when we just want to test > for presence of a property and nothing more. > > [...] Applied, thanks! [1/1] firmware: Use of_property_present() for testing DT property presence commit: 8c47b8253f4cfd8b4dbda8c9adc1d0b1d7f3009d Best regards,
diff --git a/drivers/firmware/arm_scmi/optee.c b/drivers/firmware/arm_scmi/optee.c index 929720387102..e123de6e8c67 100644 --- a/drivers/firmware/arm_scmi/optee.c +++ b/drivers/firmware/arm_scmi/optee.c @@ -403,7 +403,7 @@ static int setup_static_shmem(struct device *dev, struct scmi_chan_info *cinfo, static int setup_shmem(struct device *dev, struct scmi_chan_info *cinfo, struct scmi_optee_channel *channel) { - if (of_find_property(cinfo->dev->of_node, "shmem", NULL)) + if (of_property_present(cinfo->dev->of_node, "shmem")) return setup_static_shmem(dev, cinfo, channel); else return setup_dynamic_shmem(dev, channel); diff --git a/drivers/firmware/tegra/bpmp.c b/drivers/firmware/tegra/bpmp.c index 042c2043929d..8b5e5daa9fae 100644 --- a/drivers/firmware/tegra/bpmp.c +++ b/drivers/firmware/tegra/bpmp.c @@ -764,19 +764,19 @@ static int tegra_bpmp_probe(struct platform_device *pdev) if (err < 0) goto free_mrq; - if (of_find_property(pdev->dev.of_node, "#clock-cells", NULL)) { + if (of_property_present(pdev->dev.of_node, "#clock-cells")) { err = tegra_bpmp_init_clocks(bpmp); if (err < 0) goto free_mrq; } - if (of_find_property(pdev->dev.of_node, "#reset-cells", NULL)) { + if (of_property_present(pdev->dev.of_node, "#reset-cells")) { err = tegra_bpmp_init_resets(bpmp); if (err < 0) goto free_mrq; } - if (of_find_property(pdev->dev.of_node, "#power-domain-cells", NULL)) { + if (of_property_present(pdev->dev.of_node, "#power-domain-cells")) { err = tegra_bpmp_init_powergates(bpmp); if (err < 0) goto free_mrq;
It is preferred to use typed property access functions (i.e. of_property_read_<type> functions) rather than low-level of_get_property/of_find_property functions for reading properties. As part of this, convert of_get_property/of_find_property calls to the recently added of_property_present() helper when we just want to test for presence of a property and nothing more. Signed-off-by: Rob Herring <robh@kernel.org> --- drivers/firmware/arm_scmi/optee.c | 2 +- drivers/firmware/tegra/bpmp.c | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-)