diff mbox series

[1/3] dt-bindings: arm: ti: Add bindings for BeaglePlay

Message ID 20230311111022.23717-2-nm@ti.com (mailing list archive)
State New, archived
Headers show
Series arm64: dts/defconfig/binding: Add support for BeaglePlay | expand

Commit Message

Nishanth Menon March 11, 2023, 11:10 a.m. UTC 
From: Robert Nelson <robertcnelson@gmail.com>

This board is based on ti,am625

https://beagleplay.org/
https://git.beagleboard.org/beagleplay/beagleplay

Co-developed-by: Nishanth Menon <nm@ti.com>
Signed-off-by: Nishanth Menon <nm@ti.com>
Signed-off-by: Robert Nelson <robertcnelson@gmail.com>
---
 Documentation/devicetree/bindings/arm/ti/k3.yaml | 1 +
 1 file changed, 1 insertion(+)

Comments

Krzysztof Kozlowski March 11, 2023, 4 p.m. UTC | #1 
On 11/03/2023 12:10, Nishanth Menon wrote:
> From: Robert Nelson <robertcnelson@gmail.com>
> 
> This board is based on ti,am625

Subject: drop second/last, redundant "bindings for". The "dt-bindings"
prefix is already stating that these are bindings.

> 
> https://beagleplay.org/
> https://git.beagleboard.org/beagleplay/beagleplay
> 
> Co-developed-by: Nishanth Menon <nm@ti.com>
> Signed-off-by: Nishanth Menon <nm@ti.com>
> Signed-off-by: Robert Nelson <robertcnelson@gmail.com>

Your chain order is not correct. If Robert is the author, his SoB is first.

> ---
>  Documentation/devicetree/bindings/arm/ti/k3.yaml | 1 +
>  1 file changed, 1 insertion(+)

Best regards,
Krzysztof
Nishanth Menon March 13, 2023, 4 p.m. UTC | #2 
On 17:00-20230311, Krzysztof Kozlowski wrote:
> On 11/03/2023 12:10, Nishanth Menon wrote:
> > From: Robert Nelson <robertcnelson@gmail.com>
> > 
> > This board is based on ti,am625
> 
> Subject: drop second/last, redundant "bindings for". The "dt-bindings"
> prefix is already stating that these are bindings.
> 
> > 
> > https://beagleplay.org/
> > https://git.beagleboard.org/beagleplay/beagleplay
> > 
> > Co-developed-by: Nishanth Menon <nm@ti.com>
> > Signed-off-by: Nishanth Menon <nm@ti.com>
> > Signed-off-by: Robert Nelson <robertcnelson@gmail.com>
> 
> Your chain order is not correct. If Robert is the author, his SoB is first.

Thanks for reviewing. will fixup and redo the series.
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/arm/ti/k3.yaml b/Documentation/devicetree/bindings/arm/ti/k3.yaml
index a60a4065caa8..b4703ac88f04 100644
--- a/Documentation/devicetree/bindings/arm/ti/k3.yaml
+++ b/Documentation/devicetree/bindings/arm/ti/k3.yaml
@@ -28,6 +28,7 @@  properties:
       - description: K3 AM625 SoC
         items:
           - enum:
+              - beagle,am625-beagleplay
               - ti,am625-sk
           - const: ti,am625