diff mbox series

[-next] i2c: xiic: Use devm_platform_get_and_ioremap_resource()

Message ID 20230316054325.108457-1-yang.lee@linux.alibaba.com (mailing list archive)
State New, archived
Headers show
Series [-next] i2c: xiic: Use devm_platform_get_and_ioremap_resource() | expand

Commit Message

Yang Li March 16, 2023, 5:43 a.m. UTC
According to commit 890cc39a8799 ("drivers: provide
devm_platform_get_and_ioremap_resource()"), convert
platform_get_resource(), devm_ioremap_resource() to a single
call to devm_platform_get_and_ioremap_resource(), as this is exactly
what this function does.

Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---
 drivers/i2c/busses/i2c-xiic.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

Michal Simek March 21, 2023, 2:43 p.m. UTC | #1
On 3/16/23 06:43, Yang Li wrote:
> According to commit 890cc39a8799 ("drivers: provide
> devm_platform_get_and_ioremap_resource()"), convert
> platform_get_resource(), devm_ioremap_resource() to a single
> call to devm_platform_get_and_ioremap_resource(), as this is exactly
> what this function does.
> 
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> ---
>   drivers/i2c/busses/i2c-xiic.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/i2c/busses/i2c-xiic.c b/drivers/i2c/busses/i2c-xiic.c
> index dbb792fc197e..0eea00d10545 100644
> --- a/drivers/i2c/busses/i2c-xiic.c
> +++ b/drivers/i2c/busses/i2c-xiic.c
> @@ -1233,8 +1233,7 @@ static int xiic_i2c_probe(struct platform_device *pdev)
>                  i2c->quirks = data->quirks;
>          }
> 
> -       res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -       i2c->base = devm_ioremap_resource(&pdev->dev, res);
> +       i2c->base = devm_platform_get_and_ioremap_resource(pdev, 0, &res);
>          if (IS_ERR(i2c->base))
>                  return PTR_ERR(i2c->base);
> 
> --
> 2.20.1.7.g153144c
> 

Reviewed-by: Michal Simek <michal.simek@amd.com>

Thanks,
Michal
Wolfram Sang March 29, 2023, 7:14 p.m. UTC | #2
On Thu, Mar 16, 2023 at 01:43:25PM +0800, Yang Li wrote:
> According to commit 890cc39a8799 ("drivers: provide
> devm_platform_get_and_ioremap_resource()"), convert
> platform_get_resource(), devm_ioremap_resource() to a single
> call to devm_platform_get_and_ioremap_resource(), as this is exactly
> what this function does.
> 
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>

Applied to for-next, thanks!
diff mbox series

Patch

diff --git a/drivers/i2c/busses/i2c-xiic.c b/drivers/i2c/busses/i2c-xiic.c
index dbb792fc197e..0eea00d10545 100644
--- a/drivers/i2c/busses/i2c-xiic.c
+++ b/drivers/i2c/busses/i2c-xiic.c
@@ -1233,8 +1233,7 @@  static int xiic_i2c_probe(struct platform_device *pdev)
 		i2c->quirks = data->quirks;
 	}
 
-	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-	i2c->base = devm_ioremap_resource(&pdev->dev, res);
+	i2c->base = devm_platform_get_and_ioremap_resource(pdev, 0, &res);
 	if (IS_ERR(i2c->base))
 		return PTR_ERR(i2c->base);