From patchwork Tue Mar 21 07:27:06 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexander Stein X-Patchwork-Id: 13182338 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 758FCC6FD1D for ; Tue, 21 Mar 2023 07:28:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=fYo1B9vaDUfLKxPR6j7nRVhiZCpllsxRNgEqGc1jyRc=; b=OofRXTU7us2e36 cphV7vDhGqzRwf1tAaoPL6b0uvlLgdSUf05JXMRk1ZBKG8llbCybomiZxNGLEdxmYzz5WKSfW9sds A2ED1adEUaYRjwDVUNIDsln4/OjtGITlgAZcsohdzVFZoedJIoBB5ctdXStk/ARjKvw0/QrInWJHB 4BDLGRFURkTz7/Hiijzhesmnb5hhp79xHwLytM9uGJgR/XTTyIOpjlz9ZN8+ZhiLXQtXhslycw4YL /GA1LcpNYNeEjowrPQqpp7e0i1mOptJOyTuzfb6gaRMmJI50wGyfXYka6oohxaxsQ516FMP0hom5l gdhb6YNPkr1wUpHub0dA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1peWOx-00BWbK-1F; Tue, 21 Mar 2023 07:27:23 +0000 Received: from mx1.tq-group.com ([93.104.207.81]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1peWOp-00BWXX-13 for linux-arm-kernel@lists.infradead.org; Tue, 21 Mar 2023 07:27:16 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1679383635; x=1710919635; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=o91knlkLKj3jVc/NrGbR0CpGKWa9jyYUipzes/AkaMw=; b=SCbzR5JD8AWOJtQhyDiab1+s5kPgQB7BCJ0MqA9QAx+cqzTlmkvy6r+g 8inH8/CL+Ir+TzHLB128Sb9pnQOrmG4PgPiqJV5ZBPbT5ObEo5LzIKXiW 6cVVHuo3ol4Cb9SIIjYMu11jjv0ubyATAxzuH0BS65YRvV1o1/dp3FWsV /v9GdiJgZDrad0WXvnEztbUblzvMs8bwGjlq5JxhDbg0L4VX5KHHXy/pe LikzD0NSbUYJm2IdyuuyQDlO4qLDkQp1hDZJlm+/ZxxdhNj7UV3ugBH2C Rpt95/IIkp0BMbwZmM+N8USnjR2gu5hYVBo2do9mdBDYM7gJlpX7q+X/d w==; X-IronPort-AV: E=Sophos;i="5.98,278,1673910000"; d="scan'208";a="29819255" Received: from unknown (HELO tq-pgp-pr1.tq-net.de) ([192.168.6.15]) by mx1-pgp.tq-group.com with ESMTP; 21 Mar 2023 08:27:11 +0100 Received: from mx1.tq-group.com ([192.168.6.7]) by tq-pgp-pr1.tq-net.de (PGP Universal service); Tue, 21 Mar 2023 08:27:11 +0100 X-PGP-Universal: processed; by tq-pgp-pr1.tq-net.de on Tue, 21 Mar 2023 08:27:11 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1679383631; x=1710919631; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=o91knlkLKj3jVc/NrGbR0CpGKWa9jyYUipzes/AkaMw=; b=ekKk470CNBQXkzO6EW0Nydqwb4YgYglRqb63K6aaXQGzybvlG4aXbm7K iSfuh8gy1f9gPzFvWZLbMUdh2755nI01x2RK6Ydu9mQkOaRLsepeu4cNA A/MHZqgqeBfX1TsKhyp60Q5/dtfj04YW3wunkbcf4Kl9qfzWo8+kRmNs6 WTTAHb0WOIJPE+BLJRAn8tLrZZ2LeQ/qgWgvTL+DAx2fKT7BVUyy2cQFK lBkkU/uSrJKnA3PYrSbqHEmqDdwBvCo0zfgpkAl6r+Y7QEEgOcws3K3Ml qjaWKqpHYfpp9YUK3vQ2OmtGC9sWKMxWgq8mvcXmlGCS0zQSxS5mbTEcp A==; X-IronPort-AV: E=Sophos;i="5.98,278,1673910000"; d="scan'208";a="29819254" Received: from vtuxmail01.tq-net.de ([10.115.0.20]) by mx1.tq-group.com with ESMTP; 21 Mar 2023 08:27:11 +0100 Received: from steina-w.tq-net.de (unknown [10.123.53.21]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by vtuxmail01.tq-net.de (Postfix) with ESMTPSA id 25D2F280072; Tue, 21 Mar 2023 08:27:11 +0100 (CET) From: Alexander Stein To: Rui Miguel Silva , Laurent Pinchart , Mauro Carvalho Chehab , Shawn Guo , Sascha Hauer , Fabio Estevam Cc: Alexander Stein , Pengutronix Kernel Team , NXP Linux Team , linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH v2 1/2] media: imx: imx7-media-csi: Fix mbus framefmt field init Date: Tue, 21 Mar 2023 08:27:06 +0100 Message-Id: <20230321072707.678039-2-alexander.stein@ew.tq-group.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230321072707.678039-1-alexander.stein@ew.tq-group.com> References: <20230321072707.678039-1-alexander.stein@ew.tq-group.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230321_002715_667852_5A31F669 X-CRM114-Status: GOOD ( 11.91 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org 'field' is zero-initialized to V4L2_FIELD_ANY, which is an invalid value to return to userspace. Instead fefault to non-interleaving. Signed-off-by: Alexander Stein Reviewed-by: Laurent Pinchart Reviewed-by: Rui Miguel Silva --- drivers/media/platform/nxp/imx7-media-csi.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/platform/nxp/imx7-media-csi.c b/drivers/media/platform/nxp/imx7-media-csi.c index c22bf5c827e7..3e97b9f2ff69 100644 --- a/drivers/media/platform/nxp/imx7-media-csi.c +++ b/drivers/media/platform/nxp/imx7-media-csi.c @@ -1610,6 +1610,7 @@ static int imx7_csi_video_init_format(struct imx7_csi *csi) format.code = IMX7_CSI_DEF_MBUS_CODE; format.width = IMX7_CSI_DEF_PIX_WIDTH; format.height = IMX7_CSI_DEF_PIX_HEIGHT; + format.field = V4L2_FIELD_NONE; imx7_csi_mbus_fmt_to_pix_fmt(&csi->vdev_fmt, &format, NULL); csi->vdev_compose.width = format.width;