diff mbox series

arm64: defconfig: Enable CAN PHY transceiver driver

Message ID 20230323100624.337354-1-b-kapoor@ti.com (mailing list archive)
State New, archived
Headers show
Series arm64: defconfig: Enable CAN PHY transceiver driver | expand

Commit Message

Bhavya Kapoor March 23, 2023, 10:06 a.m. UTC 
Enable CAN PHY transceiver driver to be built as a module.

Signed-off-by: Bhavya Kapoor <b-kapoor@ti.com>
---
 arch/arm64/configs/defconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

Geert Uytterhoeven March 23, 2023, 10:14 a.m. UTC | #1 
Hi Bhavya,

On Thu, Mar 23, 2023 at 11:06 AM Bhavya Kapoor <b-kapoor@ti.com> wrote:
> Enable CAN PHY transceiver driver to be built as a module.
>
> Signed-off-by: Bhavya Kapoor <b-kapoor@ti.com>

Thanks for your patch!
(I wanted to send a similar patch soon ;-)

> --- a/arch/arm64/configs/defconfig
> +++ b/arch/arm64/configs/defconfig
> @@ -368,6 +368,7 @@ CONFIG_REALTEK_PHY=y
>  CONFIG_ROCKCHIP_PHY=y
>  CONFIG_DP83867_PHY=y
>  CONFIG_VITESSE_PHY=y
> +CONFIG_PHY_CAN_TRANSCEIVER=m

This doesn't look like the right spot to insert this?

Based on "make savedefconfig", I'd say:

     CONFIG_PHY_XGENE=y
   +CONFIG_PHY_CAN_TRANSCEIVER=m
     CONFIG_PHY_SUN4I_USB=y

>  CONFIG_CAN_FLEXCAN=m
>  CONFIG_CAN_RCAR=m
>  CONFIG_CAN_RCAR_CANFD=m
> --
> 2.34.1

Gr{oetje,eeting}s,

                        Geert
Bhavya Kapoor March 23, 2023, 10:42 a.m. UTC | #2 
On 23/03/23 15:44, Geert Uytterhoeven wrote:
> Hi Bhavya,
>
> On Thu, Mar 23, 2023 at 11:06 AM Bhavya Kapoor <b-kapoor@ti.com> wrote:
>> Enable CAN PHY transceiver driver to be built as a module.
>>
>> Signed-off-by: Bhavya Kapoor <b-kapoor@ti.com>
> Thanks for your patch!
> (I wanted to send a similar patch soon ;-)
>
>> --- a/arch/arm64/configs/defconfig
>> +++ b/arch/arm64/configs/defconfig
>> @@ -368,6 +368,7 @@ CONFIG_REALTEK_PHY=y
>>   CONFIG_ROCKCHIP_PHY=y
>>   CONFIG_DP83867_PHY=y
>>   CONFIG_VITESSE_PHY=y
>> +CONFIG_PHY_CAN_TRANSCEIVER=m
> This doesn't look like the right spot to insert this?
>
> Based on "make savedefconfig", I'd say:
>
>       CONFIG_PHY_XGENE=y
>     +CONFIG_PHY_CAN_TRANSCEIVER=m
>       CONFIG_PHY_SUN4I_USB=y

Yeah . Thanks Geert. I will send a v2 ensuring its in correct spot,

>>   CONFIG_CAN_FLEXCAN=m
>>   CONFIG_CAN_RCAR=m
>>   CONFIG_CAN_RCAR_CANFD=m
>> --
>> 2.34.1
> Gr{oetje,eeting}s,
>
>                          Geert
>
diff mbox series

Patch

diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
index 7790ee42c68a..8a6c8f523357 100644
--- a/arch/arm64/configs/defconfig
+++ b/arch/arm64/configs/defconfig
@@ -368,6 +368,7 @@  CONFIG_REALTEK_PHY=y
 CONFIG_ROCKCHIP_PHY=y
 CONFIG_DP83867_PHY=y
 CONFIG_VITESSE_PHY=y
+CONFIG_PHY_CAN_TRANSCEIVER=m
 CONFIG_CAN_FLEXCAN=m
 CONFIG_CAN_RCAR=m
 CONFIG_CAN_RCAR_CANFD=m