| Message ID | 20230403025230.25035-7-chunfeng.yun@mediatek.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/7] usb: mtu3: give back request when rx error happens | expand |
Il 03/04/23 04:52, Chunfeng Yun ha scritto: > Add optional clock 'xhci_ck' which is usually the same as sys_ck, but > some SoC use two separated clocks when the controller supports dual > role mode; > Add optional clock 'frmcnt_ck' used on 4nm or advanced process SoC. This needs more details, because from what it seems, `xhci_ck` could be a children of `sys_ck`, in which case there would be no need to add that to this driver, as it'd be handled by the clock API instead. What SoC is this for? Regards, Angelo
On Mon, 2023-04-03 at 14:34 +0200, AngeloGioacchino Del Regno wrote: > External email : Please do not click links or open attachments until > you have verified the sender or the content. > > > Il 03/04/23 04:52, Chunfeng Yun ha scritto: > > Add optional clock 'xhci_ck' which is usually the same as sys_ck, > > but > > some SoC use two separated clocks when the controller supports dual > > role mode; > > Add optional clock 'frmcnt_ck' used on 4nm or advanced process SoC. > > This needs more details, because from what it seems, `xhci_ck` could > be > a children of `sys_ck`, No, it's not child of 'sys_ck', they are all the 125Mhz clocks. > in which case there would be no need to add that > to this driver, as it'd be handled by the clock API instead. > > What SoC is this for? encounter the issue on mt8195 > > Regards, > Angelo >
diff --git a/drivers/usb/mtu3/mtu3.h b/drivers/usb/mtu3/mtu3.h index 2d7b57e07eee..b4a7662dded5 100644 --- a/drivers/usb/mtu3/mtu3.h +++ b/drivers/usb/mtu3/mtu3.h @@ -90,7 +90,7 @@ struct mtu3_request; */ #define EP0_RESPONSE_BUF 6 -#define BULK_CLKS_CNT 4 +#define BULK_CLKS_CNT 6 /* device operated link and speed got from DEVICE_CONF register */ enum mtu3_speed { diff --git a/drivers/usb/mtu3/mtu3_plat.c b/drivers/usb/mtu3/mtu3_plat.c index d78ae52b4e26..6f264b129243 100644 --- a/drivers/usb/mtu3/mtu3_plat.c +++ b/drivers/usb/mtu3/mtu3_plat.c @@ -234,6 +234,8 @@ static int get_ssusb_rscs(struct platform_device *pdev, struct ssusb_mtk *ssusb) clks[1].id = "ref_ck"; clks[2].id = "mcu_ck"; clks[3].id = "dma_ck"; + clks[4].id = "xhci_ck"; + clks[5].id = "frmcnt_ck"; ret = devm_clk_bulk_get_optional(dev, BULK_CLKS_CNT, clks); if (ret) return ret;
Add optional clock 'xhci_ck' which is usually the same as sys_ck, but some SoC use two separated clocks when the controller supports dual role mode; Add optional clock 'frmcnt_ck' used on 4nm or advanced process SoC. Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com> --- drivers/usb/mtu3/mtu3.h | 2 +- drivers/usb/mtu3/mtu3_plat.c | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-)