From patchwork Thu Apr 6 01:09:35 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Rix X-Patchwork-Id: 13202760 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 89824C761A6 for ; Thu, 6 Apr 2023 01:11:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=eFj1hvkX9w/1Lmp5k7ASkkOmB/Zci7nnw19rt5Ioc7w=; b=WkovHgHWdjg8Rj 2DT8MdmTWA5O2AUwEa+hud4ShxMvMS45Ja2AdOY8eIQfrg6fdpQZliN+Dd04PrOGcvi7L+4aF4PA8 HlxOcVxh9BxLnTYwfTcpRjtXJ2jKwEtLwxldRIpALsxY7aOQk7nx0xQC5zJlDD8AF20GG+2NTdSWm 4IQE/7NoKCb8gIjMXs2mIsoHagjwHbFjBfNFPYY+DFWCqBZIxt6IDZW+g4SJhnzlCgHgRDCCW1Yrq geD05KH4AkEoLpU5ILKSWhwiQ3MfaQAwkODWeiL/6KnvX6UryMJAkXrjEkHOKbjGuUBsLlNOFhIQh 98sWhCWccZPfDA/m+GXw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pkE8K-0060zS-2p; Thu, 06 Apr 2023 01:09:48 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pkE8H-0060yf-2H for linux-arm-kernel@lists.infradead.org; Thu, 06 Apr 2023 01:09:47 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1680743381; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=gHoyjTxQNsIixkHB5UoenspL4I5fGKVvNYeLFs2CchU=; b=YkPSSff9ohIB9n+mdb3q85tuvq4RhqgPA27IUxmt6Ei8Xl82q/E7w2tsMKCDz+qiq25K+o dMGfXoZJa7IqQhqNaCYneUEtMCAq5Ll1ldMZJBd+ldDuZRYu/rT3s9hVnPumMDzG+a4r1Y tshMum7GUpXpJiqSW7WaZyXZ5ZyukqM= Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-171-JaYy8mTpNbaecI4KNHw_-A-1; Wed, 05 Apr 2023 21:09:39 -0400 X-MC-Unique: JaYy8mTpNbaecI4KNHw_-A-1 Received: by mail-qv1-f71.google.com with SMTP id l18-20020ad44bd2000000b005a9cf5f609eso17206400qvw.15 for ; Wed, 05 Apr 2023 18:09:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680743379; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=gHoyjTxQNsIixkHB5UoenspL4I5fGKVvNYeLFs2CchU=; b=R6GLppWq8LsPmkde9TYhTFXl6rsuIqtHk3FBeklvgxb8Yun4oMZoA32hVcUmtKCB1x yfT2GQKAKCPZnJXX4X809FcvZwgx2rmtibHnxG/KF98l8WCaLI+yGCQCtOT1n/WMd4GR GNq/yAPpdmAN2q3PVtzdPWqXbjq0GevxnF80abGf4q+6vf6rDv1tvsw885xSsbDeVdkR KD8caXbwbt+45B7UdT0hHErNlbuxpkxn4gR0YdyVW4j8Tm9QHybbLZ5RrXqcZtwBUnqa 9srdXpKTA4+cqGS7Fnmgd5FUKQ9nczMhzfPhBltdEj7/S45dtGC2eJuXkrUiyNET0sb5 rOuQ== X-Gm-Message-State: AAQBX9cv0XqnMS/TJ4HvS1sVeFobAuKy9BJq8tz7UwNErguDCO3vHJPm FUG9wrWCjyIYL5DW2ihLNlHwaNDz5pl65B2wTuaGsbV13Et3vwmgG6TiDM8Os0CpbjhryY2Etod USwZ7cFmzm6ENRlORDKHuCegu8PPzarDMnqk= X-Received: by 2002:ac8:5f10:0:b0:3db:7f42:ab0f with SMTP id x16-20020ac85f10000000b003db7f42ab0fmr8396463qta.67.1680743379405; Wed, 05 Apr 2023 18:09:39 -0700 (PDT) X-Google-Smtp-Source: AKy350ZIbqKuhrrAyaCl1AzzFxLvOp0zEgA8xN+j2J99j+/2qw3uGQfHd57fnQTzqA2s828Rsp3zMQ== X-Received: by 2002:ac8:5f10:0:b0:3db:7f42:ab0f with SMTP id x16-20020ac85f10000000b003db7f42ab0fmr8396435qta.67.1680743379073; Wed, 05 Apr 2023 18:09:39 -0700 (PDT) Received: from dell-per740-01.7a2m.lab.eng.bos.redhat.com (nat-pool-bos-t.redhat.com. [66.187.233.206]) by smtp.gmail.com with ESMTPSA id f9-20020ac84989000000b003defe5ab4aesm56174qtq.94.2023.04.05.18.09.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Apr 2023 18:09:38 -0700 (PDT) From: Tom Rix To: mturquette@baylibre.com, sboyd@kernel.org, matthias.bgg@gmail.com, angelogioacchino.delregno@collabora.com, wenst@chromium.org, edward-jw.yang@mediatek.com, johnson.wang@mediatek.com Cc: linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Tom Rix Subject: [PATCH] clk: mediatek: fhctl: set varaiables fhctl_offset_v1,2 storage-class-specifier to static Date: Wed, 5 Apr 2023 21:09:35 -0400 Message-Id: <20230406010935.1944976-1-trix@redhat.com> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230405_180945_842430_54C6561E X-CRM114-Status: GOOD ( 11.87 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org smatch reports drivers/clk/mediatek/clk-fhctl.c:17:27: warning: symbol 'fhctl_offset_v1' was not declared. Should it be static? drivers/clk/mediatek/clk-fhctl.c:30:27: warning: symbol 'fhctl_offset_v2' was not declared. Should it be static? These variables are only used in one file so should be static. Signed-off-by: Tom Rix --- drivers/clk/mediatek/clk-fhctl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/clk/mediatek/clk-fhctl.c b/drivers/clk/mediatek/clk-fhctl.c index 45e4842cbf04..33b6ad8fdc2e 100644 --- a/drivers/clk/mediatek/clk-fhctl.c +++ b/drivers/clk/mediatek/clk-fhctl.c @@ -14,7 +14,7 @@ #define PERCENT_TO_DDSLMT(dds, percent_m10) \ ((((dds) * (percent_m10)) >> 5) / 100) -const struct fhctl_offset fhctl_offset_v1 = { +static const struct fhctl_offset fhctl_offset_v1 = { .offset_hp_en = 0x0, .offset_clk_con = 0x4, .offset_rst_con = 0x8, @@ -27,7 +27,7 @@ const struct fhctl_offset fhctl_offset_v1 = { .offset_mon = 0x10, }; -const struct fhctl_offset fhctl_offset_v2 = { +static const struct fhctl_offset fhctl_offset_v2 = { .offset_hp_en = 0x0, .offset_clk_con = 0x8, .offset_rst_con = 0xc,