From patchwork Thu Apr 6 12:46:22 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jim Quinlan X-Patchwork-Id: 13203262 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7B7E5C76196 for ; Thu, 6 Apr 2023 12:47:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:List-Subscribe:List-Help: List-Post:List-Archive:List-Unsubscribe:List-Id:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=dFNS0YU9hH+A6eeUsmlEpq2XqTHqqbu6p/MPihgreIA=; b=hQTSZDkT47Z07q 4NGnRVI8oJfv6blOwO9ShYhM+5HCzyud06bWsyvwh7pmw200dMkWdGh+ap2VT58Af5P0iCc6Uu3bw BiWvaC1lNvArFySXXbBCQWziXkSGO6JfdtJVNVmkuTLOgRrb7IXL6I8WgIAZGD92Q/iGqYs9kv2YH XjBRHzEnpBGWstXijhlaT6tZWO5zzSs6jtFNm6X05MxNiLGBzU5RPKB2Eb7HjZ9US7TDd9pq7CtHr xQZ7C8huDQK1dqYuh3w7Huqib+kQMfBwisM3arXyIEgLRNNyJ3ZtzweuywtAfqZsy7wvQWguVNHCF m2GTq6wD0naCzCmLCoOQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pkP0h-007Icj-28; Thu, 06 Apr 2023 12:46:39 +0000 Received: from mail-wr1-x432.google.com ([2a00:1450:4864:20::432]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pkP0e-007Iat-24; Thu, 06 Apr 2023 12:46:37 +0000 Received: by mail-wr1-x432.google.com with SMTP id m2so39394423wrh.6; Thu, 06 Apr 2023 05:46:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1680785194; x=1683377194; h=references:in-reply-to:message-id:date:subject:cc:to:from:from:to :cc:subject:date:message-id:reply-to; bh=3LUgCUJ3lXTo0RsvH/e7ul2FIIbwJbMNQXvMnaF6Gq4=; b=YEXNElF0x1G42w/wvyNTyJh0dveBWTtOv6zbgd/Bp4gcjiY9FExF23E6K50/sLYrf6 c0WbSEUkbL1PSTW7P1umKVPPBnzICqaxE1ZNGV4xhal7onQBwSPOdBTKdiTlaN3hlDYf /aNNSmi07+DYGmJAGOePXcY/wc51pWc+jFxGvEvkcaPLApo6Re+4LqvKRP8+YTKvRxwk YAuIP/byNfMMmIEhal2lQNyFCEHoyBgYHesAjQY320EBMR9Z4u18WtD6hMLYoBLN72tv 8gtbkPBezf8WrA4bSuFscLwvHA1xvq5wtetFmjY5gzs1y/jnhHVuePZOqSpAbQhnpJSw gOWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680785194; x=1683377194; h=references:in-reply-to:message-id:date:subject:cc:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=3LUgCUJ3lXTo0RsvH/e7ul2FIIbwJbMNQXvMnaF6Gq4=; b=1aG/6kDxU3bR6KqCNdS6ttP9LUYcKLUJyUe9bookb29/fMP6JyhpAYUuoTe+8f8qz7 qK1g5nkBEum+ahwHXV0d+wWX9Ky6qwAv6Q88Wyipr2cdq4LchwSitvPezMTO8AUaaA7e tXPnioPBgWBzPUl4CNVa9kUCvu9l9OXCg48vVcUyzz77r6X29qHAc1ET3aMskmGN3FWX RhX1HFRAJnqZUq2yLqOna2mk6/X3QLgYepYXBnCFF62/3Pm9XZdWzrTnHW554TxfkKYZ UKTsBmO7jRW6z2WUbZlYPya1nGnNbVmyvQ3lQ4oy9LaF/YHc3Kc6clppTgg1Pc0rWcjK 1diA== X-Gm-Message-State: AAQBX9fvsRWv3L0uSiOibA3hwZ2Tk3mndEbVdoB/AiXl4IXxQmGx7uJX 0W0SWJpT6WGz2dkk3VagvKY= X-Google-Smtp-Source: AKy350Y1VoC6dI1BR5IOebNUYDGa+b6oqfYVY3ZsWbCSAEklsLWdeoNxHjcKtSx8SrlQXe1Bf4F+GQ== X-Received: by 2002:a5d:654e:0:b0:2cf:e3e3:5b01 with SMTP id z14-20020a5d654e000000b002cfe3e35b01mr5955177wrv.56.1680785194377; Thu, 06 Apr 2023 05:46:34 -0700 (PDT) Received: from stbsrv-and-01.and.broadcom.net ([192.19.144.250]) by smtp.gmail.com with ESMTPSA id n10-20020adff08a000000b002c5534db60bsm1686714wro.71.2023.04.06.05.46.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Apr 2023 05:46:33 -0700 (PDT) From: Jim Quinlan To: linux-pci@vger.kernel.org, Nicolas Saenz Julienne , Bjorn Helgaas , Lorenzo Pieralisi , Cyril Brulebois , Phil Elwell , bcm-kernel-feedback-list@broadcom.com, jim2101024@gmail.com, james.quinlan@broadcom.com Cc: Florian Fainelli , Lorenzo Pieralisi , =?utf-8?q?Krzysztof_Wilczy=C5=84?= =?utf-8?q?ski?= , Rob Herring , Krzysztof Kozlowski , linux-rpi-kernel@lists.infradead.org (moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE), linux-arm-kernel@lists.infradead.org (moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE), devicetree@vger.kernel.org (open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS), linux-kernel@vger.kernel.org (open list) Subject: [PATCH v1 1/3] dt-bindings: PCI: brcmstb: Add two optional props Date: Thu, 6 Apr 2023 08:46:22 -0400 Message-Id: <20230406124625.41325-2-jim2101024@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20230406124625.41325-1-jim2101024@gmail.com> References: <20230406124625.41325-1-jim2101024@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230406_054636_675718_70C519F7 X-CRM114-Status: GOOD ( 12.06 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Regarding "brcm,enable-l1ss": The Broadcom STB/CM PCIe HW -- which is also used by RPi SOCs -- requires the driver probe to configure one of three clkreq# modes: (a) clkreq# driven by the RC (b) clkreq# driven by the EP for ASPM L0s, L1 (c) bidirectional clkreq#, as used for L1 Substates (L1SS). The HW can tell the difference between (a) and (b), but does not know when to configure (c). Further, the HW will cause a CPU abort on boot if guesses wrong regarding the need for (c). So we introduce the boolean "brcm,enable-l1ss" property to indicate that (c) is desired. This property is already present in the Raspian version of Linux, but the driver implementaion that will follow adds more details and discerns between (a) and (b). Regarding "brcm,completion-timeout-msecs" Our HW will cause a CPU abort if the L1SS exit time is longer than the completion abort timeout. We've been asked to make this configurable, so we are introducing "brcm,completion-abort-msecs". Signed-off-by: Jim Quinlan --- .../devicetree/bindings/pci/brcm,stb-pcie.yaml | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml b/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml index 7e15aae7d69e..ef4ccc05b258 100644 --- a/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml +++ b/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml @@ -64,6 +64,18 @@ properties: aspm-no-l0s: true + brcm,enable-l1ss: + description: Indicates that the downstream device is L1SS + capable and L1SS is desired, e.g. by setting + CONFIG_PCIEASPM_POWER_SUPERSAVE=y. Note that CLKREQ# + assertion to clock active must be within 400ns. + type: boolean + + brcm,completion-timeout-msecs: + description: Number of msecs before completion timeout + abort occurs. + $ref: /schemas/types.yaml#/definitions/uint32 + brcm,scb-sizes: description: u64 giving the 64bit PCIe memory viewport size of a memory controller. There may be up to