| Message ID | 20230406215315.13280-3-cniedermaier@dh-electronics.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [V3,1/4] dt-bindings: Add Marantec vendor prefix | expand |
On 06/04/2023 23:53, Christoph Niedermaier wrote: > Remove mmc aliases to be able to define them correctly in the board file. > > Signed-off-by: Christoph Niedermaier <cniedermaier@dh-electronics.com> > --- > Cc: Rob Herring <robh+dt@kernel.org> > Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org> > Cc: Shawn Guo <shawnguo@kernel.org> > Cc: Li Yang <leoyang.li@nxp.com> > Cc: Marek Vasut <marex@denx.de> > Cc: Fabio Estevam <festevam@denx.de> > Cc: NXP Linux Team <linux-imx@nxp.com> > Cc: kernel@dh-electronics.com > Cc: devicetree@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > To: linux-arm-kernel@lists.infradead.org > --- > V3: - Add this patch to the series > --- > arch/arm/boot/dts/imx6ull-dhcor-som.dtsi | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/arch/arm/boot/dts/imx6ull-dhcor-som.dtsi b/arch/arm/boot/dts/imx6ull-dhcor-som.dtsi > index 5882c7565f64..a386c1e9bed3 100644 > --- a/arch/arm/boot/dts/imx6ull-dhcor-som.dtsi > +++ b/arch/arm/boot/dts/imx6ull-dhcor-som.dtsi > @@ -11,6 +11,11 @@ > #include "imx6ull.dtsi" > > / { > + aliases { > + /delete-property/ mmc0; > + /delete-property/ mmc1; > + }; You need to re-add them in respective boards: drc02, pdk2 and picoitx. Otherwise you just removed that functionality without any explanation in commit msg. Best regards, Krzysztof
From: Krzysztof Kozlowski [mailto:krzk@kernel.org] Sent: Friday, April 7, 2023 8:57 AM > On 06/04/2023 23:53, Christoph Niedermaier wrote: >> Remove mmc aliases to be able to define them correctly in the board file. >> >> Signed-off-by: Christoph Niedermaier <cniedermaier@dh-electronics.com> >> --- >> Cc: Rob Herring <robh+dt@kernel.org> >> Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org> >> Cc: Shawn Guo <shawnguo@kernel.org> >> Cc: Li Yang <leoyang.li@nxp.com> >> Cc: Marek Vasut <marex@denx.de> >> Cc: Fabio Estevam <festevam@denx.de> >> Cc: NXP Linux Team <linux-imx@nxp.com> >> Cc: kernel@dh-electronics.com >> Cc: devicetree@vger.kernel.org >> Cc: linux-kernel@vger.kernel.org >> To: linux-arm-kernel@lists.infradead.org >> --- >> V3: - Add this patch to the series >> --- >> arch/arm/boot/dts/imx6ull-dhcor-som.dtsi | 5 +++++ >> 1 file changed, 5 insertions(+) >> >> diff --git a/arch/arm/boot/dts/imx6ull-dhcor-som.dtsi b/arch/arm/boot/dts/imx6ull-dhcor-som.dtsi >> index 5882c7565f64..a386c1e9bed3 100644 >> --- a/arch/arm/boot/dts/imx6ull-dhcor-som.dtsi >> +++ b/arch/arm/boot/dts/imx6ull-dhcor-som.dtsi >> @@ -11,6 +11,11 @@ >> #include "imx6ull.dtsi" >> >> / { >> + aliases { >> + /delete-property/ mmc0; >> + /delete-property/ mmc1; >> + }; > > You need to re-add them in respective boards: drc02, pdk2 and picoitx. > Otherwise you just removed that functionality without any explanation in > commit msg. For the drc02, pdk2 and picoitx boards there is an additional SoM layer (DHCOM) between. Therefore, in version 4 I will also adapt the DHCOM SoM layer. Thanks and best regards Christoph
diff --git a/arch/arm/boot/dts/imx6ull-dhcor-som.dtsi b/arch/arm/boot/dts/imx6ull-dhcor-som.dtsi index 5882c7565f64..a386c1e9bed3 100644 --- a/arch/arm/boot/dts/imx6ull-dhcor-som.dtsi +++ b/arch/arm/boot/dts/imx6ull-dhcor-som.dtsi @@ -11,6 +11,11 @@ #include "imx6ull.dtsi" / { + aliases { + /delete-property/ mmc0; + /delete-property/ mmc1; + }; + memory@80000000 { /* Appropriate memory size will be filled by U-Boot */ reg = <0x80000000 0>;
Remove mmc aliases to be able to define them correctly in the board file. Signed-off-by: Christoph Niedermaier <cniedermaier@dh-electronics.com> --- Cc: Rob Herring <robh+dt@kernel.org> Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org> Cc: Shawn Guo <shawnguo@kernel.org> Cc: Li Yang <leoyang.li@nxp.com> Cc: Marek Vasut <marex@denx.de> Cc: Fabio Estevam <festevam@denx.de> Cc: NXP Linux Team <linux-imx@nxp.com> Cc: kernel@dh-electronics.com Cc: devicetree@vger.kernel.org Cc: linux-kernel@vger.kernel.org To: linux-arm-kernel@lists.infradead.org --- V3: - Add this patch to the series --- arch/arm/boot/dts/imx6ull-dhcor-som.dtsi | 5 +++++ 1 file changed, 5 insertions(+)