From patchwork Sat Apr 8 14:34:28 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Rix X-Patchwork-Id: 13205752 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 23B11C77B6C for ; Sat, 8 Apr 2023 14:35:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=ehb4KkU3HAVx0aQ4OmF2zJzPpbrBPF9EpgUSyM8hHSU=; b=STWjXT+kCI5gql mhKaselxKy/GBtaHX22ixCHFIMbZaoAljstKpxNEWlTOd64cm1o4GiU8HDit9V/i2wWtBVvJl0a1n C1c3wXu6S2eQt26VY8VGCBqPpE0pCsPrdtfWtLFyEDeYHFzTu3FwhkJR2knJbm7JH3rFQ979CF7om 0SX7EucS18OJ36vVMQ0Plltj5BUwq86Su0AxAKDd/+1IA0WADqVfwV5s75dNhN8EmymTW1REtvqsh 2DDEVGMSg4ChPy2MWLQj9vRNSYwm3EkEhsv0i5PyelWfSMW5/hXh3DIfiYy+ZSrMwqjr/xx800QgG OzEOQoNdDt0Yc6/RQ/tA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pl9eQ-00CRbm-1m; Sat, 08 Apr 2023 14:34:46 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pl9eL-00CRb7-2Z for linux-arm-kernel@lists.infradead.org; Sat, 08 Apr 2023 14:34:45 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1680964477; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=DkwXScb6wJOf3gN1DF0csk3W5arFQbdl8U7x7u5uuJY=; b=bgBu1m0woOK/ehNOvX8NGnO0jQJpYAAWUxDpwH7aLZ+viS+3omRcmp9UtYyIfsFolihHrq zJ31LWqglx9FqaQW4jlKGU2vYJ2Fo0Jfj9ohj2aAw1Rg0Yid4eYeHqY+l2ysXYUTnorxBs 0w2MLDZIL1V/3E/stoi+beKaHeqjk+4= Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-81-XJgfbalsMM2W5Mvq8kY5zQ-1; Sat, 08 Apr 2023 10:34:36 -0400 X-MC-Unique: XJgfbalsMM2W5Mvq8kY5zQ-1 Received: by mail-qv1-f72.google.com with SMTP id b5-20020a0cbf45000000b005e7e2c57182so2209739qvj.22 for ; Sat, 08 Apr 2023 07:34:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680964475; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=DkwXScb6wJOf3gN1DF0csk3W5arFQbdl8U7x7u5uuJY=; b=zJKe4Z4aj1PFsiwaS+sBAQ/qekrsgjvasyUGhAHvPIx0sUuz7J637mIPPnTjyY7IVC i9uOE610GjCTB0LzUIRLtXKlFodL2u/eT1GH09+216TybnzhU/Wk41laxeZEZ3XyhucF 66J+4PrCAKW2Q8WCrVu1qSHGK5GPLFZc1LRTtaNVj0rpzbOkwj/yQtnv33ZB6zNElJLF yzONXxLY89SlSW/2ydIzM7LfQ6EzzU9pKO6uLAuHt4pOVn5sU9i7sOSd3FfCnPBqApCg fqkob/jpM+65lOffGwrz4DUY5KpHHgeLzJ07jKHLCxnApaOOUI0nphIuNhxViaRRwMmA RMHw== X-Gm-Message-State: AAQBX9emnaMFNYsmEX3RetIu62ztJfbPK58o+s/ogYqKTgZkDWYEx68g ZyK2UKsCqTxHs+0nwLKsdZyDH7nyld2DOfQSph7aIlfq6OuA4L1L401EDX63dBWI5WSQpS/+aBK 4+qA+R9ryxpcYlYLWjPQ2pzVhxB56cDai3eY= X-Received: by 2002:a05:622a:4c7:b0:3e4:dcb4:169 with SMTP id q7-20020a05622a04c700b003e4dcb40169mr9743253qtx.16.1680964475612; Sat, 08 Apr 2023 07:34:35 -0700 (PDT) X-Google-Smtp-Source: AKy350aAR7H0F5jPDDVc1edXP9xa5hxjAFdJuVIN8Z1zdzOziO42c3nt/PGgaPOuNhsa12OAr9APPw== X-Received: by 2002:a05:622a:4c7:b0:3e4:dcb4:169 with SMTP id q7-20020a05622a04c700b003e4dcb40169mr9743220qtx.16.1680964475319; Sat, 08 Apr 2023 07:34:35 -0700 (PDT) Received: from dell-per740-01.7a2m.lab.eng.bos.redhat.com (nat-pool-bos-t.redhat.com. [66.187.233.206]) by smtp.gmail.com with ESMTPSA id g129-20020a37b687000000b0074865a9cb34sm2052931qkf.28.2023.04.08.07.34.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 08 Apr 2023 07:34:35 -0700 (PDT) From: Tom Rix To: wim@linux-watchdog.org, linux@roeck-us.net, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com Cc: linux-watchdog@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Tom Rix Subject: [PATCH] watchdog: imx2_wdt: set variables imx_wdt* storage-class-specifier to static Date: Sat, 8 Apr 2023 10:34:28 -0400 Message-Id: <20230408143428.2704141-1-trix@redhat.com> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230408_073441_932716_AD282A7E X-CRM114-Status: GOOD ( 11.89 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org smatch reports drivers/watchdog/imx2_wdt.c:442:22: warning: symbol 'imx_wdt' was not declared. Should it be static? drivers/watchdog/imx2_wdt.c:446:22: warning: symbol 'imx_wdt_legacy' was not declared. Should it be static? These variables are only used in one file so should be static. Signed-off-by: Tom Rix Reviewed-by: Guenter Roeck --- drivers/watchdog/imx2_wdt.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/watchdog/imx2_wdt.c b/drivers/watchdog/imx2_wdt.c index 19ab7b3d286b..6fcc3596103c 100644 --- a/drivers/watchdog/imx2_wdt.c +++ b/drivers/watchdog/imx2_wdt.c @@ -439,11 +439,11 @@ static int __maybe_unused imx2_wdt_resume(struct device *dev) static SIMPLE_DEV_PM_OPS(imx2_wdt_pm_ops, imx2_wdt_suspend, imx2_wdt_resume); -struct imx2_wdt_data imx_wdt = { +static struct imx2_wdt_data imx_wdt = { .wdw_supported = true, }; -struct imx2_wdt_data imx_wdt_legacy = { +static struct imx2_wdt_data imx_wdt_legacy = { .wdw_supported = false, };