From patchwork Sat Apr 15 09:55:16 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jisheng Zhang X-Patchwork-Id: 13212417 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4D542C77B71 for ; Sat, 15 Apr 2023 10:07:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=AAv4rblB/mL7VrV20S757ljmN72PhOTRct9686TeLmw=; b=wOqYHtiD4+ynRD U6kKcT+f5k9DgjGOM1EnON/g542aHw5vGCC4DLTMLg1n6/E6/HXJN2QWRexGyYS1o+Pj2iC5o3yyV X75vntYsrVpeCKp6AmPm4WOHgK5q+hYBH8tAUi17+ukFIOk2Q9J6HULSJtMDb967fzhbBprgy/fyL Iseoj29pbY61SYUOVBjE6sG/ESSwEHfyKJYDWVCfjHmUyPo9n+UBastNDwQJYiobmAbT+0mHC0H+I TOmhh9a/Y5RUaGh0xpKmRtRxn4ASEYOQtUQw5wLZlqwXVfnBXME0xDWra+xykrBCm0mZHo+3guXgv 2rgkmy0sPT0mpi1y8MEg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pncnh-00BnZr-2C; Sat, 15 Apr 2023 10:06:33 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pncnb-00BnX4-2i for linux-arm-kernel@lists.infradead.org; Sat, 15 Apr 2023 10:06:28 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 69A65611F3; Sat, 15 Apr 2023 10:06:27 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EB230C433A0; Sat, 15 Apr 2023 10:06:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1681553186; bh=VFo8FgxOsge+PUUwYU5GtQjYV19pyPbFfRwwhMQ8hcI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=mf7d8SGx7lp6TgaHpLQ0r7CcypJYZbtSBmAXTL3jgsRPSDHeVn5dk+nkqMOuvfX/D rpiwNkQ9as9hblItcJZWy6w9TRwxMaWShea8qiLPGvqPQ46PcOAA0pZ0yac892+Hp0 SJ/bTaxnjd3VOEb7m6Ou1KFuUOQrat5BUc7/tSJrw0L3boV1nzNUIyUfuWKXDYvtB4 o7qkPlQKkf/09FP/K5eCkKTqeuDXtAjGPOrSyZzAYItEcpWRGeKTZ+/VgF4mZVBKGc LqZ/NnT5JbVQBNCANjWbdDsHKRTXcPzsmJ1I2/gC943MXT3zK5sT7tmJ2jYY0RQf/Z 75cnKVSi5gKWw== From: Jisheng Zhang To: Lars-Peter Clausen , Vinod Koul , Eugeniy Paltsev , Logan Gunthorpe , Sinan Kaya , Andy Gross , Bjorn Andersson , Konrad Dybcio , Orson Zhai , Baolin Wang , Chunyan Zhang Cc: dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org Subject: [PATCH v2 4/5] dmaengine: hidma: Don't set chancnt Date: Sat, 15 Apr 2023 17:55:16 +0800 Message-Id: <20230415095517.2763-5-jszhang@kernel.org> X-Mailer: git-send-email 2.40.0 In-Reply-To: <20230415095517.2763-1-jszhang@kernel.org> References: <20230415095517.2763-1-jszhang@kernel.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230415_030627_927687_199EE1F7 X-CRM114-Status: UNSURE ( 9.89 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The dma framework will calculate the dma channels chancnt, setting it ourself is wrong. Signed-off-by: Jisheng Zhang --- drivers/dma/qcom/hidma.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/dma/qcom/hidma.c b/drivers/dma/qcom/hidma.c index 04d1c33afc12..344525c3a32f 100644 --- a/drivers/dma/qcom/hidma.c +++ b/drivers/dma/qcom/hidma.c @@ -214,7 +214,6 @@ static int hidma_chan_init(struct hidma_dev *dmadev, u32 dma_sig) spin_lock_init(&mchan->lock); list_add_tail(&mchan->chan.device_node, &ddev->channels); - dmadev->ddev.chancnt++; return 0; }