From patchwork Mon Apr 24 09:23:12 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexander Stein X-Patchwork-Id: 13221903 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 26D3CC7618E for ; Mon, 24 Apr 2023 09:24:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=2Fxdxvh0DFnNhkoszOvTvJRuBFu0s3VUiIJWpvz0bOQ=; b=J+XbDfiml4/DvR TWK89g7ezXYcE+t3oSrAIYMNSDhFTtoKXMq7fv19PyyVfmI104lId9Ne8J9tAaK2sFvHphTgN7I6M EDe/NSp3iXV1y3u1zFYq8u5f1Pt113aNjFbsHkZM/IxJtmHW54BwV4puv8LyULvM+r7C6PctV0RVH Y4tes+SL9/BTvYkGASvVc4trbxDMloLRSbiHbQF8RbN185yphb9Gc2He1tBB1FytQ1/lJ/PJvj3aw RqnAHtWO5OpOmVuEeF7sYN9u/bddTcXBronjMneFY65yEYsZSUWP3PwY3ITflqxBnvJADPVkrMky0 sKHuvqZZKTsK3W/lv6Xg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pqsPv-00FmQZ-00; Mon, 24 Apr 2023 09:23:27 +0000 Received: from mx1.tq-group.com ([93.104.207.81]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pqsPr-00FmNV-2A for linux-arm-kernel@lists.infradead.org; Mon, 24 Apr 2023 09:23:25 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1682328203; x=1713864203; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=+MzlbYDAy9LH69SHQ+jHTKd7Y60sbpiM9FfO099q13Q=; b=PvgblLVbcnxt84PWm6lFpRQhS2GuWj6hvdXKdRMqJWIldue9Qq7V6g/1 hlvqG4B7B6zdmIRHY0cED/3YYlC29gk+374Zh30tgwOdYVin2pYwjra6d T2GLSBRRltkXzw8vDeMJlZV7s7AKUZb7V/CKVGzUYw5H2dR/8e69ovDjO 69r2TGf/QbLk61xIwnw5377ZA+rlcn5524lduhj0ZUnS78uEIJOJijH6P 6bgtgv8FwbJSNVbOx/hLEdiWuyzEjWq8I/Q1urz45Kr6eSkueTTdi4wE3 iXZec2agVqWAvXkyCk07jvSfgBwa8i+XwwpGtiL0fKcZaIQCQJJxnbIxM g==; X-IronPort-AV: E=Sophos;i="5.99,222,1677538800"; d="scan'208";a="30510899" Received: from unknown (HELO tq-pgp-pr1.tq-net.de) ([192.168.6.15]) by mx1-pgp.tq-group.com with ESMTP; 24 Apr 2023 11:23:19 +0200 Received: from mx1.tq-group.com ([192.168.6.7]) by tq-pgp-pr1.tq-net.de (PGP Universal service); Mon, 24 Apr 2023 11:23:19 +0200 X-PGP-Universal: processed; by tq-pgp-pr1.tq-net.de on Mon, 24 Apr 2023 11:23:19 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1682328199; x=1713864199; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=+MzlbYDAy9LH69SHQ+jHTKd7Y60sbpiM9FfO099q13Q=; b=ooysYHSOYNJrwhaMF8yGQlBELVG1bbw/3b3Sf6edEoz1E8L2C6oRybG4 FaCPMxQaE0ZOKF28lb01CjsQncOAg0xEM9JM4BGuf48WYngfNPS9/03Po kM3jBDZE6rIOmR0YU22QsZDuCdOBMYw/dDfkGifV/glArMmsw3LZuPn7V VuDtwROtrHYi0ru9iZAJH1PsImkKrSt7Pdz6DWePUKdB2bF/oxN5Mdp1j hB3Pl5X6Rve8fWub1kULR7PmojBY6+ROHkT1WuSdKMvHo4htlwJZSyMxA zjKmJUW3XjAatV5qknmcymk3FN5e/LicnhK7v2Q0KavHyYJwb01k2289U w==; X-IronPort-AV: E=Sophos;i="5.99,222,1677538800"; d="scan'208";a="30510898" Received: from vtuxmail01.tq-net.de ([10.115.0.20]) by mx1.tq-group.com with ESMTP; 24 Apr 2023 11:23:18 +0200 Received: from steina-w.tq-net.de (unknown [10.123.53.21]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by vtuxmail01.tq-net.de (Postfix) with ESMTPSA id A9ED8280056; Mon, 24 Apr 2023 11:23:18 +0200 (CEST) From: Alexander Stein To: Cai Huoqing , Haibo Chen , Jonathan Cameron , Lars-Peter Clausen , Rob Herring , Krzysztof Kozlowski , Shawn Guo , Sascha Hauer , Fabio Estevam Cc: Alexander Stein , Pengutronix Kernel Team , NXP Linux Team , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Marco Felsch Subject: [PATCH v2 1/1] dt-bindings: iio: imx8qxp-adc: add missing vref-supply Date: Mon, 24 Apr 2023 11:23:12 +0200 Message-Id: <20230424092312.61746-1-alexander.stein@ew.tq-group.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230424_022324_090119_81AF6C57 X-CRM114-Status: GOOD ( 12.69 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Although this property is used right now for IIO_CHAN_INFO_SCALE, this ADC has two internal reference voltages, which the driver currently doesn't make use of. Fixes: db73419d8c06 ("dt-bindings: iio: adc: Add binding documentation for NXP IMX8QXP ADC") Signed-off-by: Alexander Stein Acked-by: Krzysztof Kozlowski Reviewed-by: Haibo Chen --- Thanks for your inputs. This improved descritpion should make it clear that this property is only about the external reference voltage, not about the optional, internal voltages. Changes in v2: * Improved commit message subject as suggested * Add hint about feature flag regarding multiple, internal, reference voltages .../devicetree/bindings/iio/adc/nxp,imx8qxp-adc.yaml | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/Documentation/devicetree/bindings/iio/adc/nxp,imx8qxp-adc.yaml b/Documentation/devicetree/bindings/iio/adc/nxp,imx8qxp-adc.yaml index 63369ba388e4..878e67054d7c 100644 --- a/Documentation/devicetree/bindings/iio/adc/nxp,imx8qxp-adc.yaml +++ b/Documentation/devicetree/bindings/iio/adc/nxp,imx8qxp-adc.yaml @@ -39,6 +39,12 @@ properties: power-domains: maxItems: 1 + vref-supply: + description: | + External ADC reference voltage supply on VREFH pad. If VERID[MVI] is + set, there are additional, internal reference voltages selectable. + VREFH1 is always from VREFH pad. + "#io-channel-cells": const: 1 @@ -72,6 +78,7 @@ examples: assigned-clocks = <&clk IMX_SC_R_ADC_0>; assigned-clock-rates = <24000000>; power-domains = <&pd IMX_SC_R_ADC_0>; + vref-supply = <®_1v8>; #io-channel-cells = <1>; }; };