From patchwork Fri Apr 28 19:53:45 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?TsOtY29sYXMgRi4gUi4gQS4gUHJhZG8=?= X-Patchwork-Id: 13226773 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A7DF2C77B61 for ; Fri, 28 Apr 2023 19:55:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=VA+PxgZ/EqRjptAK3hcHMfWkChgWCS4wJBfKvy52rMc=; b=tkHPPBWjo9p7jg MYJ9FE109uCG8IXEWU4YmSIhVqn8KyuwaN23i6tktOz4RyYcF0EvquIdQTP43Cns8rxXrQV/Glvxu 9ISkDFKoYr4pTHA+a8dDiHEXZO9+Zy4brpc5nC97xrmjIVSsPw0ux2RcZk5xT3UULWfSqq2BMscKU 6sWHWZ4pzSiAUgdTEg1VIj/MpBJJQrrre9afu8AqisOGv/xRyxH+kotshLnktwqAxKQUXWwj1c9e7 kd1wjXGuLqDGjrnnuuUUjZfrHDRVQ7+nr3zrQnB17P3cEuKcMXwVCRoBq6e/FTZdIsiBvwvoaY31r pGysSikRm0avWCnkMucw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1psUAS-00BfLZ-27; Fri, 28 Apr 2023 19:54:08 +0000 Received: from madras.collabora.co.uk ([2a00:1098:0:82:1000:25:2eeb:e5ab]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1psUAO-00BfJT-2K; Fri, 28 Apr 2023 19:54:06 +0000 Received: from notapiano.myfiosgateway.com (unknown [194.36.25.39]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: nfraprado) by madras.collabora.co.uk (Postfix) with ESMTPSA id C3C4066032D1; Fri, 28 Apr 2023 20:53:58 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1682711642; bh=bFgsjmGEtfW0DqPTYSfCnvZNjmvGhNo5EmmXdWX0RMQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=VzHKN9+Xo9gY6c2+76j54oDcneZ5dARncJUIODzt+FPHox6K4k6pvdGvIvy68b3PV e6sKAskt4SgE/G7OqiBpykC+azS9k8sN56dYCbG9Rq4VVyYg60oJ2RvbChLoKz9dYd 3zdoD7cJB5qfo2p3ETb+qz8Q/SAnDP/+lrFcH1nlXrSeMAJbduHtYqbrF6aEYbUj8K NPh8u5oZUWztmKyHXFpBFzAIJDikk8Kw7ciVmMzHc2MvM2NG8RveJDxn1EGPDqhe3l 8IMPoItQd8BPXHDoGFD3hxMMFEl87FQuMKQ1b5d/77DNZSYE6QutpYMtlihUqEkIDp 3KNOHzTYvVDpg== From: =?utf-8?b?TsOtY29sYXMgRi4gUi4gQS4gUHJhZG8=?= To: Daniel Lezcano Cc: Alexandre Bailon , kernel@collabora.com, Chen-Yu Tsai , Balsam CHIHI , AngeloGioacchino Del Regno , Alexandre Mergnat , =?utf-8?b?TsOtY29sYXMgRi4gUi4g?= =?utf-8?b?QS4gUHJhZG8=?= , Amit Kucheria , Matthias Brugger , "Rafael J. Wysocki" , Zhang Rui , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-pm@vger.kernel.org Subject: [PATCH 1/3] thermal/drivers/mediatek/lvts_thermal: Handle IRQ on all controllers Date: Fri, 28 Apr 2023 15:53:45 -0400 Message-Id: <20230428195347.3832687-2-nfraprado@collabora.com> X-Mailer: git-send-email 2.40.0 In-Reply-To: <20230428195347.3832687-1-nfraprado@collabora.com> References: <20230428195347.3832687-1-nfraprado@collabora.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230428_125404_908079_8F6494E2 X-CRM114-Status: GOOD ( 15.06 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org There is a single IRQ handler for each LVTS thermal domain, and it is supposed to check each of its underlying controllers for the origin of the interrupt and clear its status. However due to a typo, only the first controller was ever being handled, which resulted in the interrupt never being cleared when it happened on the other controllers. Add the missing index so interrupts are handled for all controllers. Fixes: f5f633b18234 ("thermal/drivers/mediatek: Add the Low Voltage Thermal Sensor driver") Signed-off-by: Nícolas F. R. A. Prado Reviewed-by: Matthias Brugger Reviewed-by: AngeloGioacchino Del Regno --- drivers/thermal/mediatek/lvts_thermal.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/thermal/mediatek/lvts_thermal.c b/drivers/thermal/mediatek/lvts_thermal.c index d0a3f95b7884..56b24c5b645f 100644 --- a/drivers/thermal/mediatek/lvts_thermal.c +++ b/drivers/thermal/mediatek/lvts_thermal.c @@ -449,7 +449,7 @@ static irqreturn_t lvts_irq_handler(int irq, void *data) for (i = 0; i < lvts_td->num_lvts_ctrl; i++) { - aux = lvts_ctrl_irq_handler(lvts_td->lvts_ctrl); + aux = lvts_ctrl_irq_handler(&lvts_td->lvts_ctrl[i]); if (aux != IRQ_HANDLED) continue;