| Message ID | 20230516200341.553413-1-arnd@kernel.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | irq_work: consolidate arch_irq_work_raise prototypes | expand |
On Tue, 16 May 2023 13:02:31 PDT (-0700), arnd@kernel.org wrote: > From: Arnd Bergmann <arnd@arndb.de> > > The prototype was hidden on x86, which causes a warning: > > kernel/irq_work.c:72:13: error: no previous prototype for 'arch_irq_work_raise' [-Werror=missing-prototypes] > > Fix this by providing it in only one place that is always visible. > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > --- > arch/arm/include/asm/irq_work.h | 2 -- > arch/arm64/include/asm/irq_work.h | 2 -- > arch/csky/include/asm/irq_work.h | 2 +- > arch/powerpc/include/asm/irq_work.h | 1 - > arch/riscv/include/asm/irq_work.h | 2 +- Acked-by: Palmer Dabbelt <palmer@rivosinc.com> > arch/s390/include/asm/irq_work.h | 2 -- > arch/x86/include/asm/irq_work.h | 1 - > include/linux/irq_work.h | 3 +++ > 8 files changed, 5 insertions(+), 10 deletions(-) > > diff --git a/arch/arm/include/asm/irq_work.h b/arch/arm/include/asm/irq_work.h > index 3149e4dc1b54..8895999834cc 100644 > --- a/arch/arm/include/asm/irq_work.h > +++ b/arch/arm/include/asm/irq_work.h > @@ -9,6 +9,4 @@ static inline bool arch_irq_work_has_interrupt(void) > return is_smp(); > } > > -extern void arch_irq_work_raise(void); > - > #endif /* _ASM_ARM_IRQ_WORK_H */ > diff --git a/arch/arm64/include/asm/irq_work.h b/arch/arm64/include/asm/irq_work.h > index 81bbfa3a035b..a1020285ea75 100644 > --- a/arch/arm64/include/asm/irq_work.h > +++ b/arch/arm64/include/asm/irq_work.h > @@ -2,8 +2,6 @@ > #ifndef __ASM_IRQ_WORK_H > #define __ASM_IRQ_WORK_H > > -extern void arch_irq_work_raise(void); > - > static inline bool arch_irq_work_has_interrupt(void) > { > return true; > diff --git a/arch/csky/include/asm/irq_work.h b/arch/csky/include/asm/irq_work.h > index 33aaf39d6f94..d39fcc1f5395 100644 > --- a/arch/csky/include/asm/irq_work.h > +++ b/arch/csky/include/asm/irq_work.h > @@ -7,5 +7,5 @@ static inline bool arch_irq_work_has_interrupt(void) > { > return true; > } > -extern void arch_irq_work_raise(void); > + > #endif /* __ASM_CSKY_IRQ_WORK_H */ > diff --git a/arch/powerpc/include/asm/irq_work.h b/arch/powerpc/include/asm/irq_work.h > index b8b0be8f1a07..c6d3078bd8c3 100644 > --- a/arch/powerpc/include/asm/irq_work.h > +++ b/arch/powerpc/include/asm/irq_work.h > @@ -6,6 +6,5 @@ static inline bool arch_irq_work_has_interrupt(void) > { > return true; > } > -extern void arch_irq_work_raise(void); > > #endif /* _ASM_POWERPC_IRQ_WORK_H */ > diff --git a/arch/riscv/include/asm/irq_work.h b/arch/riscv/include/asm/irq_work.h > index b53891964ae0..b27a4d64fc6a 100644 > --- a/arch/riscv/include/asm/irq_work.h > +++ b/arch/riscv/include/asm/irq_work.h > @@ -6,5 +6,5 @@ static inline bool arch_irq_work_has_interrupt(void) > { > return IS_ENABLED(CONFIG_SMP); > } > -extern void arch_irq_work_raise(void); > + > #endif /* _ASM_RISCV_IRQ_WORK_H */ > diff --git a/arch/s390/include/asm/irq_work.h b/arch/s390/include/asm/irq_work.h > index 603783766d0a..f00c9f610d5a 100644 > --- a/arch/s390/include/asm/irq_work.h > +++ b/arch/s390/include/asm/irq_work.h > @@ -7,6 +7,4 @@ static inline bool arch_irq_work_has_interrupt(void) > return true; > } > > -void arch_irq_work_raise(void); > - > #endif /* _ASM_S390_IRQ_WORK_H */ > diff --git a/arch/x86/include/asm/irq_work.h b/arch/x86/include/asm/irq_work.h > index 800ffce0db29..6b4d36c95165 100644 > --- a/arch/x86/include/asm/irq_work.h > +++ b/arch/x86/include/asm/irq_work.h > @@ -9,7 +9,6 @@ static inline bool arch_irq_work_has_interrupt(void) > { > return boot_cpu_has(X86_FEATURE_APIC); > } > -extern void arch_irq_work_raise(void); > #else > static inline bool arch_irq_work_has_interrupt(void) > { > diff --git a/include/linux/irq_work.h b/include/linux/irq_work.h > index 8cd11a223260..136f2980cba3 100644 > --- a/include/linux/irq_work.h > +++ b/include/linux/irq_work.h > @@ -66,6 +66,9 @@ void irq_work_sync(struct irq_work *work); > void irq_work_run(void); > bool irq_work_needs_cpu(void); > void irq_work_single(void *arg); > + > +void arch_irq_work_raise(void); > + > #else > static inline bool irq_work_needs_cpu(void) { return false; } > static inline void irq_work_run(void) { }
On Tue, May 16, 2023 at 10:02:31PM +0200, Arnd Bergmann wrote: > From: Arnd Bergmann <arnd@arndb.de> > > The prototype was hidden on x86, which causes a warning: > > kernel/irq_work.c:72:13: error: no previous prototype for 'arch_irq_work_raise' [-Werror=missing-prototypes] > > Fix this by providing it in only one place that is always visible. > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > --- > arch/arm/include/asm/irq_work.h | 2 -- > arch/arm64/include/asm/irq_work.h | 2 -- > arch/csky/include/asm/irq_work.h | 2 +- > arch/powerpc/include/asm/irq_work.h | 1 - > arch/riscv/include/asm/irq_work.h | 2 +- > arch/s390/include/asm/irq_work.h | 2 -- > arch/x86/include/asm/irq_work.h | 1 - > include/linux/irq_work.h | 3 +++ > 8 files changed, 5 insertions(+), 10 deletions(-) ... > diff --git a/arch/s390/include/asm/irq_work.h b/arch/s390/include/asm/irq_work.h > index 603783766d0a..f00c9f610d5a 100644 > --- a/arch/s390/include/asm/irq_work.h > +++ b/arch/s390/include/asm/irq_work.h > @@ -7,6 +7,4 @@ static inline bool arch_irq_work_has_interrupt(void) > return true; > } > > -void arch_irq_work_raise(void); > - > #endif /* _ASM_S390_IRQ_WORK_H */ ... > diff --git a/include/linux/irq_work.h b/include/linux/irq_work.h > index 8cd11a223260..136f2980cba3 100644 > --- a/include/linux/irq_work.h > +++ b/include/linux/irq_work.h > @@ -66,6 +66,9 @@ void irq_work_sync(struct irq_work *work); > void irq_work_run(void); > bool irq_work_needs_cpu(void); > void irq_work_single(void *arg); > + > +void arch_irq_work_raise(void); > + > #else > static inline bool irq_work_needs_cpu(void) { return false; } > static inline void irq_work_run(void) { } For s390: Reviewed-by: Alexander Gordeev <agordeev@linux.ibm.com>
On Wed, May 17, 2023 at 4:03 AM Arnd Bergmann <arnd@kernel.org> wrote: > > From: Arnd Bergmann <arnd@arndb.de> > > The prototype was hidden on x86, which causes a warning: > > kernel/irq_work.c:72:13: error: no previous prototype for 'arch_irq_work_raise' [-Werror=missing-prototypes] > > Fix this by providing it in only one place that is always visible. > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > --- > arch/arm/include/asm/irq_work.h | 2 -- > arch/arm64/include/asm/irq_work.h | 2 -- > arch/csky/include/asm/irq_work.h | 2 +- > arch/powerpc/include/asm/irq_work.h | 1 - > arch/riscv/include/asm/irq_work.h | 2 +- > arch/s390/include/asm/irq_work.h | 2 -- > arch/x86/include/asm/irq_work.h | 1 - > include/linux/irq_work.h | 3 +++ > 8 files changed, 5 insertions(+), 10 deletions(-) > > diff --git a/arch/arm/include/asm/irq_work.h b/arch/arm/include/asm/irq_work.h > index 3149e4dc1b54..8895999834cc 100644 > --- a/arch/arm/include/asm/irq_work.h > +++ b/arch/arm/include/asm/irq_work.h > @@ -9,6 +9,4 @@ static inline bool arch_irq_work_has_interrupt(void) > return is_smp(); > } > > -extern void arch_irq_work_raise(void); > - > #endif /* _ASM_ARM_IRQ_WORK_H */ > diff --git a/arch/arm64/include/asm/irq_work.h b/arch/arm64/include/asm/irq_work.h > index 81bbfa3a035b..a1020285ea75 100644 > --- a/arch/arm64/include/asm/irq_work.h > +++ b/arch/arm64/include/asm/irq_work.h > @@ -2,8 +2,6 @@ > #ifndef __ASM_IRQ_WORK_H > #define __ASM_IRQ_WORK_H > > -extern void arch_irq_work_raise(void); > - > static inline bool arch_irq_work_has_interrupt(void) > { > return true; > diff --git a/arch/csky/include/asm/irq_work.h b/arch/csky/include/asm/irq_work.h > index 33aaf39d6f94..d39fcc1f5395 100644 > --- a/arch/csky/include/asm/irq_work.h > +++ b/arch/csky/include/asm/irq_work.h > @@ -7,5 +7,5 @@ static inline bool arch_irq_work_has_interrupt(void) > { > return true; > } > -extern void arch_irq_work_raise(void); > + Acked-by: Guo Ren <guoren@kernel.org> > #endif /* __ASM_CSKY_IRQ_WORK_H */ > diff --git a/arch/powerpc/include/asm/irq_work.h b/arch/powerpc/include/asm/irq_work.h > index b8b0be8f1a07..c6d3078bd8c3 100644 > --- a/arch/powerpc/include/asm/irq_work.h > +++ b/arch/powerpc/include/asm/irq_work.h > @@ -6,6 +6,5 @@ static inline bool arch_irq_work_has_interrupt(void) > { > return true; > } > -extern void arch_irq_work_raise(void); > > #endif /* _ASM_POWERPC_IRQ_WORK_H */ > diff --git a/arch/riscv/include/asm/irq_work.h b/arch/riscv/include/asm/irq_work.h > index b53891964ae0..b27a4d64fc6a 100644 > --- a/arch/riscv/include/asm/irq_work.h > +++ b/arch/riscv/include/asm/irq_work.h > @@ -6,5 +6,5 @@ static inline bool arch_irq_work_has_interrupt(void) > { > return IS_ENABLED(CONFIG_SMP); > } > -extern void arch_irq_work_raise(void); > + > #endif /* _ASM_RISCV_IRQ_WORK_H */ > diff --git a/arch/s390/include/asm/irq_work.h b/arch/s390/include/asm/irq_work.h > index 603783766d0a..f00c9f610d5a 100644 > --- a/arch/s390/include/asm/irq_work.h > +++ b/arch/s390/include/asm/irq_work.h > @@ -7,6 +7,4 @@ static inline bool arch_irq_work_has_interrupt(void) > return true; > } > > -void arch_irq_work_raise(void); > - > #endif /* _ASM_S390_IRQ_WORK_H */ > diff --git a/arch/x86/include/asm/irq_work.h b/arch/x86/include/asm/irq_work.h > index 800ffce0db29..6b4d36c95165 100644 > --- a/arch/x86/include/asm/irq_work.h > +++ b/arch/x86/include/asm/irq_work.h > @@ -9,7 +9,6 @@ static inline bool arch_irq_work_has_interrupt(void) > { > return boot_cpu_has(X86_FEATURE_APIC); > } > -extern void arch_irq_work_raise(void); > #else > static inline bool arch_irq_work_has_interrupt(void) > { > diff --git a/include/linux/irq_work.h b/include/linux/irq_work.h > index 8cd11a223260..136f2980cba3 100644 > --- a/include/linux/irq_work.h > +++ b/include/linux/irq_work.h > @@ -66,6 +66,9 @@ void irq_work_sync(struct irq_work *work); > void irq_work_run(void); > bool irq_work_needs_cpu(void); > void irq_work_single(void *arg); > + > +void arch_irq_work_raise(void); > + > #else > static inline bool irq_work_needs_cpu(void) { return false; } > static inline void irq_work_run(void) { } > -- > 2.39.2 >
On Tue, May 16, 2023 at 10:02:31PM +0200, Arnd Bergmann wrote: > From: Arnd Bergmann <arnd@arndb.de> > > The prototype was hidden on x86, which causes a warning: > > kernel/irq_work.c:72:13: error: no previous prototype for 'arch_irq_work_raise' [-Werror=missing-prototypes] > > Fix this by providing it in only one place that is always visible. > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> Acked-by: Catalin Marinas <catalin.marinas@arm.com>
diff --git a/arch/arm/include/asm/irq_work.h b/arch/arm/include/asm/irq_work.h index 3149e4dc1b54..8895999834cc 100644 --- a/arch/arm/include/asm/irq_work.h +++ b/arch/arm/include/asm/irq_work.h @@ -9,6 +9,4 @@ static inline bool arch_irq_work_has_interrupt(void) return is_smp(); } -extern void arch_irq_work_raise(void); - #endif /* _ASM_ARM_IRQ_WORK_H */ diff --git a/arch/arm64/include/asm/irq_work.h b/arch/arm64/include/asm/irq_work.h index 81bbfa3a035b..a1020285ea75 100644 --- a/arch/arm64/include/asm/irq_work.h +++ b/arch/arm64/include/asm/irq_work.h @@ -2,8 +2,6 @@ #ifndef __ASM_IRQ_WORK_H #define __ASM_IRQ_WORK_H -extern void arch_irq_work_raise(void); - static inline bool arch_irq_work_has_interrupt(void) { return true; diff --git a/arch/csky/include/asm/irq_work.h b/arch/csky/include/asm/irq_work.h index 33aaf39d6f94..d39fcc1f5395 100644 --- a/arch/csky/include/asm/irq_work.h +++ b/arch/csky/include/asm/irq_work.h @@ -7,5 +7,5 @@ static inline bool arch_irq_work_has_interrupt(void) { return true; } -extern void arch_irq_work_raise(void); + #endif /* __ASM_CSKY_IRQ_WORK_H */ diff --git a/arch/powerpc/include/asm/irq_work.h b/arch/powerpc/include/asm/irq_work.h index b8b0be8f1a07..c6d3078bd8c3 100644 --- a/arch/powerpc/include/asm/irq_work.h +++ b/arch/powerpc/include/asm/irq_work.h @@ -6,6 +6,5 @@ static inline bool arch_irq_work_has_interrupt(void) { return true; } -extern void arch_irq_work_raise(void); #endif /* _ASM_POWERPC_IRQ_WORK_H */ diff --git a/arch/riscv/include/asm/irq_work.h b/arch/riscv/include/asm/irq_work.h index b53891964ae0..b27a4d64fc6a 100644 --- a/arch/riscv/include/asm/irq_work.h +++ b/arch/riscv/include/asm/irq_work.h @@ -6,5 +6,5 @@ static inline bool arch_irq_work_has_interrupt(void) { return IS_ENABLED(CONFIG_SMP); } -extern void arch_irq_work_raise(void); + #endif /* _ASM_RISCV_IRQ_WORK_H */ diff --git a/arch/s390/include/asm/irq_work.h b/arch/s390/include/asm/irq_work.h index 603783766d0a..f00c9f610d5a 100644 --- a/arch/s390/include/asm/irq_work.h +++ b/arch/s390/include/asm/irq_work.h @@ -7,6 +7,4 @@ static inline bool arch_irq_work_has_interrupt(void) return true; } -void arch_irq_work_raise(void); - #endif /* _ASM_S390_IRQ_WORK_H */ diff --git a/arch/x86/include/asm/irq_work.h b/arch/x86/include/asm/irq_work.h index 800ffce0db29..6b4d36c95165 100644 --- a/arch/x86/include/asm/irq_work.h +++ b/arch/x86/include/asm/irq_work.h @@ -9,7 +9,6 @@ static inline bool arch_irq_work_has_interrupt(void) { return boot_cpu_has(X86_FEATURE_APIC); } -extern void arch_irq_work_raise(void); #else static inline bool arch_irq_work_has_interrupt(void) { diff --git a/include/linux/irq_work.h b/include/linux/irq_work.h index 8cd11a223260..136f2980cba3 100644 --- a/include/linux/irq_work.h +++ b/include/linux/irq_work.h @@ -66,6 +66,9 @@ void irq_work_sync(struct irq_work *work); void irq_work_run(void); bool irq_work_needs_cpu(void); void irq_work_single(void *arg); + +void arch_irq_work_raise(void); + #else static inline bool irq_work_needs_cpu(void) { return false; } static inline void irq_work_run(void) { }