| Message ID | 20230523165411.1136102-4-vladimir.zapolskiy@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | arm64: defconfig: build some essential Qualcomm platform drivers | expand |
On 23.05.2023 18:54, Vladimir Zapolskiy wrote: > Build Qualcomm QCM2290 interconnect driver. > > Signed-off-by: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org> > --- Do we know why some are =y and some are =m? I'm for =y either way, if we can. Konrad > arch/arm64/configs/defconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig > index e2f6a352a0ad..ec9b828b14e2 100644 > --- a/arch/arm64/configs/defconfig > +++ b/arch/arm64/configs/defconfig > @@ -1415,6 +1415,7 @@ CONFIG_INTERCONNECT_QCOM=y > CONFIG_INTERCONNECT_QCOM_MSM8916=m > CONFIG_INTERCONNECT_QCOM_MSM8996=m > CONFIG_INTERCONNECT_QCOM_OSM_L3=m > +CONFIG_INTERCONNECT_QCOM_QCM2290=y > CONFIG_INTERCONNECT_QCOM_QCS404=m > CONFIG_INTERCONNECT_QCOM_SA8775P=y > CONFIG_INTERCONNECT_QCOM_SC7180=y
On 23/05/2023 20:30, Konrad Dybcio wrote: > > > On 23.05.2023 18:54, Vladimir Zapolskiy wrote: >> Build Qualcomm QCM2290 interconnect driver. >> >> Signed-off-by: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org> >> --- > Do we know why some are =y and some are =m? > > I'm for =y either way, if we can. I think this might change from platform to platform. What is the condition for selecting 'y' or 'm' for the core drivers? Is it 'should boot to rootfs without modules' or 'should boot to UART and load initrd without modules' ? > > Konrad >> arch/arm64/configs/defconfig | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig >> index e2f6a352a0ad..ec9b828b14e2 100644 >> --- a/arch/arm64/configs/defconfig >> +++ b/arch/arm64/configs/defconfig >> @@ -1415,6 +1415,7 @@ CONFIG_INTERCONNECT_QCOM=y >> CONFIG_INTERCONNECT_QCOM_MSM8916=m >> CONFIG_INTERCONNECT_QCOM_MSM8996=m >> CONFIG_INTERCONNECT_QCOM_OSM_L3=m >> +CONFIG_INTERCONNECT_QCOM_QCM2290=y >> CONFIG_INTERCONNECT_QCOM_QCS404=m >> CONFIG_INTERCONNECT_QCOM_SA8775P=y >> CONFIG_INTERCONNECT_QCOM_SC7180=y
On Tue, May 23, 2023, at 23:11, Dmitry Baryshkov wrote: > On 23/05/2023 20:30, Konrad Dybcio wrote: >> >> >> On 23.05.2023 18:54, Vladimir Zapolskiy wrote: >>> Build Qualcomm QCM2290 interconnect driver. >>> >>> Signed-off-by: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org> >>> --- >> Do we know why some are =y and some are =m? >> >> I'm for =y either way, if we can. > > I think this might change from platform to platform. What is the > condition for selecting 'y' or 'm' for the core drivers? Is it 'should > boot to rootfs without modules' or 'should boot to UART and load initrd > without modules' ? I think we are a bit inconsistent here. I'm generally fine taking changes that are required to boot into rootfs without initramfs, but would like everything else to be loadable modules. Android tends to want everything as modules and require an initramfs for loading them, so I think platforms that are mostly Android specific lean towards that even for core drivers. Arnd
On Wed, May 24, 2023 at 08:36:20AM +0200, Arnd Bergmann wrote: > On Tue, May 23, 2023, at 23:11, Dmitry Baryshkov wrote: > > On 23/05/2023 20:30, Konrad Dybcio wrote: > >> > >> > >> On 23.05.2023 18:54, Vladimir Zapolskiy wrote: > >>> Build Qualcomm QCM2290 interconnect driver. > >>> > >>> Signed-off-by: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org> > >>> --- > >> Do we know why some are =y and some are =m? > >> > >> I'm for =y either way, if we can. > > > > I think this might change from platform to platform. What is the > > condition for selecting 'y' or 'm' for the core drivers? Is it 'should > > boot to rootfs without modules' or 'should boot to UART and load initrd > > without modules' ? > > I think we are a bit inconsistent here. I'm generally fine taking > changes that are required to boot into rootfs without initramfs, > but would like everything else to be loadable modules. > > Android tends to want everything as modules and require an initramfs > for loading them, so I think platforms that are mostly Android > specific lean towards that even for core drivers. > I (any many other in the Qcom community) do most of my (our) testing and development using a ramdisk-only approach and if systemd isn't provided a valid /dev/console at launch, things doesn't work as expected... So the inconsistency here relates to the fact that not all platforms has the UART defined to depend on interconnect, once this is populated in DT, we tend to be forced to move them to =y, together with GCC and pinctrl-msm. Looking to storage etc on a modern Qualcomm platform, the dependency tree is growing quite a bit (regulators, genpd providers etc), and we have UFS, SDHCI and NVME to support. So I think it's reasonable to have the generic defconfig require that you use a initramfs to get further (on the Qualcomm platforms). Regards, Bjorn
On Tue, May 23, 2023 at 07:54:09PM +0300, Vladimir Zapolskiy wrote: > Build Qualcomm QCM2290 interconnect driver. In line with the questions that followed, and previous requests. Please document why this should be =y. Regards, Bjorn > > Signed-off-by: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org> > --- > arch/arm64/configs/defconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig > index e2f6a352a0ad..ec9b828b14e2 100644 > --- a/arch/arm64/configs/defconfig > +++ b/arch/arm64/configs/defconfig > @@ -1415,6 +1415,7 @@ CONFIG_INTERCONNECT_QCOM=y > CONFIG_INTERCONNECT_QCOM_MSM8916=m > CONFIG_INTERCONNECT_QCOM_MSM8996=m > CONFIG_INTERCONNECT_QCOM_OSM_L3=m > +CONFIG_INTERCONNECT_QCOM_QCM2290=y > CONFIG_INTERCONNECT_QCOM_QCS404=m > CONFIG_INTERCONNECT_QCOM_SA8775P=y > CONFIG_INTERCONNECT_QCOM_SC7180=y > -- > 2.33.0 >
diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig index e2f6a352a0ad..ec9b828b14e2 100644 --- a/arch/arm64/configs/defconfig +++ b/arch/arm64/configs/defconfig @@ -1415,6 +1415,7 @@ CONFIG_INTERCONNECT_QCOM=y CONFIG_INTERCONNECT_QCOM_MSM8916=m CONFIG_INTERCONNECT_QCOM_MSM8996=m CONFIG_INTERCONNECT_QCOM_OSM_L3=m +CONFIG_INTERCONNECT_QCOM_QCM2290=y CONFIG_INTERCONNECT_QCOM_QCS404=m CONFIG_INTERCONNECT_QCOM_SA8775P=y CONFIG_INTERCONNECT_QCOM_SC7180=y
Build Qualcomm QCM2290 interconnect driver. Signed-off-by: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org> --- arch/arm64/configs/defconfig | 1 + 1 file changed, 1 insertion(+)