| Message ID | 20230527195005.398815-3-festevam@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/3] dt-bindings: pfuze100.yaml: Add an entry for interrupts | expand |
Hey Fabio, On Sat, May 27, 2023 at 04:50:05PM -0300, Fabio Estevam wrote: > From: Fabio Estevam <festevam@denx.de> > > There is no "vcoin" supply output provided by the PFUZE100 PMIC. > > Remove it to fix the following DT check warning: > > imx6ul-ccimx6ulsbcexpress.dtb: pmic@8: regulators: 'vcoin' does not match any of the regexes: Dumb question, did you spot this only because of dtbs_check, or is this something you know to be true? I had the datasheet open to check the interrupt thing, so I figured I may as well look for coin cell chargers too. Seemly there is a "licell" pin that is an input/output. Is this what the vcoin_chg was referring to, or is that something else entirely? I know nothing about the hardware at all, so was just something that piqued my curiosity. Thanks, Conor. > > Signed-off-by: Fabio Estevam <festevam@denx.de> > --- > arch/arm/boot/dts/imx6ul-ccimx6ulsom.dtsi | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/arch/arm/boot/dts/imx6ul-ccimx6ulsom.dtsi b/arch/arm/boot/dts/imx6ul-ccimx6ulsom.dtsi > index b5781c3656d1..fe82f0b6bbda 100644 > --- a/arch/arm/boot/dts/imx6ul-ccimx6ulsom.dtsi > +++ b/arch/arm/boot/dts/imx6ul-ccimx6ulsom.dtsi > @@ -157,11 +157,6 @@ ldo4_ext: vldo4 { > regulator-min-microvolt = <1800000>; > regulator-max-microvolt = <3300000>; > }; > - > - vcoin_chg: vcoin { > - regulator-min-microvolt = <2500000>; > - regulator-max-microvolt = <3300000>; > - }; > }; > }; > }; > -- > 2.34.1 >
Hi Conor, On Sat, May 27, 2023 at 5:12 PM Conor Dooley <conor@kernel.org> wrote: > Dumb question, did you spot this only because of dtbs_check, or is this > something you know to be true? > I had the datasheet open to check the interrupt thing, so I figured I > may as well look for coin cell chargers too. > Seemly there is a "licell" pin that is an input/output. Is this what the > vcoin_chg was referring to, or is that something else entirely? > > I know nothing about the hardware at all, so was just something that > piqued my curiosity. Thanks for your review. I have double-checked it and the correct fix is to change it from "vcoin" to "coin". I will send a v2 soon. Thanks
diff --git a/arch/arm/boot/dts/imx6ul-ccimx6ulsom.dtsi b/arch/arm/boot/dts/imx6ul-ccimx6ulsom.dtsi index b5781c3656d1..fe82f0b6bbda 100644 --- a/arch/arm/boot/dts/imx6ul-ccimx6ulsom.dtsi +++ b/arch/arm/boot/dts/imx6ul-ccimx6ulsom.dtsi @@ -157,11 +157,6 @@ ldo4_ext: vldo4 { regulator-min-microvolt = <1800000>; regulator-max-microvolt = <3300000>; }; - - vcoin_chg: vcoin { - regulator-min-microvolt = <2500000>; - regulator-max-microvolt = <3300000>; - }; }; }; };