| Message ID | 20230531104625.18296-4-hejunhao3@huawei.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Add support for HiSilicon SoC uncore PMU | expand |
On Wed, 31 May 2023 18:46:25 +0800 Junhao He <hejunhao3@huawei.com> wrote: > A new function is added on HiSilicon uncore UC PMU. > > The UC PMU support to filter statistical information based on > the specified tx request uring channel. Make user configuration > through "uring_channel" parameter. > Document them to provide guidance on how to use them. > > Signed-off-by: Junhao He <hejunhao3@huawei.com> Seems reasonable to me. Reviewed-by: Jonathan Cameron <Jonthan.Cameron@huawei.com> > --- > Documentation/admin-guide/perf/hisi-pmu.rst | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/Documentation/admin-guide/perf/hisi-pmu.rst b/Documentation/admin-guide/perf/hisi-pmu.rst > index 546979360513..939a524fa1d6 100644 > --- a/Documentation/admin-guide/perf/hisi-pmu.rst > +++ b/Documentation/admin-guide/perf/hisi-pmu.rst > @@ -98,6 +98,14 @@ CCL/ICL-ID. For I/O die, the ICL-ID is followed by: > 5'b00011: HAC_ICL; > 5'b10000: PCIe_ICL; > > +(e) uring_channel: UC PMU events 0x47~0x59 supports filtering by tx request > +uring channel. It is 2 bits. Some important codes are as follows: > +2'b11: count the events which sent to the uring_ext (MATA) channel; > +2'b01: is the same as 2'b11; > +2'b10: count the events which sent to the uring (non-MATA) channel; > +2'b00: default value, count the events which sent to the both uring and > + uring_ext channel; > + > Users could configure IDs to count data come from specific CCL/ICL, by setting > srcid_cmd & srcid_msk, and data desitined for specific CCL/ICL by setting > tgtid_cmd & tgtid_msk. A set bit in srcid_msk/tgtid_msk means the PMU will not
On 2023/5/31 18:46, Junhao He wrote: > A new function is added on HiSilicon uncore UC PMU. > > The UC PMU support to filter statistical information based on > the specified tx request uring channel. Make user configuration > through "uring_channel" parameter. > Document them to provide guidance on how to use them. > > Signed-off-by: Junhao He <hejunhao3@huawei.com> I still prefer this in the same patch with the driver support, anyway the docs alone looks good to me. Reviewed-by: Yicong Yang <yangyicong@hisilicon.com> > --- > Documentation/admin-guide/perf/hisi-pmu.rst | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/Documentation/admin-guide/perf/hisi-pmu.rst b/Documentation/admin-guide/perf/hisi-pmu.rst > index 546979360513..939a524fa1d6 100644 > --- a/Documentation/admin-guide/perf/hisi-pmu.rst > +++ b/Documentation/admin-guide/perf/hisi-pmu.rst > @@ -98,6 +98,14 @@ CCL/ICL-ID. For I/O die, the ICL-ID is followed by: > 5'b00011: HAC_ICL; > 5'b10000: PCIe_ICL; > > +(e) uring_channel: UC PMU events 0x47~0x59 supports filtering by tx request > +uring channel. It is 2 bits. Some important codes are as follows: > +2'b11: count the events which sent to the uring_ext (MATA) channel; > +2'b01: is the same as 2'b11; > +2'b10: count the events which sent to the uring (non-MATA) channel; > +2'b00: default value, count the events which sent to the both uring and > + uring_ext channel; > + > Users could configure IDs to count data come from specific CCL/ICL, by setting > srcid_cmd & srcid_msk, and data desitined for specific CCL/ICL by setting > tgtid_cmd & tgtid_msk. A set bit in srcid_msk/tgtid_msk means the PMU will not >
diff --git a/Documentation/admin-guide/perf/hisi-pmu.rst b/Documentation/admin-guide/perf/hisi-pmu.rst index 546979360513..939a524fa1d6 100644 --- a/Documentation/admin-guide/perf/hisi-pmu.rst +++ b/Documentation/admin-guide/perf/hisi-pmu.rst @@ -98,6 +98,14 @@ CCL/ICL-ID. For I/O die, the ICL-ID is followed by: 5'b00011: HAC_ICL; 5'b10000: PCIe_ICL; +(e) uring_channel: UC PMU events 0x47~0x59 supports filtering by tx request +uring channel. It is 2 bits. Some important codes are as follows: +2'b11: count the events which sent to the uring_ext (MATA) channel; +2'b01: is the same as 2'b11; +2'b10: count the events which sent to the uring (non-MATA) channel; +2'b00: default value, count the events which sent to the both uring and + uring_ext channel; + Users could configure IDs to count data come from specific CCL/ICL, by setting srcid_cmd & srcid_msk, and data desitined for specific CCL/ICL by setting tgtid_cmd & tgtid_msk. A set bit in srcid_msk/tgtid_msk means the PMU will not
A new function is added on HiSilicon uncore UC PMU. The UC PMU support to filter statistical information based on the specified tx request uring channel. Make user configuration through "uring_channel" parameter. Document them to provide guidance on how to use them. Signed-off-by: Junhao He <hejunhao3@huawei.com> --- Documentation/admin-guide/perf/hisi-pmu.rst | 8 ++++++++ 1 file changed, 8 insertions(+)