| Message ID | 20230605062217.3716328-2-victor.liu@nxp.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/bridge: imx: Add i.MX93 parallel display format configuration support | expand |
On Mon, Jun 05, 2023 at 02:22:16PM +0800, Liu Ying wrote: > i.MX93 SoC mediamix blk-ctrl contains one DISPLAY_MUX register which > configures parallel display format by using the "PARALLEL_DISP_FORMAT" > field. Document the Parallel Display Format Configuration(PDFC) subnode > and add the subnode to example. The previous issues seem to be resolved & what you've got here looks fine to me. Perhaps Krzysztof will disagree! Reviewed-by: Conor Dooley <conor.dooley@microchip.com> Cheers, Conor. > > Signed-off-by: Liu Ying <victor.liu@nxp.com> > --- > v2->v3: > * Newly introduced to replace the standalone dt-binding in v1 and v2. (Rob) > > .../soc/imx/fsl,imx93-media-blk-ctrl.yaml | 68 +++++++++++++++++++ > 1 file changed, 68 insertions(+) > > diff --git a/Documentation/devicetree/bindings/soc/imx/fsl,imx93-media-blk-ctrl.yaml b/Documentation/devicetree/bindings/soc/imx/fsl,imx93-media-blk-ctrl.yaml > index b3554e7f9e76..3f550c30d93d 100644 > --- a/Documentation/devicetree/bindings/soc/imx/fsl,imx93-media-blk-ctrl.yaml > +++ b/Documentation/devicetree/bindings/soc/imx/fsl,imx93-media-blk-ctrl.yaml > @@ -24,6 +24,12 @@ properties: > reg: > maxItems: 1 > > + '#address-cells': > + const: 1 > + > + '#size-cells': > + const: 1 > + > '#power-domain-cells': > const: 1 > > @@ -46,9 +52,43 @@ properties: > - const: csi > - const: dsi > > + bridge@60: > + type: object > + additionalProperties: false > + > + properties: > + compatible: > + const: nxp,imx93-pdfc > + > + reg: > + maxItems: 1 > + > + ports: > + $ref: /schemas/graph.yaml#/properties/ports > + > + properties: > + port@0: > + $ref: /schemas/graph.yaml#/properties/port > + description: Input port node to receive pixel data. > + > + port@1: > + $ref: /schemas/graph.yaml#/properties/port > + description: Output port node to downstream pixel data receivers. > + > + required: > + - port@0 > + - port@1 > + > + required: > + - compatible > + - reg > + - ports > + > required: > - compatible > - reg > + - '#address-cells' > + - '#size-cells' > - power-domains > - clocks > - clock-names > @@ -76,5 +116,33 @@ examples: > <&clk IMX93_CLK_MIPI_DSI_GATE>; > clock-names = "apb", "axi", "nic", "disp", "cam", > "pxp", "lcdif", "isi", "csi", "dsi"; > + #address-cells = <1>; > + #size-cells = <1>; > #power-domain-cells = <1>; > + > + bridge@60 { > + compatible = "nxp,imx93-pdfc"; > + reg = <0x60 0x4>; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@0 { > + reg = <0>; > + > + pdfc_from_lcdif: endpoint { > + remote-endpoint = <&lcdif_to_pdfc>; > + }; > + }; > + > + port@1 { > + reg = <1>; > + > + pdfc_to_panel: endpoint { > + remote-endpoint = <&panel_from_pdfc>; > + }; > + }; > + }; > + }; > }; > -- > 2.37.1 >
diff --git a/Documentation/devicetree/bindings/soc/imx/fsl,imx93-media-blk-ctrl.yaml b/Documentation/devicetree/bindings/soc/imx/fsl,imx93-media-blk-ctrl.yaml index b3554e7f9e76..3f550c30d93d 100644 --- a/Documentation/devicetree/bindings/soc/imx/fsl,imx93-media-blk-ctrl.yaml +++ b/Documentation/devicetree/bindings/soc/imx/fsl,imx93-media-blk-ctrl.yaml @@ -24,6 +24,12 @@ properties: reg: maxItems: 1 + '#address-cells': + const: 1 + + '#size-cells': + const: 1 + '#power-domain-cells': const: 1 @@ -46,9 +52,43 @@ properties: - const: csi - const: dsi + bridge@60: + type: object + additionalProperties: false + + properties: + compatible: + const: nxp,imx93-pdfc + + reg: + maxItems: 1 + + ports: + $ref: /schemas/graph.yaml#/properties/ports + + properties: + port@0: + $ref: /schemas/graph.yaml#/properties/port + description: Input port node to receive pixel data. + + port@1: + $ref: /schemas/graph.yaml#/properties/port + description: Output port node to downstream pixel data receivers. + + required: + - port@0 + - port@1 + + required: + - compatible + - reg + - ports + required: - compatible - reg + - '#address-cells' + - '#size-cells' - power-domains - clocks - clock-names @@ -76,5 +116,33 @@ examples: <&clk IMX93_CLK_MIPI_DSI_GATE>; clock-names = "apb", "axi", "nic", "disp", "cam", "pxp", "lcdif", "isi", "csi", "dsi"; + #address-cells = <1>; + #size-cells = <1>; #power-domain-cells = <1>; + + bridge@60 { + compatible = "nxp,imx93-pdfc"; + reg = <0x60 0x4>; + + ports { + #address-cells = <1>; + #size-cells = <0>; + + port@0 { + reg = <0>; + + pdfc_from_lcdif: endpoint { + remote-endpoint = <&lcdif_to_pdfc>; + }; + }; + + port@1 { + reg = <1>; + + pdfc_to_panel: endpoint { + remote-endpoint = <&panel_from_pdfc>; + }; + }; + }; + }; };
i.MX93 SoC mediamix blk-ctrl contains one DISPLAY_MUX register which configures parallel display format by using the "PARALLEL_DISP_FORMAT" field. Document the Parallel Display Format Configuration(PDFC) subnode and add the subnode to example. Signed-off-by: Liu Ying <victor.liu@nxp.com> --- v2->v3: * Newly introduced to replace the standalone dt-binding in v1 and v2. (Rob) .../soc/imx/fsl,imx93-media-blk-ctrl.yaml | 68 +++++++++++++++++++ 1 file changed, 68 insertions(+)