From patchwork Mon Jun 19 16:52:19 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jisheng Zhang X-Patchwork-Id: 13284851 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 666E4EB64DA for ; Mon, 19 Jun 2023 17:04:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Q85HSVSzRjNbqH0fNmLkF6Mnbo+P9QDwlZSCrvQC4mY=; b=gA8B+WY1S+fNdK NQ4lZcplLM86OxP1kk4ysztxK1CUF+nxvMHBQaL3XJ5ljzh+SKbqILC9mLxwDA6IIcYovvOoCsr7b Te2n86g1oRyL2w0gwkJveg4Ph30CqXyEhyCkbdG8V8rTdBkZbKf/9YwYdT0PYRSjwwKPbBac6DzjF 9fjza2otmvciuLhfz1vxCw0YMQlj5XlVw94O5TNuZHHIa/Rzf84GXiC07j8tQSvuejFRYbnvHxIFl 9L2Cb6ePNkbjsLugKTe49zRaMGVpS52L4uZ0Y/QRCpgRmRhhgpFqdkevpdaXF4vGCBlIU0Eg3j5gu Ck+vTjU6q5HctWq9/KvA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qBIIF-0092Ic-1p; Mon, 19 Jun 2023 17:03:55 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qBIIA-0092Gp-0U for linux-arm-kernel@lists.infradead.org; Mon, 19 Jun 2023 17:03:51 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id B59A860E74; Mon, 19 Jun 2023 17:03:49 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 19E0CC433CA; Mon, 19 Jun 2023 17:03:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1687194229; bh=kJMjOEWBubOW9yDcj4y+c7DM6eBhC1GM5K1t94VIlM0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=MZgVSa7DmSzA23REOyCumO6xcP5Egtb2oN4i51WmfDWg9jMil2nIDr5BY4xjc0cqF ltXokjrS+yaCpDXsilDiUn2W1wZa+qq0Q8n3N6NQXSZEs3y7mpd46R1NqA9gtVYd6T e1Zd32k3Qytg5DMVli31N7CFgtVsde+O4ZXNTncboXht36eei1wXPV9h1Wxd4110W/ dc974OJsoxUmJYVbDZdkh7JD5nKw8SsB7PN0VNfPA3pCEyZ4BF0qeD7wyspbd6+1k7 Iz1myfVJRHLqaxtpSoC8u6FThqazRsB0IGQ5gAHRBzPq9uAfdlg+HXlEwdgW9vpEyg 9da33KtsSLZqw== From: Jisheng Zhang To: Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Coquelin , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland Cc: netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sunxi@lists.linux.dev, Simon Horman Subject: [PATCH net-next v3 1/2] net: stmmac: don't clear network statistics in .ndo_open() Date: Tue, 20 Jun 2023 00:52:19 +0800 Message-Id: <20230619165220.2501-2-jszhang@kernel.org> X-Mailer: git-send-email 2.40.0 In-Reply-To: <20230619165220.2501-1-jszhang@kernel.org> References: <20230619165220.2501-1-jszhang@kernel.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230619_100350_228133_D3161060 X-CRM114-Status: GOOD ( 11.31 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org FWICT, the common style in other network drivers: the network statistics are not cleared since initialization, follow the common style for stmmac. Signed-off-by: Jisheng Zhang --- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c index 5c645b6d5660..eb83396d6971 100644 --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c @@ -3827,10 +3827,6 @@ static int __stmmac_open(struct net_device *dev, } } - /* Extra statistics */ - memset(&priv->xstats, 0, sizeof(struct stmmac_extra_stats)); - priv->xstats.threshold = tc; - priv->rx_copybreak = STMMAC_RX_COPYBREAK; buf_sz = dma_conf->dma_buf_sz; @@ -7315,6 +7311,8 @@ int stmmac_dvr_probe(struct device *device, #endif priv->msg_enable = netif_msg_init(debug, default_msg_level); + priv->xstats.threshold = tc; + /* Initialize RSS */ rxq = priv->plat->rx_queues_to_use; netdev_rss_key_fill(priv->rss.key, sizeof(priv->rss.key));