From patchwork Fri Jun 23 14:40:57 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jim Quinlan X-Patchwork-Id: 13290769 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E1319EB64DD for ; Fri, 23 Jun 2023 14:42:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: MIME-Version:List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe :List-Id:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ZOLp3bk0jD6zKZ+wvSm0Nu3XfjTBYu9f4HMcaJGWmlU=; b=IaRRoOj3JcZWF6Kt3OnqraWKbX /go2aRLjApgJ/j4Ff9aA4/+ew6g8YFIiRIKaNcyaFU0ekQJnpiv8d7zMK6MHMf4twg2F1vK0dWF/2 MHQHiZGFZbnjs6Xp4cjEKV8uWtQPfm866YhOHcNuaiBIT7gcqayejVWI3bMv6cpfd/T0J65fftxMW xdaeXSjrh+Ui5Ptu+a1+KZ6jiOQI631ib3mjHEa66T20GFg/gJnFIR/tJMw50JRq5syvKqmkKlEb3 JUfgrPuo273iNZZL5iwg2D+eRVHL/a2ZdwKKIcc69hVdRMCpWqbSrxzQ5iuBN7WaOIe3ehDVfqgpl wo4g/tUA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qChyi-003oV4-13; Fri, 23 Jun 2023 14:41:36 +0000 Received: from mail-qk1-x72b.google.com ([2607:f8b0:4864:20::72b]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qChyN-003oJq-28 for linux-arm-kernel@lists.infradead.org; Fri, 23 Jun 2023 14:41:17 +0000 Received: by mail-qk1-x72b.google.com with SMTP id af79cd13be357-763ddc42589so59562985a.3 for ; Fri, 23 Jun 2023 07:41:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1687531272; x=1690123272; h=references:in-reply-to:message-id:date:subject:cc:to:from:from:to :cc:subject:date:message-id:reply-to; bh=mLOAdESKh3sTGS58SjkxpqoAsTbzH05ir4M6w20w/1M=; b=BGriy14B6AYNMtNbf5UTviEvbk/grxKMtlAuDWI147LC0LDK+T43BY6/P71ZWtATJd SgyYjSiTUzYGidNK0vNzQOzzpH7jyYuOpu8FAhJm7/6FgL88CY0xmYzpw1UgeNCLkiQN GsbLQvLjR1uEf8qv5tttqX0bm34U8plvzH3pA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687531272; x=1690123272; h=references:in-reply-to:message-id:date:subject:cc:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=mLOAdESKh3sTGS58SjkxpqoAsTbzH05ir4M6w20w/1M=; b=SWsk7h6XtDSYcjclG57yKMthTozWQXIGKYQjBvUHY+Yz79kiOVkCV59lfsRv6i7jDd 8jKMKw2ThAF1uooBBNRFBirJwTDKmWiYfgWNcghuuk74rd9RZmBIG294sD/Vxgc5DTdV bDTV2nzeHKFjhxO/2Uet8tp1xqOvZg5PS6p/+W+eki7GxokfwHS/i20i0BgLf49VE/z4 EY/YWhWHKzJj9msTwZj1MiWBodBdFwourd14JHFkK9NkEOAr17R2DoJXNeUO0RKRQMkc HMo5UjNnG5nF2F/oD0Z6ffXLgBosyWGwBZ6PGZwgLu0JCgAz4zd+S8pNoST8Xp+MrFz9 NQqA== X-Gm-Message-State: AC+VfDxcFpxB6ptCSbYDsYFUoJCjDU+F21+fuy5etehRgoDmMxJX/fPo 7wYhR2aeu5iP3pPdOxQBBQN2Ag== X-Google-Smtp-Source: ACHHUZ7YaKrVqQ8QnvGuhcY3JvOvengIIXyMeQqiinLnw5eZIkQ6quN3qI+0+AoueIHKsYdVThZWIw== X-Received: by 2002:a05:620a:2955:b0:763:a83c:a9e4 with SMTP id n21-20020a05620a295500b00763a83ca9e4mr18146840qkp.31.1687531272243; Fri, 23 Jun 2023 07:41:12 -0700 (PDT) Received: from stbsrv-and-01.and.broadcom.net ([192.19.144.250]) by smtp.gmail.com with ESMTPSA id i18-20020a05620a145200b007625382f4ccsm4564613qkl.69.2023.06.23.07.41.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Jun 2023 07:41:11 -0700 (PDT) From: Jim Quinlan To: linux-pci@vger.kernel.org, Nicolas Saenz Julienne , Bjorn Helgaas , Lorenzo Pieralisi , Cyril Brulebois , Phil Elwell , bcm-kernel-feedback-list@broadcom.com, james.quinlan@broadcom.com Cc: Florian Fainelli , Jim Quinlan , Lorenzo Pieralisi , =?utf-8?q?Krzysztof_Wilczy=C5=84?= =?utf-8?q?ski?= , Rob Herring , linux-rpi-kernel@lists.infradead.org (moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE), linux-arm-kernel@lists.infradead.org (moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE), linux-kernel@vger.kernel.org (open list) Subject: [PATCH v6 4/5] PCI: brcmstb: Assert PERST# on BCM2711 Date: Fri, 23 Jun 2023 10:40:57 -0400 Message-Id: <20230623144100.34196-5-james.quinlan@broadcom.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20230623144100.34196-1-james.quinlan@broadcom.com> References: <20230623144100.34196-1-james.quinlan@broadcom.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230623_074115_700699_132135B7 X-CRM114-Status: GOOD ( 12.00 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The current PCIe driver assumes PERST# is asserted when probe() is invoked. Some older versions of the 2711/RPi bootloader left PERST# unasserted, as the Raspian OS does assert PERST# on probe(). For this reason, we assert PERST# for BCM2711 SOCs (i.e. RPi). Signed-off-by: Jim Quinlan --- drivers/pci/controller/pcie-brcmstb.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/pci/controller/pcie-brcmstb.c b/drivers/pci/controller/pcie-brcmstb.c index fe0415a98c63..7b698a9a851e 100644 --- a/drivers/pci/controller/pcie-brcmstb.c +++ b/drivers/pci/controller/pcie-brcmstb.c @@ -884,6 +884,11 @@ static int brcm_pcie_setup(struct brcm_pcie *pcie) /* Reset the bridge */ pcie->bridge_sw_init_set(pcie, 1); + + /* Ensure that PERST# is asserted; some bootloaders may deassert it. */ + if (pcie->type == BCM2711) + pcie->perst_set(pcie, 1); + usleep_range(100, 200); /* Take the bridge out of reset */