| Message ID | 20230707162217.675390-1-cristian.ciocaltea@collabora.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | arm64: dts: rockchip: Drop invalid regulator-init-microvolt property | expand |
Reviewed-by: David Heidelberg <david@ixit.cz> On 07/07/2023 18:22, Cristian Ciocaltea wrote: > The 'regulator-init-microvolt' property is not currently supported by > any driver, it was simply carried on from downstream kernels. > > The problem is also indicated by the following dtbs_check warning: > > rk3588-rock-5b.dtb: pmic@0: regulators:dcdc-reg4: Unevaluated properties are not allowed ('regulator-init-microvolt' was unexpected) > > Remove the invalid property from all affected DTS files. > > Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com> > --- > arch/arm64/boot/dts/rockchip/rk3308-roc-cc.dts | 1 - > arch/arm64/boot/dts/rockchip/rk3308-rock-pi-s.dts | 1 - > arch/arm64/boot/dts/rockchip/rk3399-nanopi4.dtsi | 1 - > arch/arm64/boot/dts/rockchip/rk3566-anbernic-rgxx3.dtsi | 3 --- > arch/arm64/boot/dts/rockchip/rk3566-lubancat-1.dts | 3 --- > arch/arm64/boot/dts/rockchip/rk3566-pinenote.dtsi | 2 -- > arch/arm64/boot/dts/rockchip/rk3566-quartz64-a.dts | 2 -- > arch/arm64/boot/dts/rockchip/rk3566-quartz64-b.dts | 2 -- > arch/arm64/boot/dts/rockchip/rk3566-roc-pc.dts | 2 -- > arch/arm64/boot/dts/rockchip/rk3566-soquartz.dtsi | 3 --- > arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts | 3 --- > arch/arm64/boot/dts/rockchip/rk3568-evb1-v10.dts | 3 --- > arch/arm64/boot/dts/rockchip/rk3568-fastrhino-r66s.dtsi | 4 ---- > arch/arm64/boot/dts/rockchip/rk3568-lubancat-2.dts | 3 --- > arch/arm64/boot/dts/rockchip/rk3568-nanopi-r5s.dtsi | 3 --- > arch/arm64/boot/dts/rockchip/rk3568-odroid-m1.dts | 3 --- > arch/arm64/boot/dts/rockchip/rk3568-radxa-cm3i.dtsi | 3 --- > arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts | 3 --- > arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts | 1 - > 19 files changed, 46 deletions(-) > > diff --git a/arch/arm64/boot/dts/rockchip/rk3308-roc-cc.dts b/arch/arm64/boot/dts/rockchip/rk3308-roc-cc.dts > index 7ea48167747c..9232357f4fec 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3308-roc-cc.dts > +++ b/arch/arm64/boot/dts/rockchip/rk3308-roc-cc.dts > @@ -106,7 +106,6 @@ vdd_core: vdd-core { > regulator-name = "vdd_core"; > regulator-min-microvolt = <827000>; > regulator-max-microvolt = <1340000>; > - regulator-init-microvolt = <1015000>; > regulator-settling-time-up-us = <250>; > regulator-always-on; > regulator-boot-on; > diff --git a/arch/arm64/boot/dts/rockchip/rk3308-rock-pi-s.dts b/arch/arm64/boot/dts/rockchip/rk3308-rock-pi-s.dts > index a71f249ed384..e9810d2f0407 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3308-rock-pi-s.dts > +++ b/arch/arm64/boot/dts/rockchip/rk3308-rock-pi-s.dts > @@ -105,7 +105,6 @@ vdd_core: vdd-core { > regulator-name = "vdd_core"; > regulator-min-microvolt = <827000>; > regulator-max-microvolt = <1340000>; > - regulator-init-microvolt = <1015000>; > regulator-settling-time-up-us = <250>; > regulator-always-on; > regulator-boot-on; > diff --git a/arch/arm64/boot/dts/rockchip/rk3399-nanopi4.dtsi b/arch/arm64/boot/dts/rockchip/rk3399-nanopi4.dtsi > index b6e082f1f6d9..7c5f441a2219 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3399-nanopi4.dtsi > +++ b/arch/arm64/boot/dts/rockchip/rk3399-nanopi4.dtsi > @@ -375,7 +375,6 @@ regulator-state-mem { > vcc_sdio: LDO_REG4 { > regulator-always-on; > regulator-boot-on; > - regulator-init-microvolt = <3000000>; > regulator-min-microvolt = <1800000>; > regulator-max-microvolt = <3300000>; > regulator-name = "vcc_sdio"; > diff --git a/arch/arm64/boot/dts/rockchip/rk3566-anbernic-rgxx3.dtsi b/arch/arm64/boot/dts/rockchip/rk3566-anbernic-rgxx3.dtsi > index a2c31d53b45b..8cbf3d9a4f22 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3566-anbernic-rgxx3.dtsi > +++ b/arch/arm64/boot/dts/rockchip/rk3566-anbernic-rgxx3.dtsi > @@ -356,7 +356,6 @@ vdd_logic: DCDC_REG1 { > regulator-boot-on; > regulator-min-microvolt = <500000>; > regulator-max-microvolt = <1350000>; > - regulator-init-microvolt = <900000>; > regulator-ramp-delay = <6001>; > regulator-initial-mode = <0x2>; > regulator-name = "vdd_logic"; > @@ -371,7 +370,6 @@ vdd_gpu: DCDC_REG2 { > regulator-boot-on; > regulator-min-microvolt = <500000>; > regulator-max-microvolt = <1350000>; > - regulator-init-microvolt = <900000>; > regulator-ramp-delay = <6001>; > regulator-initial-mode = <0x2>; > regulator-name = "vdd_gpu"; > @@ -533,7 +531,6 @@ vdd_cpu: regulator@40 { > regulator-boot-on; > regulator-min-microvolt = <712500>; > regulator-max-microvolt = <1390000>; > - regulator-init-microvolt = <900000>; > regulator-name = "vdd_cpu"; > regulator-ramp-delay = <2300>; > vin-supply = <&vcc_sys>; > diff --git a/arch/arm64/boot/dts/rockchip/rk3566-lubancat-1.dts b/arch/arm64/boot/dts/rockchip/rk3566-lubancat-1.dts > index ff936b713579..1c6d83b47cd2 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3566-lubancat-1.dts > +++ b/arch/arm64/boot/dts/rockchip/rk3566-lubancat-1.dts > @@ -218,7 +218,6 @@ vdd_logic: DCDC_REG1 { > regulator-boot-on; > regulator-min-microvolt = <500000>; > regulator-max-microvolt = <1350000>; > - regulator-init-microvolt = <900000>; > regulator-ramp-delay = <6001>; > regulator-initial-mode = <0x2>; > > @@ -233,7 +232,6 @@ vdd_gpu: DCDC_REG2 { > regulator-boot-on; > regulator-min-microvolt = <500000>; > regulator-max-microvolt = <1350000>; > - regulator-init-microvolt = <900000>; > regulator-ramp-delay = <6001>; > regulator-initial-mode = <0x2>; > > @@ -259,7 +257,6 @@ vdd_npu: DCDC_REG4 { > regulator-boot-on; > regulator-min-microvolt = <500000>; > regulator-max-microvolt = <1350000>; > - regulator-init-microvolt = <900000>; > regulator-ramp-delay = <6001>; > regulator-initial-mode = <0x2>; > > diff --git a/arch/arm64/boot/dts/rockchip/rk3566-pinenote.dtsi b/arch/arm64/boot/dts/rockchip/rk3566-pinenote.dtsi > index 8d61f824c12d..d899087bf0b5 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3566-pinenote.dtsi > +++ b/arch/arm64/boot/dts/rockchip/rk3566-pinenote.dtsi > @@ -264,7 +264,6 @@ vdd_logic: DCDC_REG1 { > regulator-always-on; > regulator-min-microvolt = <500000>; > regulator-max-microvolt = <1350000>; > - regulator-init-microvolt = <900000>; > regulator-ramp-delay = <6001>; > regulator-initial-mode = <0x2>; > > @@ -278,7 +277,6 @@ vdd_gpu_npu: DCDC_REG2 { > regulator-name = "vdd_gpu_npu"; > regulator-min-microvolt = <500000>; > regulator-max-microvolt = <1350000>; > - regulator-init-microvolt = <900000>; > regulator-ramp-delay = <6001>; > regulator-initial-mode = <0x2>; > > diff --git a/arch/arm64/boot/dts/rockchip/rk3566-quartz64-a.dts b/arch/arm64/boot/dts/rockchip/rk3566-quartz64-a.dts > index 25a8c781f4e7..854d02b46e6f 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3566-quartz64-a.dts > +++ b/arch/arm64/boot/dts/rockchip/rk3566-quartz64-a.dts > @@ -366,7 +366,6 @@ vdd_logic: DCDC_REG1 { > regulator-boot-on; > regulator-min-microvolt = <500000>; > regulator-max-microvolt = <1350000>; > - regulator-init-microvolt = <900000>; > regulator-ramp-delay = <6001>; > regulator-initial-mode = <0x2>; > regulator-name = "vdd_logic"; > @@ -381,7 +380,6 @@ vdd_gpu: DCDC_REG2 { > regulator-boot-on; > regulator-min-microvolt = <500000>; > regulator-max-microvolt = <1350000>; > - regulator-init-microvolt = <900000>; > regulator-ramp-delay = <6001>; > regulator-initial-mode = <0x2>; > regulator-name = "vdd_gpu"; > diff --git a/arch/arm64/boot/dts/rockchip/rk3566-quartz64-b.dts b/arch/arm64/boot/dts/rockchip/rk3566-quartz64-b.dts > index b276eb0810c7..2d92713be2a0 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3566-quartz64-b.dts > +++ b/arch/arm64/boot/dts/rockchip/rk3566-quartz64-b.dts > @@ -277,7 +277,6 @@ vdd_log: DCDC_REG1 { > regulator-boot-on; > regulator-min-microvolt = <500000>; > regulator-max-microvolt = <1350000>; > - regulator-init-microvolt = <900000>; > regulator-ramp-delay = <6001>; > > regulator-state-mem { > @@ -292,7 +291,6 @@ vdd_gpu: DCDC_REG2 { > regulator-boot-on; > regulator-min-microvolt = <900000>; > regulator-max-microvolt = <1350000>; > - regulator-init-microvolt = <900000>; > regulator-ramp-delay = <6001>; > > regulator-state-mem { > diff --git a/arch/arm64/boot/dts/rockchip/rk3566-roc-pc.dts b/arch/arm64/boot/dts/rockchip/rk3566-roc-pc.dts > index 42889c5900bd..938092fce186 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3566-roc-pc.dts > +++ b/arch/arm64/boot/dts/rockchip/rk3566-roc-pc.dts > @@ -278,7 +278,6 @@ vdd_log: DCDC_REG1 { > regulator-boot-on; > regulator-min-microvolt = <500000>; > regulator-max-microvolt = <1350000>; > - regulator-init-microvolt = <900000>; > regulator-ramp-delay = <6001>; > > regulator-state-mem { > @@ -291,7 +290,6 @@ vdd_gpu: DCDC_REG2 { > regulator-name = "vdd_gpu"; > regulator-min-microvolt = <900000>; > regulator-max-microvolt = <1350000>; > - regulator-init-microvolt = <900000>; > regulator-ramp-delay = <6001>; > > regulator-state-mem { > diff --git a/arch/arm64/boot/dts/rockchip/rk3566-soquartz.dtsi b/arch/arm64/boot/dts/rockchip/rk3566-soquartz.dtsi > index 31aa2b8efe39..63bae36b8f7e 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3566-soquartz.dtsi > +++ b/arch/arm64/boot/dts/rockchip/rk3566-soquartz.dtsi > @@ -234,7 +234,6 @@ vdd_logic: DCDC_REG1 { > regulator-boot-on; > regulator-min-microvolt = <500000>; > regulator-max-microvolt = <1350000>; > - regulator-init-microvolt = <900000>; > regulator-ramp-delay = <6001>; > regulator-initial-mode = <0x2>; > regulator-state-mem { > @@ -249,7 +248,6 @@ vdd_gpu: DCDC_REG2 { > regulator-boot-on; > regulator-min-microvolt = <500000>; > regulator-max-microvolt = <1350000>; > - regulator-init-microvolt = <900000>; > regulator-ramp-delay = <6001>; > regulator-initial-mode = <0x2>; > regulator-state-mem { > @@ -272,7 +270,6 @@ vdd_npu: DCDC_REG4 { > regulator-boot-on; > regulator-min-microvolt = <500000>; > regulator-max-microvolt = <1350000>; > - regulator-init-microvolt = <900000>; > regulator-initial-mode = <0x2>; > regulator-name = "vdd_npu"; > regulator-state-mem { > diff --git a/arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts b/arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts > index ff0bf24cc1a2..f9127ddfbb7d 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts > +++ b/arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts > @@ -308,7 +308,6 @@ vdd_logic: DCDC_REG1 { > regulator-name = "vdd_logic"; > regulator-always-on; > regulator-boot-on; > - regulator-init-microvolt = <900000>; > regulator-initial-mode = <0x2>; > regulator-min-microvolt = <500000>; > regulator-max-microvolt = <1350000>; > @@ -322,7 +321,6 @@ regulator-state-mem { > vdd_gpu: DCDC_REG2 { > regulator-name = "vdd_gpu"; > regulator-always-on; > - regulator-init-microvolt = <900000>; > regulator-initial-mode = <0x2>; > regulator-min-microvolt = <500000>; > regulator-max-microvolt = <1350000>; > @@ -346,7 +344,6 @@ regulator-state-mem { > > vdd_npu: DCDC_REG4 { > regulator-name = "vdd_npu"; > - regulator-init-microvolt = <900000>; > regulator-initial-mode = <0x2>; > regulator-min-microvolt = <500000>; > regulator-max-microvolt = <1350000>; > diff --git a/arch/arm64/boot/dts/rockchip/rk3568-evb1-v10.dts b/arch/arm64/boot/dts/rockchip/rk3568-evb1-v10.dts > index 674792567fa6..19f8fc369b13 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3568-evb1-v10.dts > +++ b/arch/arm64/boot/dts/rockchip/rk3568-evb1-v10.dts > @@ -293,7 +293,6 @@ vdd_logic: DCDC_REG1 { > regulator-name = "vdd_logic"; > regulator-always-on; > regulator-boot-on; > - regulator-init-microvolt = <900000>; > regulator-initial-mode = <0x2>; > regulator-min-microvolt = <500000>; > regulator-max-microvolt = <1350000>; > @@ -307,7 +306,6 @@ regulator-state-mem { > vdd_gpu: DCDC_REG2 { > regulator-name = "vdd_gpu"; > regulator-always-on; > - regulator-init-microvolt = <900000>; > regulator-initial-mode = <0x2>; > regulator-min-microvolt = <500000>; > regulator-max-microvolt = <1350000>; > @@ -331,7 +329,6 @@ regulator-state-mem { > > vdd_npu: DCDC_REG4 { > regulator-name = "vdd_npu"; > - regulator-init-microvolt = <900000>; > regulator-initial-mode = <0x2>; > regulator-min-microvolt = <500000>; > regulator-max-microvolt = <1350000>; > diff --git a/arch/arm64/boot/dts/rockchip/rk3568-fastrhino-r66s.dtsi b/arch/arm64/boot/dts/rockchip/rk3568-fastrhino-r66s.dtsi > index 25e205632a68..89e84e3a9262 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3568-fastrhino-r66s.dtsi > +++ b/arch/arm64/boot/dts/rockchip/rk3568-fastrhino-r66s.dtsi > @@ -173,7 +173,6 @@ vdd_logic: DCDC_REG1 { > regulator-name = "vdd_logic"; > regulator-always-on; > regulator-boot-on; > - regulator-init-microvolt = <900000>; > regulator-initial-mode = <0x2>; > regulator-min-microvolt = <500000>; > regulator-max-microvolt = <1350000>; > @@ -187,7 +186,6 @@ regulator-state-mem { > vdd_gpu: DCDC_REG2 { > regulator-name = "vdd_gpu"; > regulator-always-on; > - regulator-init-microvolt = <900000>; > regulator-initial-mode = <0x2>; > regulator-min-microvolt = <500000>; > regulator-max-microvolt = <1350000>; > @@ -211,7 +209,6 @@ regulator-state-mem { > > vdd_npu: DCDC_REG4 { > regulator-name = "vdd_npu"; > - regulator-init-microvolt = <900000>; > regulator-initial-mode = <0x2>; > regulator-min-microvolt = <500000>; > regulator-max-microvolt = <1350000>; > @@ -330,7 +327,6 @@ regulator-state-mem { > > vcca1v8_image: LDO_REG9 { > regulator-name = "vcca1v8_image"; > - regulator-init-microvolt = <950000>; > regulator-min-microvolt = <950000>; > regulator-max-microvolt = <1800000>; > > diff --git a/arch/arm64/boot/dts/rockchip/rk3568-lubancat-2.dts b/arch/arm64/boot/dts/rockchip/rk3568-lubancat-2.dts > index e653b067aa5d..a8a4cc190eb3 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3568-lubancat-2.dts > +++ b/arch/arm64/boot/dts/rockchip/rk3568-lubancat-2.dts > @@ -243,7 +243,6 @@ vdd_logic: DCDC_REG1 { > regulator-boot-on; > regulator-min-microvolt = <500000>; > regulator-max-microvolt = <1350000>; > - regulator-init-microvolt = <900000>; > regulator-ramp-delay = <6001>; > regulator-initial-mode = <0x2>; > > @@ -258,7 +257,6 @@ vdd_gpu: DCDC_REG2 { > regulator-boot-on; > regulator-min-microvolt = <500000>; > regulator-max-microvolt = <1350000>; > - regulator-init-microvolt = <900000>; > regulator-ramp-delay = <6001>; > regulator-initial-mode = <0x2>; > > @@ -284,7 +282,6 @@ vdd_npu: DCDC_REG4 { > regulator-boot-on; > regulator-min-microvolt = <500000>; > regulator-max-microvolt = <1350000>; > - regulator-init-microvolt = <900000>; > regulator-ramp-delay = <6001>; > regulator-initial-mode = <0x2>; > > diff --git a/arch/arm64/boot/dts/rockchip/rk3568-nanopi-r5s.dtsi b/arch/arm64/boot/dts/rockchip/rk3568-nanopi-r5s.dtsi > index 58ba328ea782..93189f830640 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3568-nanopi-r5s.dtsi > +++ b/arch/arm64/boot/dts/rockchip/rk3568-nanopi-r5s.dtsi > @@ -232,7 +232,6 @@ vdd_logic: DCDC_REG1 { > regulator-name = "vdd_logic"; > regulator-always-on; > regulator-boot-on; > - regulator-init-microvolt = <900000>; > regulator-initial-mode = <0x2>; > regulator-min-microvolt = <500000>; > regulator-max-microvolt = <1350000>; > @@ -246,7 +245,6 @@ regulator-state-mem { > vdd_gpu: DCDC_REG2 { > regulator-name = "vdd_gpu"; > regulator-always-on; > - regulator-init-microvolt = <900000>; > regulator-initial-mode = <0x2>; > regulator-min-microvolt = <500000>; > regulator-max-microvolt = <1350000>; > @@ -270,7 +268,6 @@ regulator-state-mem { > > vdd_npu: DCDC_REG4 { > regulator-name = "vdd_npu"; > - regulator-init-microvolt = <900000>; > regulator-initial-mode = <0x2>; > regulator-min-microvolt = <500000>; > regulator-max-microvolt = <1350000>; > diff --git a/arch/arm64/boot/dts/rockchip/rk3568-odroid-m1.dts b/arch/arm64/boot/dts/rockchip/rk3568-odroid-m1.dts > index 59ecf868dbd0..a337f547caf5 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3568-odroid-m1.dts > +++ b/arch/arm64/boot/dts/rockchip/rk3568-odroid-m1.dts > @@ -291,7 +291,6 @@ vdd_logic: DCDC_REG1 { > regulator-name = "vdd_logic"; > regulator-always-on; > regulator-boot-on; > - regulator-init-microvolt = <900000>; > regulator-initial-mode = <0x2>; > regulator-min-microvolt = <500000>; > regulator-max-microvolt = <1350000>; > @@ -305,7 +304,6 @@ regulator-state-mem { > vdd_gpu: DCDC_REG2 { > regulator-name = "vdd_gpu"; > regulator-always-on; > - regulator-init-microvolt = <900000>; > regulator-initial-mode = <0x2>; > regulator-min-microvolt = <500000>; > regulator-max-microvolt = <1350000>; > @@ -329,7 +327,6 @@ regulator-state-mem { > > vdd_npu: DCDC_REG4 { > regulator-name = "vdd_npu"; > - regulator-init-microvolt = <900000>; > regulator-initial-mode = <0x2>; > regulator-min-microvolt = <500000>; > regulator-max-microvolt = <1350000>; > diff --git a/arch/arm64/boot/dts/rockchip/rk3568-radxa-cm3i.dtsi b/arch/arm64/boot/dts/rockchip/rk3568-radxa-cm3i.dtsi > index c50fbdd48680..45b03dcbbad4 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3568-radxa-cm3i.dtsi > +++ b/arch/arm64/boot/dts/rockchip/rk3568-radxa-cm3i.dtsi > @@ -163,7 +163,6 @@ vdd_logic: DCDC_REG1 { > regulator-name = "vdd_logic"; > regulator-always-on; > regulator-boot-on; > - regulator-init-microvolt = <900000>; > regulator-initial-mode = <0x2>; > regulator-min-microvolt = <500000>; > regulator-max-microvolt = <1350000>; > @@ -177,7 +176,6 @@ regulator-state-mem { > vdd_gpu: DCDC_REG2 { > regulator-name = "vdd_gpu"; > regulator-always-on; > - regulator-init-microvolt = <900000>; > regulator-initial-mode = <0x2>; > regulator-min-microvolt = <500000>; > regulator-max-microvolt = <1350000>; > @@ -201,7 +199,6 @@ regulator-state-mem { > > vdd_npu: DCDC_REG4 { > regulator-name = "vdd_npu"; > - regulator-init-microvolt = <900000>; > regulator-initial-mode = <0x2>; > regulator-min-microvolt = <500000>; > regulator-max-microvolt = <1350000>; > diff --git a/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts b/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts > index 917f5b2b8aab..e05ab11981f5 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts > +++ b/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts > @@ -350,7 +350,6 @@ vdd_logic: DCDC_REG1 { > regulator-name = "vdd_logic"; > regulator-always-on; > regulator-boot-on; > - regulator-init-microvolt = <900000>; > regulator-initial-mode = <0x2>; > regulator-min-microvolt = <500000>; > regulator-max-microvolt = <1350000>; > @@ -364,7 +363,6 @@ regulator-state-mem { > vdd_gpu: DCDC_REG2 { > regulator-name = "vdd_gpu"; > regulator-always-on; > - regulator-init-microvolt = <900000>; > regulator-initial-mode = <0x2>; > regulator-min-microvolt = <500000>; > regulator-max-microvolt = <1350000>; > @@ -388,7 +386,6 @@ regulator-state-mem { > > vdd_npu: DCDC_REG4 { > regulator-name = "vdd_npu"; > - regulator-init-microvolt = <900000>; > regulator-initial-mode = <0x2>; > regulator-min-microvolt = <500000>; > regulator-max-microvolt = <1350000>; > diff --git a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts > index afda976680bc..51537030f8e3 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts > +++ b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts > @@ -337,7 +337,6 @@ vdd_vdenc_s0: vdd_vdenc_mem_s0: dcdc-reg4 { > regulator-boot-on; > regulator-min-microvolt = <550000>; > regulator-max-microvolt = <950000>; > - regulator-init-microvolt = <750000>; > regulator-ramp-delay = <12500>; > regulator-name = "vdd_vdenc_s0"; >
Il 07/07/23 18:22, Cristian Ciocaltea ha scritto: > The 'regulator-init-microvolt' property is not currently supported by > any driver, it was simply carried on from downstream kernels. > > The problem is also indicated by the following dtbs_check warning: > > rk3588-rock-5b.dtb: pmic@0: regulators:dcdc-reg4: Unevaluated properties are not allowed ('regulator-init-microvolt' was unexpected) > > Remove the invalid property from all affected DTS files. > > Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
On Fri, 7 Jul 2023 19:22:17 +0300, Cristian Ciocaltea wrote: > The 'regulator-init-microvolt' property is not currently supported by > any driver, it was simply carried on from downstream kernels. > > The problem is also indicated by the following dtbs_check warning: > > rk3588-rock-5b.dtb: pmic@0: regulators:dcdc-reg4: Unevaluated properties are not allowed ('regulator-init-microvolt' was unexpected) > > [...] Applied, thanks! [1/1] arm64: dts: rockchip: Drop invalid regulator-init-microvolt property commit: 4d08b19629495b29601991d09d07865694c25199 Best regards,
> From: Heiko Stuebner <heiko@sntech.de> > Date: Mon, 10 Jul 2023 16:16:16 +0200 > > On Fri, 7 Jul 2023 19:22:17 +0300, Cristian Ciocaltea wrote: > > The 'regulator-init-microvolt' property is not currently supported by > > any driver, it was simply carried on from downstream kernels. > > > > The problem is also indicated by the following dtbs_check warning: > > > > rk3588-rock-5b.dtb: pmic@0: regulators:dcdc-reg4: Unevaluated properties are not allowed ('regulator-init-microvolt' was unexpected) > > > > [...] > > Applied, thanks! > > [1/1] arm64: dts: rockchip: Drop invalid regulator-init-microvolt property > commit: 4d08b19629495b29601991d09d07865694c25199 This property *is used* by the drivers in U-Boot. Dropping this from the Linux DTBs will likely result in broken boards the next time the U-Boot DTBs are synched again from Linux. At least that is what happened before... I think the right solution is to add this property to the DT binding instead.
On 10/07/2023 16:35, Mark Kettenis wrote: >> From: Heiko Stuebner <heiko@sntech.de> >> Date: Mon, 10 Jul 2023 16:16:16 +0200 >> >> On Fri, 7 Jul 2023 19:22:17 +0300, Cristian Ciocaltea wrote: >>> The 'regulator-init-microvolt' property is not currently supported by >>> any driver, it was simply carried on from downstream kernels. >>> >>> The problem is also indicated by the following dtbs_check warning: >>> >>> rk3588-rock-5b.dtb: pmic@0: regulators:dcdc-reg4: Unevaluated properties are not allowed ('regulator-init-microvolt' was unexpected) >>> >>> [...] >> Applied, thanks! >> >> [1/1] arm64: dts: rockchip: Drop invalid regulator-init-microvolt property >> commit: 4d08b19629495b29601991d09d07865694c25199 > This property *is used* by the drivers in U-Boot. Dropping this from > the Linux DTBs will likely result in broken boards the next time the > U-Boot DTBs are synched again from Linux. At least that is what > happened before... Well, if u-boot uses these properties, u-boot folks should document them in bindings ;-) I found some u-boot mentions reviewing this patch, but only the DTS files copied from Linux poped-up. > > I think the right solution is to add this property to the DT binding > instead. Sure, it should be sent together with the revert. DT binding property description could also note that the bootloader(s) use the value. David
Am Montag, 10. Juli 2023, 16:35:36 CEST schrieb Mark Kettenis: > > From: Heiko Stuebner <heiko@sntech.de> > > Date: Mon, 10 Jul 2023 16:16:16 +0200 > > > > On Fri, 7 Jul 2023 19:22:17 +0300, Cristian Ciocaltea wrote: > > > The 'regulator-init-microvolt' property is not currently supported by > > > any driver, it was simply carried on from downstream kernels. > > > > > > The problem is also indicated by the following dtbs_check warning: > > > > > > rk3588-rock-5b.dtb: pmic@0: regulators:dcdc-reg4: Unevaluated properties are not allowed ('regulator-init-microvolt' was unexpected) > > > > > > [...] > > > > Applied, thanks! > > > > [1/1] arm64: dts: rockchip: Drop invalid regulator-init-microvolt property > > commit: 4d08b19629495b29601991d09d07865694c25199 > > This property *is used* by the drivers in U-Boot. Dropping this from > the Linux DTBs will likely result in broken boards the next time the > U-Boot DTBs are synched again from Linux. At least that is what > happened before... > > I think the right solution is to add this property to the DT binding > instead. I do have this vague memory of this coming up in the past, though don't remember what the resolution was then? Though it definitly doesn't look like the property was added to the binding in the meantime. Also I think that setting up initial regulator state would be (and seemingly is) for firmware to handle, so that property should instead be in the -uboot.dtsi. That DT isn't a configuration-space also is a decade long mantra. Heiko
diff --git a/arch/arm64/boot/dts/rockchip/rk3308-roc-cc.dts b/arch/arm64/boot/dts/rockchip/rk3308-roc-cc.dts index 7ea48167747c..9232357f4fec 100644 --- a/arch/arm64/boot/dts/rockchip/rk3308-roc-cc.dts +++ b/arch/arm64/boot/dts/rockchip/rk3308-roc-cc.dts @@ -106,7 +106,6 @@ vdd_core: vdd-core { regulator-name = "vdd_core"; regulator-min-microvolt = <827000>; regulator-max-microvolt = <1340000>; - regulator-init-microvolt = <1015000>; regulator-settling-time-up-us = <250>; regulator-always-on; regulator-boot-on; diff --git a/arch/arm64/boot/dts/rockchip/rk3308-rock-pi-s.dts b/arch/arm64/boot/dts/rockchip/rk3308-rock-pi-s.dts index a71f249ed384..e9810d2f0407 100644 --- a/arch/arm64/boot/dts/rockchip/rk3308-rock-pi-s.dts +++ b/arch/arm64/boot/dts/rockchip/rk3308-rock-pi-s.dts @@ -105,7 +105,6 @@ vdd_core: vdd-core { regulator-name = "vdd_core"; regulator-min-microvolt = <827000>; regulator-max-microvolt = <1340000>; - regulator-init-microvolt = <1015000>; regulator-settling-time-up-us = <250>; regulator-always-on; regulator-boot-on; diff --git a/arch/arm64/boot/dts/rockchip/rk3399-nanopi4.dtsi b/arch/arm64/boot/dts/rockchip/rk3399-nanopi4.dtsi index b6e082f1f6d9..7c5f441a2219 100644 --- a/arch/arm64/boot/dts/rockchip/rk3399-nanopi4.dtsi +++ b/arch/arm64/boot/dts/rockchip/rk3399-nanopi4.dtsi @@ -375,7 +375,6 @@ regulator-state-mem { vcc_sdio: LDO_REG4 { regulator-always-on; regulator-boot-on; - regulator-init-microvolt = <3000000>; regulator-min-microvolt = <1800000>; regulator-max-microvolt = <3300000>; regulator-name = "vcc_sdio"; diff --git a/arch/arm64/boot/dts/rockchip/rk3566-anbernic-rgxx3.dtsi b/arch/arm64/boot/dts/rockchip/rk3566-anbernic-rgxx3.dtsi index a2c31d53b45b..8cbf3d9a4f22 100644 --- a/arch/arm64/boot/dts/rockchip/rk3566-anbernic-rgxx3.dtsi +++ b/arch/arm64/boot/dts/rockchip/rk3566-anbernic-rgxx3.dtsi @@ -356,7 +356,6 @@ vdd_logic: DCDC_REG1 { regulator-boot-on; regulator-min-microvolt = <500000>; regulator-max-microvolt = <1350000>; - regulator-init-microvolt = <900000>; regulator-ramp-delay = <6001>; regulator-initial-mode = <0x2>; regulator-name = "vdd_logic"; @@ -371,7 +370,6 @@ vdd_gpu: DCDC_REG2 { regulator-boot-on; regulator-min-microvolt = <500000>; regulator-max-microvolt = <1350000>; - regulator-init-microvolt = <900000>; regulator-ramp-delay = <6001>; regulator-initial-mode = <0x2>; regulator-name = "vdd_gpu"; @@ -533,7 +531,6 @@ vdd_cpu: regulator@40 { regulator-boot-on; regulator-min-microvolt = <712500>; regulator-max-microvolt = <1390000>; - regulator-init-microvolt = <900000>; regulator-name = "vdd_cpu"; regulator-ramp-delay = <2300>; vin-supply = <&vcc_sys>; diff --git a/arch/arm64/boot/dts/rockchip/rk3566-lubancat-1.dts b/arch/arm64/boot/dts/rockchip/rk3566-lubancat-1.dts index ff936b713579..1c6d83b47cd2 100644 --- a/arch/arm64/boot/dts/rockchip/rk3566-lubancat-1.dts +++ b/arch/arm64/boot/dts/rockchip/rk3566-lubancat-1.dts @@ -218,7 +218,6 @@ vdd_logic: DCDC_REG1 { regulator-boot-on; regulator-min-microvolt = <500000>; regulator-max-microvolt = <1350000>; - regulator-init-microvolt = <900000>; regulator-ramp-delay = <6001>; regulator-initial-mode = <0x2>; @@ -233,7 +232,6 @@ vdd_gpu: DCDC_REG2 { regulator-boot-on; regulator-min-microvolt = <500000>; regulator-max-microvolt = <1350000>; - regulator-init-microvolt = <900000>; regulator-ramp-delay = <6001>; regulator-initial-mode = <0x2>; @@ -259,7 +257,6 @@ vdd_npu: DCDC_REG4 { regulator-boot-on; regulator-min-microvolt = <500000>; regulator-max-microvolt = <1350000>; - regulator-init-microvolt = <900000>; regulator-ramp-delay = <6001>; regulator-initial-mode = <0x2>; diff --git a/arch/arm64/boot/dts/rockchip/rk3566-pinenote.dtsi b/arch/arm64/boot/dts/rockchip/rk3566-pinenote.dtsi index 8d61f824c12d..d899087bf0b5 100644 --- a/arch/arm64/boot/dts/rockchip/rk3566-pinenote.dtsi +++ b/arch/arm64/boot/dts/rockchip/rk3566-pinenote.dtsi @@ -264,7 +264,6 @@ vdd_logic: DCDC_REG1 { regulator-always-on; regulator-min-microvolt = <500000>; regulator-max-microvolt = <1350000>; - regulator-init-microvolt = <900000>; regulator-ramp-delay = <6001>; regulator-initial-mode = <0x2>; @@ -278,7 +277,6 @@ vdd_gpu_npu: DCDC_REG2 { regulator-name = "vdd_gpu_npu"; regulator-min-microvolt = <500000>; regulator-max-microvolt = <1350000>; - regulator-init-microvolt = <900000>; regulator-ramp-delay = <6001>; regulator-initial-mode = <0x2>; diff --git a/arch/arm64/boot/dts/rockchip/rk3566-quartz64-a.dts b/arch/arm64/boot/dts/rockchip/rk3566-quartz64-a.dts index 25a8c781f4e7..854d02b46e6f 100644 --- a/arch/arm64/boot/dts/rockchip/rk3566-quartz64-a.dts +++ b/arch/arm64/boot/dts/rockchip/rk3566-quartz64-a.dts @@ -366,7 +366,6 @@ vdd_logic: DCDC_REG1 { regulator-boot-on; regulator-min-microvolt = <500000>; regulator-max-microvolt = <1350000>; - regulator-init-microvolt = <900000>; regulator-ramp-delay = <6001>; regulator-initial-mode = <0x2>; regulator-name = "vdd_logic"; @@ -381,7 +380,6 @@ vdd_gpu: DCDC_REG2 { regulator-boot-on; regulator-min-microvolt = <500000>; regulator-max-microvolt = <1350000>; - regulator-init-microvolt = <900000>; regulator-ramp-delay = <6001>; regulator-initial-mode = <0x2>; regulator-name = "vdd_gpu"; diff --git a/arch/arm64/boot/dts/rockchip/rk3566-quartz64-b.dts b/arch/arm64/boot/dts/rockchip/rk3566-quartz64-b.dts index b276eb0810c7..2d92713be2a0 100644 --- a/arch/arm64/boot/dts/rockchip/rk3566-quartz64-b.dts +++ b/arch/arm64/boot/dts/rockchip/rk3566-quartz64-b.dts @@ -277,7 +277,6 @@ vdd_log: DCDC_REG1 { regulator-boot-on; regulator-min-microvolt = <500000>; regulator-max-microvolt = <1350000>; - regulator-init-microvolt = <900000>; regulator-ramp-delay = <6001>; regulator-state-mem { @@ -292,7 +291,6 @@ vdd_gpu: DCDC_REG2 { regulator-boot-on; regulator-min-microvolt = <900000>; regulator-max-microvolt = <1350000>; - regulator-init-microvolt = <900000>; regulator-ramp-delay = <6001>; regulator-state-mem { diff --git a/arch/arm64/boot/dts/rockchip/rk3566-roc-pc.dts b/arch/arm64/boot/dts/rockchip/rk3566-roc-pc.dts index 42889c5900bd..938092fce186 100644 --- a/arch/arm64/boot/dts/rockchip/rk3566-roc-pc.dts +++ b/arch/arm64/boot/dts/rockchip/rk3566-roc-pc.dts @@ -278,7 +278,6 @@ vdd_log: DCDC_REG1 { regulator-boot-on; regulator-min-microvolt = <500000>; regulator-max-microvolt = <1350000>; - regulator-init-microvolt = <900000>; regulator-ramp-delay = <6001>; regulator-state-mem { @@ -291,7 +290,6 @@ vdd_gpu: DCDC_REG2 { regulator-name = "vdd_gpu"; regulator-min-microvolt = <900000>; regulator-max-microvolt = <1350000>; - regulator-init-microvolt = <900000>; regulator-ramp-delay = <6001>; regulator-state-mem { diff --git a/arch/arm64/boot/dts/rockchip/rk3566-soquartz.dtsi b/arch/arm64/boot/dts/rockchip/rk3566-soquartz.dtsi index 31aa2b8efe39..63bae36b8f7e 100644 --- a/arch/arm64/boot/dts/rockchip/rk3566-soquartz.dtsi +++ b/arch/arm64/boot/dts/rockchip/rk3566-soquartz.dtsi @@ -234,7 +234,6 @@ vdd_logic: DCDC_REG1 { regulator-boot-on; regulator-min-microvolt = <500000>; regulator-max-microvolt = <1350000>; - regulator-init-microvolt = <900000>; regulator-ramp-delay = <6001>; regulator-initial-mode = <0x2>; regulator-state-mem { @@ -249,7 +248,6 @@ vdd_gpu: DCDC_REG2 { regulator-boot-on; regulator-min-microvolt = <500000>; regulator-max-microvolt = <1350000>; - regulator-init-microvolt = <900000>; regulator-ramp-delay = <6001>; regulator-initial-mode = <0x2>; regulator-state-mem { @@ -272,7 +270,6 @@ vdd_npu: DCDC_REG4 { regulator-boot-on; regulator-min-microvolt = <500000>; regulator-max-microvolt = <1350000>; - regulator-init-microvolt = <900000>; regulator-initial-mode = <0x2>; regulator-name = "vdd_npu"; regulator-state-mem { diff --git a/arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts b/arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts index ff0bf24cc1a2..f9127ddfbb7d 100644 --- a/arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts +++ b/arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts @@ -308,7 +308,6 @@ vdd_logic: DCDC_REG1 { regulator-name = "vdd_logic"; regulator-always-on; regulator-boot-on; - regulator-init-microvolt = <900000>; regulator-initial-mode = <0x2>; regulator-min-microvolt = <500000>; regulator-max-microvolt = <1350000>; @@ -322,7 +321,6 @@ regulator-state-mem { vdd_gpu: DCDC_REG2 { regulator-name = "vdd_gpu"; regulator-always-on; - regulator-init-microvolt = <900000>; regulator-initial-mode = <0x2>; regulator-min-microvolt = <500000>; regulator-max-microvolt = <1350000>; @@ -346,7 +344,6 @@ regulator-state-mem { vdd_npu: DCDC_REG4 { regulator-name = "vdd_npu"; - regulator-init-microvolt = <900000>; regulator-initial-mode = <0x2>; regulator-min-microvolt = <500000>; regulator-max-microvolt = <1350000>; diff --git a/arch/arm64/boot/dts/rockchip/rk3568-evb1-v10.dts b/arch/arm64/boot/dts/rockchip/rk3568-evb1-v10.dts index 674792567fa6..19f8fc369b13 100644 --- a/arch/arm64/boot/dts/rockchip/rk3568-evb1-v10.dts +++ b/arch/arm64/boot/dts/rockchip/rk3568-evb1-v10.dts @@ -293,7 +293,6 @@ vdd_logic: DCDC_REG1 { regulator-name = "vdd_logic"; regulator-always-on; regulator-boot-on; - regulator-init-microvolt = <900000>; regulator-initial-mode = <0x2>; regulator-min-microvolt = <500000>; regulator-max-microvolt = <1350000>; @@ -307,7 +306,6 @@ regulator-state-mem { vdd_gpu: DCDC_REG2 { regulator-name = "vdd_gpu"; regulator-always-on; - regulator-init-microvolt = <900000>; regulator-initial-mode = <0x2>; regulator-min-microvolt = <500000>; regulator-max-microvolt = <1350000>; @@ -331,7 +329,6 @@ regulator-state-mem { vdd_npu: DCDC_REG4 { regulator-name = "vdd_npu"; - regulator-init-microvolt = <900000>; regulator-initial-mode = <0x2>; regulator-min-microvolt = <500000>; regulator-max-microvolt = <1350000>; diff --git a/arch/arm64/boot/dts/rockchip/rk3568-fastrhino-r66s.dtsi b/arch/arm64/boot/dts/rockchip/rk3568-fastrhino-r66s.dtsi index 25e205632a68..89e84e3a9262 100644 --- a/arch/arm64/boot/dts/rockchip/rk3568-fastrhino-r66s.dtsi +++ b/arch/arm64/boot/dts/rockchip/rk3568-fastrhino-r66s.dtsi @@ -173,7 +173,6 @@ vdd_logic: DCDC_REG1 { regulator-name = "vdd_logic"; regulator-always-on; regulator-boot-on; - regulator-init-microvolt = <900000>; regulator-initial-mode = <0x2>; regulator-min-microvolt = <500000>; regulator-max-microvolt = <1350000>; @@ -187,7 +186,6 @@ regulator-state-mem { vdd_gpu: DCDC_REG2 { regulator-name = "vdd_gpu"; regulator-always-on; - regulator-init-microvolt = <900000>; regulator-initial-mode = <0x2>; regulator-min-microvolt = <500000>; regulator-max-microvolt = <1350000>; @@ -211,7 +209,6 @@ regulator-state-mem { vdd_npu: DCDC_REG4 { regulator-name = "vdd_npu"; - regulator-init-microvolt = <900000>; regulator-initial-mode = <0x2>; regulator-min-microvolt = <500000>; regulator-max-microvolt = <1350000>; @@ -330,7 +327,6 @@ regulator-state-mem { vcca1v8_image: LDO_REG9 { regulator-name = "vcca1v8_image"; - regulator-init-microvolt = <950000>; regulator-min-microvolt = <950000>; regulator-max-microvolt = <1800000>; diff --git a/arch/arm64/boot/dts/rockchip/rk3568-lubancat-2.dts b/arch/arm64/boot/dts/rockchip/rk3568-lubancat-2.dts index e653b067aa5d..a8a4cc190eb3 100644 --- a/arch/arm64/boot/dts/rockchip/rk3568-lubancat-2.dts +++ b/arch/arm64/boot/dts/rockchip/rk3568-lubancat-2.dts @@ -243,7 +243,6 @@ vdd_logic: DCDC_REG1 { regulator-boot-on; regulator-min-microvolt = <500000>; regulator-max-microvolt = <1350000>; - regulator-init-microvolt = <900000>; regulator-ramp-delay = <6001>; regulator-initial-mode = <0x2>; @@ -258,7 +257,6 @@ vdd_gpu: DCDC_REG2 { regulator-boot-on; regulator-min-microvolt = <500000>; regulator-max-microvolt = <1350000>; - regulator-init-microvolt = <900000>; regulator-ramp-delay = <6001>; regulator-initial-mode = <0x2>; @@ -284,7 +282,6 @@ vdd_npu: DCDC_REG4 { regulator-boot-on; regulator-min-microvolt = <500000>; regulator-max-microvolt = <1350000>; - regulator-init-microvolt = <900000>; regulator-ramp-delay = <6001>; regulator-initial-mode = <0x2>; diff --git a/arch/arm64/boot/dts/rockchip/rk3568-nanopi-r5s.dtsi b/arch/arm64/boot/dts/rockchip/rk3568-nanopi-r5s.dtsi index 58ba328ea782..93189f830640 100644 --- a/arch/arm64/boot/dts/rockchip/rk3568-nanopi-r5s.dtsi +++ b/arch/arm64/boot/dts/rockchip/rk3568-nanopi-r5s.dtsi @@ -232,7 +232,6 @@ vdd_logic: DCDC_REG1 { regulator-name = "vdd_logic"; regulator-always-on; regulator-boot-on; - regulator-init-microvolt = <900000>; regulator-initial-mode = <0x2>; regulator-min-microvolt = <500000>; regulator-max-microvolt = <1350000>; @@ -246,7 +245,6 @@ regulator-state-mem { vdd_gpu: DCDC_REG2 { regulator-name = "vdd_gpu"; regulator-always-on; - regulator-init-microvolt = <900000>; regulator-initial-mode = <0x2>; regulator-min-microvolt = <500000>; regulator-max-microvolt = <1350000>; @@ -270,7 +268,6 @@ regulator-state-mem { vdd_npu: DCDC_REG4 { regulator-name = "vdd_npu"; - regulator-init-microvolt = <900000>; regulator-initial-mode = <0x2>; regulator-min-microvolt = <500000>; regulator-max-microvolt = <1350000>; diff --git a/arch/arm64/boot/dts/rockchip/rk3568-odroid-m1.dts b/arch/arm64/boot/dts/rockchip/rk3568-odroid-m1.dts index 59ecf868dbd0..a337f547caf5 100644 --- a/arch/arm64/boot/dts/rockchip/rk3568-odroid-m1.dts +++ b/arch/arm64/boot/dts/rockchip/rk3568-odroid-m1.dts @@ -291,7 +291,6 @@ vdd_logic: DCDC_REG1 { regulator-name = "vdd_logic"; regulator-always-on; regulator-boot-on; - regulator-init-microvolt = <900000>; regulator-initial-mode = <0x2>; regulator-min-microvolt = <500000>; regulator-max-microvolt = <1350000>; @@ -305,7 +304,6 @@ regulator-state-mem { vdd_gpu: DCDC_REG2 { regulator-name = "vdd_gpu"; regulator-always-on; - regulator-init-microvolt = <900000>; regulator-initial-mode = <0x2>; regulator-min-microvolt = <500000>; regulator-max-microvolt = <1350000>; @@ -329,7 +327,6 @@ regulator-state-mem { vdd_npu: DCDC_REG4 { regulator-name = "vdd_npu"; - regulator-init-microvolt = <900000>; regulator-initial-mode = <0x2>; regulator-min-microvolt = <500000>; regulator-max-microvolt = <1350000>; diff --git a/arch/arm64/boot/dts/rockchip/rk3568-radxa-cm3i.dtsi b/arch/arm64/boot/dts/rockchip/rk3568-radxa-cm3i.dtsi index c50fbdd48680..45b03dcbbad4 100644 --- a/arch/arm64/boot/dts/rockchip/rk3568-radxa-cm3i.dtsi +++ b/arch/arm64/boot/dts/rockchip/rk3568-radxa-cm3i.dtsi @@ -163,7 +163,6 @@ vdd_logic: DCDC_REG1 { regulator-name = "vdd_logic"; regulator-always-on; regulator-boot-on; - regulator-init-microvolt = <900000>; regulator-initial-mode = <0x2>; regulator-min-microvolt = <500000>; regulator-max-microvolt = <1350000>; @@ -177,7 +176,6 @@ regulator-state-mem { vdd_gpu: DCDC_REG2 { regulator-name = "vdd_gpu"; regulator-always-on; - regulator-init-microvolt = <900000>; regulator-initial-mode = <0x2>; regulator-min-microvolt = <500000>; regulator-max-microvolt = <1350000>; @@ -201,7 +199,6 @@ regulator-state-mem { vdd_npu: DCDC_REG4 { regulator-name = "vdd_npu"; - regulator-init-microvolt = <900000>; regulator-initial-mode = <0x2>; regulator-min-microvolt = <500000>; regulator-max-microvolt = <1350000>; diff --git a/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts b/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts index 917f5b2b8aab..e05ab11981f5 100644 --- a/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts +++ b/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts @@ -350,7 +350,6 @@ vdd_logic: DCDC_REG1 { regulator-name = "vdd_logic"; regulator-always-on; regulator-boot-on; - regulator-init-microvolt = <900000>; regulator-initial-mode = <0x2>; regulator-min-microvolt = <500000>; regulator-max-microvolt = <1350000>; @@ -364,7 +363,6 @@ regulator-state-mem { vdd_gpu: DCDC_REG2 { regulator-name = "vdd_gpu"; regulator-always-on; - regulator-init-microvolt = <900000>; regulator-initial-mode = <0x2>; regulator-min-microvolt = <500000>; regulator-max-microvolt = <1350000>; @@ -388,7 +386,6 @@ regulator-state-mem { vdd_npu: DCDC_REG4 { regulator-name = "vdd_npu"; - regulator-init-microvolt = <900000>; regulator-initial-mode = <0x2>; regulator-min-microvolt = <500000>; regulator-max-microvolt = <1350000>; diff --git a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts index afda976680bc..51537030f8e3 100644 --- a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts +++ b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts @@ -337,7 +337,6 @@ vdd_vdenc_s0: vdd_vdenc_mem_s0: dcdc-reg4 { regulator-boot-on; regulator-min-microvolt = <550000>; regulator-max-microvolt = <950000>; - regulator-init-microvolt = <750000>; regulator-ramp-delay = <12500>; regulator-name = "vdd_vdenc_s0";
The 'regulator-init-microvolt' property is not currently supported by any driver, it was simply carried on from downstream kernels. The problem is also indicated by the following dtbs_check warning: rk3588-rock-5b.dtb: pmic@0: regulators:dcdc-reg4: Unevaluated properties are not allowed ('regulator-init-microvolt' was unexpected) Remove the invalid property from all affected DTS files. Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com> --- arch/arm64/boot/dts/rockchip/rk3308-roc-cc.dts | 1 - arch/arm64/boot/dts/rockchip/rk3308-rock-pi-s.dts | 1 - arch/arm64/boot/dts/rockchip/rk3399-nanopi4.dtsi | 1 - arch/arm64/boot/dts/rockchip/rk3566-anbernic-rgxx3.dtsi | 3 --- arch/arm64/boot/dts/rockchip/rk3566-lubancat-1.dts | 3 --- arch/arm64/boot/dts/rockchip/rk3566-pinenote.dtsi | 2 -- arch/arm64/boot/dts/rockchip/rk3566-quartz64-a.dts | 2 -- arch/arm64/boot/dts/rockchip/rk3566-quartz64-b.dts | 2 -- arch/arm64/boot/dts/rockchip/rk3566-roc-pc.dts | 2 -- arch/arm64/boot/dts/rockchip/rk3566-soquartz.dtsi | 3 --- arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts | 3 --- arch/arm64/boot/dts/rockchip/rk3568-evb1-v10.dts | 3 --- arch/arm64/boot/dts/rockchip/rk3568-fastrhino-r66s.dtsi | 4 ---- arch/arm64/boot/dts/rockchip/rk3568-lubancat-2.dts | 3 --- arch/arm64/boot/dts/rockchip/rk3568-nanopi-r5s.dtsi | 3 --- arch/arm64/boot/dts/rockchip/rk3568-odroid-m1.dts | 3 --- arch/arm64/boot/dts/rockchip/rk3568-radxa-cm3i.dtsi | 3 --- arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts | 3 --- arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts | 1 - 19 files changed, 46 deletions(-)