| Message ID | 20230716144612.32132-6-miquel.raynal@bootlin.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | mtd: rawnand: qcom: Misc fixes | expand |
On Sun, Jul 16, 2023 at 04:46:09PM +0200, Miquel Raynal wrote: > The main "for" loop in qcom_read_status_exec() does guard the following > to if's which are badly indented. Fix the indentation. > > Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com> Acked-by: Manivannan Sadhasivam <mani@kernel.org> - Mani > --- > drivers/mtd/nand/raw/qcom_nandc.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/mtd/nand/raw/qcom_nandc.c b/drivers/mtd/nand/raw/qcom_nandc.c > index 554cca3801da..3adc40ef5cf6 100644 > --- a/drivers/mtd/nand/raw/qcom_nandc.c > +++ b/drivers/mtd/nand/raw/qcom_nandc.c > @@ -2722,12 +2722,12 @@ static int qcom_read_status_exec(struct nand_chip *chip, > for (i = 0; i < num_cw; i++) { > flash_status = le32_to_cpu(nandc->reg_read_buf[i]); > > - if (flash_status & FS_MPU_ERR) > - host->status &= ~NAND_STATUS_WP; > + if (flash_status & FS_MPU_ERR) > + host->status &= ~NAND_STATUS_WP; > > - if (flash_status & FS_OP_ERR || > - (i == (num_cw - 1) && (flash_status & FS_DEVICE_STS_ERR))) > - host->status |= NAND_STATUS_FAIL; > + if (flash_status & FS_OP_ERR || > + (i == (num_cw - 1) && (flash_status & FS_DEVICE_STS_ERR))) > + host->status |= NAND_STATUS_FAIL; > } > > flash_status = host->status; > -- > 2.34.1 >
On 7/16/23 15:46, Miquel Raynal wrote: > The main "for" loop in qcom_read_status_exec() does guard the following > to if's which are badly indented. Fix the indentation. > > Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com> Reviewed-by: Tudor Ambarus <tudor.ambarus@linaro.org> > --- > drivers/mtd/nand/raw/qcom_nandc.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/mtd/nand/raw/qcom_nandc.c b/drivers/mtd/nand/raw/qcom_nandc.c > index 554cca3801da..3adc40ef5cf6 100644 > --- a/drivers/mtd/nand/raw/qcom_nandc.c > +++ b/drivers/mtd/nand/raw/qcom_nandc.c > @@ -2722,12 +2722,12 @@ static int qcom_read_status_exec(struct nand_chip *chip, > for (i = 0; i < num_cw; i++) { > flash_status = le32_to_cpu(nandc->reg_read_buf[i]); > > - if (flash_status & FS_MPU_ERR) > - host->status &= ~NAND_STATUS_WP; > + if (flash_status & FS_MPU_ERR) > + host->status &= ~NAND_STATUS_WP; > > - if (flash_status & FS_OP_ERR || > - (i == (num_cw - 1) && (flash_status & FS_DEVICE_STS_ERR))) > - host->status |= NAND_STATUS_FAIL; > + if (flash_status & FS_OP_ERR || > + (i == (num_cw - 1) && (flash_status & FS_DEVICE_STS_ERR))) > + host->status |= NAND_STATUS_FAIL; > } > > flash_status = host->status;
On Sun, 2023-07-16 at 14:46:09 UTC, Miquel Raynal wrote: > The main "for" loop in qcom_read_status_exec() does guard the following > to if's which are badly indented. Fix the indentation. > > Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com> > Acked-by: Manivannan Sadhasivam <mani@kernel.org> > Reviewed-by: Tudor Ambarus <tudor.ambarus@linaro.org> Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next. Miquel
diff --git a/drivers/mtd/nand/raw/qcom_nandc.c b/drivers/mtd/nand/raw/qcom_nandc.c index 554cca3801da..3adc40ef5cf6 100644 --- a/drivers/mtd/nand/raw/qcom_nandc.c +++ b/drivers/mtd/nand/raw/qcom_nandc.c @@ -2722,12 +2722,12 @@ static int qcom_read_status_exec(struct nand_chip *chip, for (i = 0; i < num_cw; i++) { flash_status = le32_to_cpu(nandc->reg_read_buf[i]); - if (flash_status & FS_MPU_ERR) - host->status &= ~NAND_STATUS_WP; + if (flash_status & FS_MPU_ERR) + host->status &= ~NAND_STATUS_WP; - if (flash_status & FS_OP_ERR || - (i == (num_cw - 1) && (flash_status & FS_DEVICE_STS_ERR))) - host->status |= NAND_STATUS_FAIL; + if (flash_status & FS_OP_ERR || + (i == (num_cw - 1) && (flash_status & FS_DEVICE_STS_ERR))) + host->status |= NAND_STATUS_FAIL; } flash_status = host->status;
The main "for" loop in qcom_read_status_exec() does guard the following to if's which are badly indented. Fix the indentation. Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com> --- drivers/mtd/nand/raw/qcom_nandc.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)