| Message ID | 20230717225610.3214029-1-robh@kernel.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | ARM: keystone: Drop unused includes | expand |
On Tue, Jul 25, 2023 at 6:35 AM Nishanth Menon <nm@ti.com> wrote: > > Hi Rob Herring, > > On Mon, 17 Jul 2023 16:56:09 -0600, Rob Herring wrote: > > Several includes are not needed, so drop them. > > > > of_platform.h is not needed, but it implicitly includes platform_device.h > > (for now) which is needed. > > > > > > I have applied the following to branch ti-keystone-next on [1]. > Thank you! > > [1/1] ARM: keystone: Drop unused includes > commit: 630c191b3396c6aaccab1234f8834848a2c42e8a Did you really? Doesn't look like this is in linux-next. Rob
On 17:28-20230822, Rob Herring wrote: > On Tue, Jul 25, 2023 at 6:35 AM Nishanth Menon <nm@ti.com> wrote: > > > > Hi Rob Herring, > > > > On Mon, 17 Jul 2023 16:56:09 -0600, Rob Herring wrote: > > > Several includes are not needed, so drop them. > > > > > > of_platform.h is not needed, but it implicitly includes platform_device.h > > > (for now) which is needed. > > > > > > > > > > I have applied the following to branch ti-keystone-next on [1]. > > Thank you! > > > > [1/1] ARM: keystone: Drop unused includes > > commit: 630c191b3396c6aaccab1234f8834848a2c42e8a > > Did you really? Doesn't look like this is in linux-next. Seems to have been there for a while? https://git.kernel.org/pub/scm/linux/kernel/git/ti/linux.git/log/?h=ti-keystone-next https://patchwork.kernel.org/project/linux-soc/patch/20230814160702.6l2fcujbx33eogap@junction/ $ git tag --contains 630c191b3396c6aaccab1234f8834848a2c42e8a next-20230801 next-20230802 next-20230804 next-20230807 next-20230808 next-20230809 next-20230816 next-20230817 next-20230818 next-20230821 next-20230822 ti-keystone-soc-for-v6.6 Did I miss something?
On Tue, Aug 22, 2023 at 6:03 PM Nishanth Menon <nm@ti.com> wrote: > > On 17:28-20230822, Rob Herring wrote: > > On Tue, Jul 25, 2023 at 6:35 AM Nishanth Menon <nm@ti.com> wrote: > > > > > > Hi Rob Herring, > > > > > > On Mon, 17 Jul 2023 16:56:09 -0600, Rob Herring wrote: > > > > Several includes are not needed, so drop them. > > > > > > > > of_platform.h is not needed, but it implicitly includes platform_device.h > > > > (for now) which is needed. > > > > > > > > > > > > > > I have applied the following to branch ti-keystone-next on [1]. > > > Thank you! > > > > > > [1/1] ARM: keystone: Drop unused includes > > > commit: 630c191b3396c6aaccab1234f8834848a2c42e8a > > > > Did you really? Doesn't look like this is in linux-next. > > Seems to have been there for a while? > > https://git.kernel.org/pub/scm/linux/kernel/git/ti/linux.git/log/?h=ti-keystone-next > > https://patchwork.kernel.org/project/linux-soc/patch/20230814160702.6l2fcujbx33eogap@junction/ > > $ git tag --contains 630c191b3396c6aaccab1234f8834848a2c42e8a > next-20230801 > next-20230802 > next-20230804 > next-20230807 > next-20230808 > next-20230809 > next-20230816 > next-20230817 > next-20230818 > next-20230821 > next-20230822 > ti-keystone-soc-for-v6.6 > > > Did I miss something? Sorry, I sent the davinci changes also with 'keystone' in the subject by mistake and confused myself... Rob
diff --git a/arch/arm/mach-keystone/keystone.c b/arch/arm/mach-keystone/keystone.c index 68039aad3014..e0ca26182e0b 100644 --- a/arch/arm/mach-keystone/keystone.c +++ b/arch/arm/mach-keystone/keystone.c @@ -7,12 +7,10 @@ * Santosh Shilimkar <santosh.shillimkar@ti.com> */ #include <linux/io.h> -#include <linux/of.h> #include <linux/dma-map-ops.h> #include <linux/init.h> -#include <linux/of_platform.h> -#include <linux/of_address.h> #include <linux/memblock.h> +#include <linux/platform_device.h> #include <asm/setup.h> #include <asm/mach/map.h>
Several includes are not needed, so drop them. of_platform.h is not needed, but it implicitly includes platform_device.h (for now) which is needed. Signed-off-by: Rob Herring <robh@kernel.org> --- arch/arm/mach-keystone/keystone.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)