| Message ID | 20230718034201.136800-3-jaewon02.kim@samsung.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v5,1/2] dt-bindings: pwm: samsung: add exynosautov9 compatible | expand |
On 18/07/2023 05:42, Jaewon Kim wrote: > Add pwm node to support fan on exynosautov9-sadk board. > PWM channel 3 of ExynosAutov9 is connected to fan for SoC cooling > in SADK board. > > Signed-off-by: Jaewon Kim <jaewon02.kim@samsung.com> > --- > arch/arm64/boot/dts/exynos/exynosautov9-sadk.dts | 6 ++++++ > arch/arm64/boot/dts/exynos/exynosautov9.dtsi | 10 ++++++++++ > 2 files changed, 16 insertions(+) > > diff --git a/arch/arm64/boot/dts/exynos/exynosautov9-sadk.dts b/arch/arm64/boot/dts/exynos/exynosautov9-sadk.dts > index 101f51bf565a..bc1815f6ada2 100644 > --- a/arch/arm64/boot/dts/exynos/exynosautov9-sadk.dts > +++ b/arch/arm64/boot/dts/exynos/exynosautov9-sadk.dts > @@ -49,6 +49,12 @@ > }; > }; > > +&pwm { > + pinctrl-names = "default"; > + pinctrl-0 = <&pwm_tout3>; > + status = "okay"; I think you miss disabling it. > +}; Best regards, Krzysztof
On 23. 7. 18. 15:06, Krzysztof Kozlowski wrote: > On 18/07/2023 05:42, Jaewon Kim wrote: >> Add pwm node to support fan on exynosautov9-sadk board. >> PWM channel 3 of ExynosAutov9 is connected to fan for SoC cooling >> in SADK board. >> >> Signed-off-by: Jaewon Kim <jaewon02.kim@samsung.com> >> --- >> arch/arm64/boot/dts/exynos/exynosautov9-sadk.dts | 6 ++++++ >> arch/arm64/boot/dts/exynos/exynosautov9.dtsi | 10 ++++++++++ >> 2 files changed, 16 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/exynos/exynosautov9-sadk.dts b/arch/arm64/boot/dts/exynos/exynosautov9-sadk.dts >> index 101f51bf565a..bc1815f6ada2 100644 >> --- a/arch/arm64/boot/dts/exynos/exynosautov9-sadk.dts >> +++ b/arch/arm64/boot/dts/exynos/exynosautov9-sadk.dts >> @@ -49,6 +49,12 @@ >> }; >> }; >> >> +&pwm { >> + pinctrl-names = "default"; >> + pinctrl-0 = <&pwm_tout3>; >> + status = "okay"; > I think you miss disabling it. Okay, I will add disable status to soc dtsi. > >> +}; > Best regards, > Krzysztof > > Thanks Jaewon Kim
diff --git a/arch/arm64/boot/dts/exynos/exynosautov9-sadk.dts b/arch/arm64/boot/dts/exynos/exynosautov9-sadk.dts index 101f51bf565a..bc1815f6ada2 100644 --- a/arch/arm64/boot/dts/exynos/exynosautov9-sadk.dts +++ b/arch/arm64/boot/dts/exynos/exynosautov9-sadk.dts @@ -49,6 +49,12 @@ }; }; +&pwm { + pinctrl-names = "default"; + pinctrl-0 = <&pwm_tout3>; + status = "okay"; +}; + &serial_0 { pinctrl-0 = <&uart0_bus_dual>; status = "okay"; diff --git a/arch/arm64/boot/dts/exynos/exynosautov9.dtsi b/arch/arm64/boot/dts/exynos/exynosautov9.dtsi index d3c5cdeff47f..3b906f4db907 100644 --- a/arch/arm64/boot/dts/exynos/exynosautov9.dtsi +++ b/arch/arm64/boot/dts/exynos/exynosautov9.dtsi @@ -1560,6 +1560,16 @@ samsung,syscon-phandle = <&pmu_system_controller>; samsung,cluster-index = <1>; }; + + pwm: pwm@103f0000 { + compatible = "samsung,exynosautov9-pwm", + "samsung,exynos4210-pwm"; + reg = <0x103f0000 0x100>; + samsung,pwm-outputs = <0>, <1>, <2>, <3>; + #pwm-cells = <3>; + clocks = <&xtcxo>; + clock-names = "timers"; + }; }; };
Add pwm node to support fan on exynosautov9-sadk board. PWM channel 3 of ExynosAutov9 is connected to fan for SoC cooling in SADK board. Signed-off-by: Jaewon Kim <jaewon02.kim@samsung.com> --- arch/arm64/boot/dts/exynos/exynosautov9-sadk.dts | 6 ++++++ arch/arm64/boot/dts/exynos/exynosautov9.dtsi | 10 ++++++++++ 2 files changed, 16 insertions(+)