diff mbox series

[v5] ARM: dts: bcm5301x: Add SEAMA compatibles

Message ID 20230722-seama-partitions-v5-1-4204e7f06ada@linaro.org (mailing list archive)
State New, archived
Headers show
Series [v5] ARM: dts: bcm5301x: Add SEAMA compatibles | expand

Commit Message

Linus Walleij July 22, 2023, 9:07 p.m. UTC
This adds SEAMA compatibles to the firmware partition of these
two D-Link devices.

Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
This type of firmware partition appear in some devices in
NAND flash, so we need to be able to tag the partitions
with the appropriate type.

The origin of the "SEAttle iMAge" is unknown.
---
Changes in v5:
- Resend just the ARM DTS change
- Link to v4: https://lore.kernel.org/r/20230713-seama-partitions-v4-0-69e577453d40@linaro.org

Changes in v4:
- Drop the false tagging of #address-cells etc
- Link to v3: https://lore.kernel.org/r/20230707-seama-partitions-v3-0-6aa9391b46bb@linaro.org

Changes in v3:
- Drop reference from partitions.yaml again
- Drop select: false
- Use unevaluatedProperties
- Link to v2: https://lore.kernel.org/r/20230705-seama-partitions-v2-0-9d349f0d5ab7@linaro.org

Changes in v2:
- Make the binding clearly childless
- Link to v1: https://lore.kernel.org/r/20230506-seama-partitions-v1-0-5806af1e4ac7@linaro.org
---
The required bindings are applied to the MTD tree.
---
 arch/arm/boot/dts/broadcom/bcm47094-dlink-dir-885l.dts | 1 +
 arch/arm/boot/dts/broadcom/bcm47094-dlink-dir-890l.dts | 1 +
 2 files changed, 2 insertions(+)


---
base-commit: 1d5653084d36db5cb55ff359bf74e8e721165bb8
change-id: 20230506-seama-partitions-b620117b9985

Best regards,

Comments

Florian Fainelli July 28, 2023, 4:12 p.m. UTC | #1
Hi Linus,

On 7/22/2023 2:07 PM, Linus Walleij wrote:
> This adds SEAMA compatibles to the firmware partition of these
> two D-Link devices.
> 
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
> This type of firmware partition appear in some devices in
> NAND flash, so we need to be able to tag the partitions
> with the appropriate type.
> 
> The origin of the "SEAttle iMAge" is unknown.

I applied v4 before by ensuring that it applied to the 
arch/arm/boot/dts/broadcom/ folder, shall I replace that commit with v5 
here?

https://github.com/Broadcom/stblinux/commit/72ec77d74d28be7359ef77971cdee38b60af9e49
Linus Walleij July 28, 2023, 6:38 p.m. UTC | #2
On Fri, Jul 28, 2023 at 6:12 PM Florian Fainelli
<florian.fainelli@broadcom.com> wrote:

> On 7/22/2023 2:07 PM, Linus Walleij wrote:
> > This adds SEAMA compatibles to the firmware partition of these
> > two D-Link devices.
> >
> > Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> > ---
> > This type of firmware partition appear in some devices in
> > NAND flash, so we need to be able to tag the partitions
> > with the appropriate type.
> >
> > The origin of the "SEAttle iMAge" is unknown.
>
> I applied v4 before by ensuring that it applied to the
> arch/arm/boot/dts/broadcom/ folder, shall I replace that commit with v5
> here?

No need, it's the same. I was just resending it.
Thanks and sorry for the confusion!

Yours,
Linus Walleij
Florian Fainelli July 28, 2023, 6:40 p.m. UTC | #3
On 7/28/23 11:38, Linus Walleij wrote:
> On Fri, Jul 28, 2023 at 6:12 PM Florian Fainelli
> <florian.fainelli@broadcom.com> wrote:
> 
>> On 7/22/2023 2:07 PM, Linus Walleij wrote:
>>> This adds SEAMA compatibles to the firmware partition of these
>>> two D-Link devices.
>>>
>>> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
>>> ---
>>> This type of firmware partition appear in some devices in
>>> NAND flash, so we need to be able to tag the partitions
>>> with the appropriate type.
>>>
>>> The origin of the "SEAttle iMAge" is unknown.
>>
>> I applied v4 before by ensuring that it applied to the
>> arch/arm/boot/dts/broadcom/ folder, shall I replace that commit with v5
>> here?
> 
> No need, it's the same. I was just resending it.
> Thanks and sorry for the confusion!

It's all good, thanks!
diff mbox series

Patch

diff --git a/arch/arm/boot/dts/broadcom/bcm47094-dlink-dir-885l.dts b/arch/arm/boot/dts/broadcom/bcm47094-dlink-dir-885l.dts
index 51ce510b3e3a..c914569ddd5e 100644
--- a/arch/arm/boot/dts/broadcom/bcm47094-dlink-dir-885l.dts
+++ b/arch/arm/boot/dts/broadcom/bcm47094-dlink-dir-885l.dts
@@ -33,6 +33,7 @@  partitions {
 				#size-cells = <1>;
 
 				partition@0 {
+					compatible = "seama";
 					label = "firmware";
 					reg = <0x00000000 0x08000000>;
 				};
diff --git a/arch/arm/boot/dts/broadcom/bcm47094-dlink-dir-890l.dts b/arch/arm/boot/dts/broadcom/bcm47094-dlink-dir-890l.dts
index 60744f82c2b7..f050acbea0b2 100644
--- a/arch/arm/boot/dts/broadcom/bcm47094-dlink-dir-890l.dts
+++ b/arch/arm/boot/dts/broadcom/bcm47094-dlink-dir-890l.dts
@@ -149,6 +149,7 @@  partitions {
 		 * partitions: this device uses SEAMA.
 		 */
 		firmware@0 {
+			compatible = "seama";
 			label = "firmware";
 			reg = <0x00000000 0x08000000>;
 		};