From patchwork Fri Jul 28 16:40:30 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Zimmermann X-Patchwork-Id: 13332582 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 133BCC001DE for ; Fri, 28 Jul 2023 18:56:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=CTlPtCl5WKv4IaGXf/OIO0xF1wj1iI6XNG19aJZzZ5o=; b=bNy47Si6ib47gm KulQUFhaUhfXKiEF/+cDQEGVq+ZJDHtKGkWp7BrpMwX9JooUJC3X//ZOAn971hW9IjbSJTwEWsk99 LMEJ8ay+Y/rzEnK8Y+Fj/yvMvWfb6yls/JYkjNfV3aNtTZfUuF15g0ohiHHvCwwm2NiJizO/1TDkK zq32mjt+lhWFIntd5M6A6iljfnV1nz1uIFlShQdVhH1hrWmeECQ7BtXOCYu64HD1uYpNY0s3b/HE/ 7mNNhh6USNQ4nvKnq0g0uRK1/KJxfVZLC+OayK/uYnRfXgSn+TtK8IHrEI88xc2oZagTXy5L4HUFj bHBgpXTxBwVDe/649W/g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qPScr-004cm7-22; Fri, 28 Jul 2023 18:55:45 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qPScq-004clq-0E; Fri, 28 Jul 2023 18:55:44 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Transfer-Encoding:MIME-Version :References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To: Content-Type:Content-ID:Content-Description; bh=amfE9iWg1zAFsDvx2Rsq1/p5noUQya/C12jHqjUtCfI=; b=ZqgjvKB+MTqtxmrDCmLsF7KXHN 3zs3fdCwLeMvd2DvuU8VkgrFuY75eIVmc+wkvPLxHtg7eqdznOqDBfMffpteAcCIRDtE5xxQpHOx6 Hn1csn8YhgGFU4GRvzv2uJocH3BmbSRMuJ++W8WvhtdU5mLyUlLPDlUdWZtZLdthC/Kxik4y9rTlV oFiVKX6RXt+z+3kQPfl8K1x8CPeKCJTNa1FZSUMYxa0Y5eCwIUSeg6Qlfd3i64Zu6ixxpl4Qy1bsn C7mmonyp4PLSjkZbOxwaEOepSzLtHT1sh6tycsOMsFvRuByzIu07zqUrrXi4UEH4oG6VCKinkk/o0 BAbIlXRA==; Received: from smtp-out2.suse.de ([2001:67c:2178:6::1d]) by desiato.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qPS6z-008Rwz-2E; Fri, 28 Jul 2023 18:22:52 +0000 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 6E5D21F8C8; Fri, 28 Jul 2023 18:22:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1690568567; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=amfE9iWg1zAFsDvx2Rsq1/p5noUQya/C12jHqjUtCfI=; b=QEIaAnEF6X01KWmUDhIQlelBR1uA8eMjI+wxeuYew7uKNi77VrcSwF6NAfjYvOvVWYxv+n 5T86KSZNo+J3n5dW0l4aShd3jZpmby2DxNQCTG4aoar/o/DxtfKusymxS4IcLsnbdyTOYu fR3If2zAvC83RFXg659mbSwQMw0WcVM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1690568567; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=amfE9iWg1zAFsDvx2Rsq1/p5noUQya/C12jHqjUtCfI=; b=czjAetp6s/ZazJVEMj5Plcg9px+Qo7fn2blFfyl6eIYGEhYbqWyLlZ+8OvmX51UnovZoz0 ZyFuDbme8q6UOlCQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 2F055139BD; Fri, 28 Jul 2023 18:22:47 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id eB93CncHxGQ3CwAAMHmgww (envelope-from ); Fri, 28 Jul 2023 18:22:47 +0000 From: Thomas Zimmermann To: deller@gmx.de, javierm@redhat.com, sam@ravnborg.org Cc: linux-media@vger.kernel.org, linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-geode@lists.infradead.org, linux-omap@vger.kernel.org, kvm@vger.kernel.org, Thomas Zimmermann , Kirti Wankhede Subject: [PATCH 47/47] vfio-dev/mdpy-fb: Use fbdev I/O helpers Date: Fri, 28 Jul 2023 18:40:30 +0200 Message-ID: <20230728182234.10680-48-tzimmermann@suse.de> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230728182234.10680-1-tzimmermann@suse.de> References: <20230728182234.10680-1-tzimmermann@suse.de> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230728_192250_535267_8DDFC882 X-CRM114-Status: GOOD ( 10.99 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Set struct fb_ops and with FB_DEFAULT_IO_OPS, fbdev's initializer for I/O memory. Sets the callbacks to the cfb_ and fb_io_ functions. Select the correct modules with Kconfig's FB_IO_HELPERS token. The macro and token set the currently selected values, so there is no functional change. Signed-off-by: Thomas Zimmermann Cc: Kirti Wankhede --- samples/Kconfig | 4 +--- samples/vfio-mdev/mdpy-fb.c | 4 +--- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/samples/Kconfig b/samples/Kconfig index bf49ed0d7362..44b4d8569015 100644 --- a/samples/Kconfig +++ b/samples/Kconfig @@ -210,9 +210,7 @@ config SAMPLE_VFIO_MDEV_MDPY config SAMPLE_VFIO_MDEV_MDPY_FB tristate "Build VFIO mdpy example guest fbdev driver" depends on FB - select FB_CFB_FILLRECT - select FB_CFB_COPYAREA - select FB_CFB_IMAGEBLIT + select FB_IO_HELPERS help Guest fbdev driver for the virtual display sample driver. diff --git a/samples/vfio-mdev/mdpy-fb.c b/samples/vfio-mdev/mdpy-fb.c index cda477b28685..78140c755bed 100644 --- a/samples/vfio-mdev/mdpy-fb.c +++ b/samples/vfio-mdev/mdpy-fb.c @@ -88,11 +88,9 @@ static void mdpy_fb_destroy(struct fb_info *info) static const struct fb_ops mdpy_fb_ops = { .owner = THIS_MODULE, + FB_DEFAULT_IO_OPS, .fb_destroy = mdpy_fb_destroy, .fb_setcolreg = mdpy_fb_setcolreg, - .fb_fillrect = cfb_fillrect, - .fb_copyarea = cfb_copyarea, - .fb_imageblit = cfb_imageblit, }; static int mdpy_fb_probe(struct pci_dev *pdev,