From patchwork Tue Aug 1 10:13:42 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Zimmermann X-Patchwork-Id: 13336399 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 59DEBEB64DD for ; Tue, 1 Aug 2023 10:18:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=GY2tC5C2ei4TSfdM6qNKn3Iffh3vfpE99jjTf365n7s=; b=bImZ0/gkdWJn/u KV3mK/QRsgfEr6GPixsDgx4CT9NIS9JOb04Fh/fnmWCzgdFf/cc52U8qAXAcs0wZ+odkJwG0rSPGM IBqIs/F0GUGgg6x6HW/Iw7iCtxy4kZjR96o1W9AAgFjxCN6oaDOc0tN4KQFeehb0Cx180a1Yh+M0e ali1GE4PajiTwrU6+MWBFLNd3MXIP2Z4SuZowlShfGdsiZlaOIOsXqD8cbCo2dlXJ/NF7w7bW76zm miL1tEPEa4O5yMamMyx9Z+5wTQBnKEkCtsqPhwuH1jqk1R9DHoYjUmEXdYrQ7ws0q/CX3hehPL1kr jFIZaacuMytOx4SNpr+Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qQmRk-001oKh-0U; Tue, 01 Aug 2023 10:17:44 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qQmQ7-001m3Q-2V; Tue, 01 Aug 2023 10:16:03 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To: Content-Type:Content-ID:Content-Description; bh=Fp/ZPA36v6byDNUedCZECtV4++9yBYCp6bOC6L73SqY=; b=nQcbEA5ZO0ccqtBQ307soA2LoR DzpAN3l+DGuh0/sP7u2dZAhLDZ4dRwTLTLREE1JG0svXUqnNZVfeCRi1R8BOeKb6B4yMobKx4piF6 frUmg5m3u8KHhaxBUML0rR24fPQBVZoJ3CvgLE6LaX9nWRNiC7RNXMtMm1annHVJqiaEmmivlPc5z +vWFRmDb3X0tuO8UcuSBWO8xdsAeUCoHrCLYC2B7NAS9JIgSg1pv9zwWJhr2ojXmxawGCSt0PuLum ApByJY1DsIpymvBSvgV7w/ye1nk75fjaNtvLr+3EhRWGm9mO+y4ILqX981054zKQhXcOuXPMnipFe fXFkY3xQ==; Received: from smtp-out1.suse.de ([2001:67c:2178:6::1c]) by casper.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1qQmQ4-007wBv-03; Tue, 01 Aug 2023 10:16:02 +0000 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 9103421E50; Tue, 1 Aug 2023 10:15:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1690884956; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Fp/ZPA36v6byDNUedCZECtV4++9yBYCp6bOC6L73SqY=; b=I4TILnhbrIvvYdddhrD/ctI5jJfdWOblN/vVoJaWKaAy0SeiIC6MejVcxYsCJyQckeNf4h aG9p+DtbePwaOIZCH1iJ6XzxLQJ7aQSdNLzdWpqIP2SH4yXMaA/vJ389s8uERX6tcPgauK 1Lf+x+61JJmHb0EIcJNUX4tZZZX3n6g= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1690884956; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Fp/ZPA36v6byDNUedCZECtV4++9yBYCp6bOC6L73SqY=; b=2/4oQiaN3jMZGlrc1i4kf6lTwFEJxwbZuD1suaX/NSFxHV6fSsoEOXuMjXyDGkVwlovH1d xvqmJ0D9hfCQfcDw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 54981139BD; Tue, 1 Aug 2023 10:15:56 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id OO7AE1zbyGQBXQAAMHmgww (envelope-from ); Tue, 01 Aug 2023 10:15:56 +0000 From: Thomas Zimmermann To: deller@gmx.de, javierm@redhat.com, sam@ravnborg.org Cc: linux-media@vger.kernel.org, linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-geode@lists.infradead.org, linux-omap@vger.kernel.org, kvm@vger.kernel.org, Thomas Zimmermann , Jingoo Han Subject: [PATCH v2 37/47] fbdev/s3cfb: Use fbdev I/O helpers Date: Tue, 1 Aug 2023 12:13:42 +0200 Message-ID: <20230801101541.900-38-tzimmermann@suse.de> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230801101541.900-1-tzimmermann@suse.de> References: <20230801101541.900-1-tzimmermann@suse.de> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230801_111600_206388_1D9596A5 X-CRM114-Status: GOOD ( 12.68 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Set struct fb_ops and with FB_DEFAULT_IO_OPS, fbdev's initializer for I/O memory. Sets the callbacks to the cfb_ and fb_io_ functions. Select the correct modules with Kconfig's FB_IO_HELPERS token. The macro and token set the currently selected values, so there is no functional change. v2: * updated to use _IOMEM_ tokens Signed-off-by: Thomas Zimmermann Reviewed-by: Sam Ravnborg Acked-by: Helge Deller Cc: Jingoo Han --- drivers/video/fbdev/Kconfig | 4 +--- drivers/video/fbdev/s3c-fb.c | 4 +--- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig index 4986586c63b0..71766639c542 100644 --- a/drivers/video/fbdev/Kconfig +++ b/drivers/video/fbdev/Kconfig @@ -1653,9 +1653,7 @@ config FB_S3C tristate "Samsung S3C framebuffer support" depends on FB && HAVE_CLK && HAS_IOMEM depends on ARCH_S3C64XX || COMPILE_TEST - select FB_CFB_FILLRECT - select FB_CFB_COPYAREA - select FB_CFB_IMAGEBLIT + select FB_IOMEM_HELPERS help Frame buffer driver for the built-in FB controller in the Samsung SoC line such as the S3C6400 and S3C6410. diff --git a/drivers/video/fbdev/s3c-fb.c b/drivers/video/fbdev/s3c-fb.c index c50b92c06c5d..2b85aad6a304 100644 --- a/drivers/video/fbdev/s3c-fb.c +++ b/drivers/video/fbdev/s3c-fb.c @@ -1038,13 +1038,11 @@ static int s3c_fb_ioctl(struct fb_info *info, unsigned int cmd, static const struct fb_ops s3c_fb_ops = { .owner = THIS_MODULE, + FB_DEFAULT_IOMEM_OPS, .fb_check_var = s3c_fb_check_var, .fb_set_par = s3c_fb_set_par, .fb_blank = s3c_fb_blank, .fb_setcolreg = s3c_fb_setcolreg, - .fb_fillrect = cfb_fillrect, - .fb_copyarea = cfb_copyarea, - .fb_imageblit = cfb_imageblit, .fb_pan_display = s3c_fb_pan_display, .fb_ioctl = s3c_fb_ioctl, };