From patchwork Tue Aug 1 10:13:44 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Zimmermann X-Patchwork-Id: 13336405 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5A978C001E0 for ; Tue, 1 Aug 2023 10:18:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=mz1RrvshY1IaslwpoCSojZbVqgbT2aOlPKY+err5HBo=; b=qJnfJZ4nXCOFg+ BQ9OH9LRnerVrVrr2H1f+Tu6DtRWOLPLTlmZL/KyLAsIujygdSyN9L2U12KdvBLAREbjcSPbaacsE Gwv4XWhz1YWrG5aWEgWOdEkg+ekKiT+mD9cGasKl87YpDBazwzBF29HztsrB5cfi1XzH0MxnVjrj1 RxLpl7eTl62TO7Kl4j7n3duDshyKPz3cVDkwmvvXLjTyq8oukkWHhtyKzsw8O51GgheiW0QdeULU4 h/BglQoB9q5YCfw/zv1KJ9zUzJ4nlM1yvvl0fqjlmV7kzgAolrII3wK5cMoYufK82KyOfHpDrtX7A qGGuDy5bULYUvZxZ+s1w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qQmS7-001op7-13; Tue, 01 Aug 2023 10:18:07 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qQmQ9-001m50-17; Tue, 01 Aug 2023 10:16:05 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Transfer-Encoding:MIME-Version :References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To: Content-Type:Content-ID:Content-Description; bh=D7qgfKO77ZgQLJLOkb0OMbIaTd3uu/JfkKUZeWBTbyY=; b=olT5HKfuAA58Q2qZjhayldv2Z4 fHZIuk6WO9fHH6y4lXaYf+8HcCLBF121VSPNiFRLm90bv8pA09Bympxik+SeyrqXAwgzGrZK3Z4CF ZFHxX8Nl6MqE2kbWNhHwmMAoAopnCoUs5TRXvR3macFvRbZ4Zqmm+ONI5qACYHdWEdhSRW9e+VLBn zI5TO6h4oNdp+MzsefZACHUtRo7DsqHLOLrp1dZDNM5OtOYKehYD9zKGO145Ir90f6boXfVvSGBzp f7hf/Jhb0CLrXdX1UREhESCqN+NHkIC0kNjO9Mr4DmZmpZVr3OySBppldJR6mELgXPp940VJ0KpJv EIeOYT/A==; Received: from smtp-out1.suse.de ([2001:67c:2178:6::1c]) by desiato.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qQmQ4-00EGha-1z; Tue, 01 Aug 2023 10:16:03 +0000 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 15B8521E51; Tue, 1 Aug 2023 10:15:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1690884957; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=D7qgfKO77ZgQLJLOkb0OMbIaTd3uu/JfkKUZeWBTbyY=; b=fhWTZ2iVfzXBbNGgnhhanV3X1jbEhqXJp5OF1ywGCzux5Zxj63es8IChfiB82MYL/SlZw5 lQ55CZb+uUtNT0+HVnp1cFiVaj5AL6Mq/KzRWkoCXF9pcA9VFMAeusfkFmttJ0CPyqb2xJ rAG2qur47njDWgIM8EDOGwM00EKBacA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1690884957; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=D7qgfKO77ZgQLJLOkb0OMbIaTd3uu/JfkKUZeWBTbyY=; b=R+s6ED7lCg/8rmXeJKBY0Hci1T7snUCXbI/BcEZu4e1u0NCOCQm6TemU/5Xg27nF2sVqdQ X0IgZzpaB+hkMbAg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id CF3F0139BD; Tue, 1 Aug 2023 10:15:56 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id +HjBMVzbyGQBXQAAMHmgww (envelope-from ); Tue, 01 Aug 2023 10:15:56 +0000 From: Thomas Zimmermann To: deller@gmx.de, javierm@redhat.com, sam@ravnborg.org Cc: linux-media@vger.kernel.org, linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-geode@lists.infradead.org, linux-omap@vger.kernel.org, kvm@vger.kernel.org, Thomas Zimmermann , Hans de Goede Subject: [PATCH v2 39/47] fbdev/simplefb: Use fbdev I/O helpers Date: Tue, 1 Aug 2023 12:13:44 +0200 Message-ID: <20230801101541.900-40-tzimmermann@suse.de> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230801101541.900-1-tzimmermann@suse.de> References: <20230801101541.900-1-tzimmermann@suse.de> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230801_111600_807311_184A30B5 X-CRM114-Status: GOOD ( 12.73 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Set struct fb_ops and with FB_DEFAULT_IO_OPS, fbdev's initializer for I/O memory. Sets the callbacks to the cfb_ and fb_io_ functions. Select the correct modules with Kconfig's FB_IO_HELPERS token. The macro and token set the currently selected values, so there is no functional change. v2: * updated to use _IOMEM_ tokens Signed-off-by: Thomas Zimmermann Reviewed-by: Sam Ravnborg Acked-by: Helge Deller Cc: Hans de Goede --- drivers/video/fbdev/Kconfig | 4 +--- drivers/video/fbdev/simplefb.c | 4 +--- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig index cea3e00badcd..9b11a394bd82 100644 --- a/drivers/video/fbdev/Kconfig +++ b/drivers/video/fbdev/Kconfig @@ -1939,9 +1939,7 @@ config FB_SIMPLE depends on FB depends on !DRM_SIMPLEDRM select APERTURE_HELPERS - select FB_CFB_FILLRECT - select FB_CFB_COPYAREA - select FB_CFB_IMAGEBLIT + select FB_IOMEM_HELPERS help Say Y if you want support for a simple frame-buffer. diff --git a/drivers/video/fbdev/simplefb.c b/drivers/video/fbdev/simplefb.c index 461e50c8dd1b..62f99f6fccd3 100644 --- a/drivers/video/fbdev/simplefb.c +++ b/drivers/video/fbdev/simplefb.c @@ -109,11 +109,9 @@ static void simplefb_destroy(struct fb_info *info) static const struct fb_ops simplefb_ops = { .owner = THIS_MODULE, + FB_DEFAULT_IOMEM_OPS, .fb_destroy = simplefb_destroy, .fb_setcolreg = simplefb_setcolreg, - .fb_fillrect = cfb_fillrect, - .fb_copyarea = cfb_copyarea, - .fb_imageblit = cfb_imageblit, }; static struct simplefb_format simplefb_formats[] = SIMPLEFB_FORMATS;