From patchwork Fri Aug 4 03:53:43 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jinjie Ruan X-Patchwork-Id: 13341229 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3051CC04A94 for ; Fri, 4 Aug 2023 03:55:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:To:From:Reply-To:Cc:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=O2dwxpBhg5E3+5B+noFgI7Db/kr4jtg7IaMJ2ubcYAg=; b=1ebMMY9+T8MfMc KFLuOuf7mf5swKu4p4ATeyk/kSHIx2YIplbFOKNzABFi/iOnMeTlzdfU3f/heyOFTXV++ad9lZke7 u8EkA5lSPUFp2sAmD4VsJHG628o9oXs9xcYQgiwc+dOL7dHG3xwY1pUE1c1FFiYNH75iOSQ6NxToz 2HSQcg96BQfxw6cCyAnG2asuA87NO0VeMtiXCzb6i7UfCJUEu9c0eobynUemXtGw9r1FPBUXMNwWM LdFpI5zEFtdJ9hVEAkIreTHKbCWEJUhJDW2GTHxygsvYvZ2QrsqZhP0x1bzFBV0ZW2CFHgEgXSg8n XZeSAad/ges9pDgPwSSA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qRltv-00BU6n-1n; Fri, 04 Aug 2023 03:54:55 +0000 Received: from szxga01-in.huawei.com ([45.249.212.187]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qRltq-00BU2W-1W for linux-arm-kernel@lists.infradead.org; Fri, 04 Aug 2023 03:54:52 +0000 Received: from kwepemi500008.china.huawei.com (unknown [172.30.72.55]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4RHBdr2xFszrS75; Fri, 4 Aug 2023 11:53:36 +0800 (CST) Received: from huawei.com (10.90.53.73) by kwepemi500008.china.huawei.com (7.221.188.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Fri, 4 Aug 2023 11:54:40 +0800 From: Ruan Jinjie To: , , , , , , , , , , , , , , , , , , , , , , , , , , , Subject: [PATCH -next 3/6] net/mlx4: Remove an unnecessary ternary operator Date: Fri, 4 Aug 2023 11:53:43 +0800 Message-ID: <20230804035346.2879318-4-ruanjinjie@huawei.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230804035346.2879318-1-ruanjinjie@huawei.com> References: <20230804035346.2879318-1-ruanjinjie@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.90.53.73] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To kwepemi500008.china.huawei.com (7.221.188.139) X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230803_205450_678700_CC8CEFD1 X-CRM114-Status: UNSURE ( 8.95 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org There is a ternary operator, the true or false judgement of which is unnecessary in C language semantics. Signed-off-by: Ruan Jinjie --- drivers/net/ethernet/mellanox/mlx4/port.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/mellanox/mlx4/port.c b/drivers/net/ethernet/mellanox/mlx4/port.c index 256a06b3c096..1c289488d050 100644 --- a/drivers/net/ethernet/mellanox/mlx4/port.c +++ b/drivers/net/ethernet/mellanox/mlx4/port.c @@ -176,7 +176,7 @@ static bool mlx4_need_mf_bond(struct mlx4_dev *dev) mlx4_foreach_port(i, dev, MLX4_PORT_TYPE_ETH) ++num_eth_ports; - return (num_eth_ports == 2) ? true : false; + return num_eth_ports == 2; } int __mlx4_register_mac(struct mlx4_dev *dev, u8 port, u64 mac)