From patchwork Mon Aug 7 12:43:38 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frank Oltmanns X-Patchwork-Id: 13344125 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 46ED6C001B0 for ; Mon, 7 Aug 2023 12:44:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=f+U1EUANYDIBplhvABYFc0wy/aS1AFmbfzoASkZoDLg=; b=QPUQ8BUqEJ7L8n HS48TXIKuBnlBh0b2U5N8PqLd1k9RetlKopp54rc+ghhzjkds0PXVgbwWwv+FOwa3QlRqoB5fOpv5 FryuVLWM3IEIXZ92928pHvRHITsJyk4RxacVFQJgeOolNW5qdIp7W3YGBP744PHggWKhf/ecO234S IYWQyZZz3vqNGpPsQSOP8Os4cSDHPBV4hxDdko6TQaqTe7xgT+0eVVT3mGZL/g53s0zw246lYr9N0 gdq+P4Ve+w5HvX+IsnKs+6koS56suy6AZTsjt5gF32jQC0/dzsfpbNM96EbmK56JFvXHQb+7sR8HL qwoOzb16XTJRx6dv8uyg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qSzat-00HFmb-1U; Mon, 07 Aug 2023 12:44:19 +0000 Received: from mout-p-202.mailbox.org ([2001:67c:2050:0:465::202]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qSzao-00HFjb-0i for linux-arm-kernel@lists.infradead.org; Mon, 07 Aug 2023 12:44:15 +0000 Received: from smtp1.mailbox.org (smtp1.mailbox.org [IPv6:2001:67c:2050:b231:465::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-202.mailbox.org (Postfix) with ESMTPS id 4RKGGg2jgtz9sbF; Mon, 7 Aug 2023 14:44:11 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oltmanns.dev; s=MBO0001; t=1691412251; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7S6C5RiSumrJfz42U1M/i1EZIbkB/8kA+J3OWBudPh0=; b=mxX90osoghfcoNAkh7pt+Q3K/V5cbYvVVLIGr/gPOalFU5UlXbbSVazySe0pVlKhrtVpLB XDSoLhFTVctlrfLfFtzvbuj7lXhuXyZbIlwaLN9NDlcDBQFAVXV6QdnrDG5fUzYW5WZe08 xhwZXIZlD4asy+Sz1c1O/YFTyufY5vkGhHY8ryRFYQrG2qoLtCAZgYr0ZFZZFTeQmnx5fa 2PCtdO2gg1UB4qAt7MTFFOUcBs3f0W8Vi40Q+n3jOTL8y1Xdp/KXL3RlRIEuknuNLKKb3z f8oMiA4ukYn+6iTos7KcsYbpOkVZaanBCRYJMzfpFazI8dgEsin+yiq22eiKTA== From: Frank Oltmanns Date: Mon, 07 Aug 2023 14:43:38 +0200 Subject: [PATCH v6 05/11] clk: sunxi-ng: Add helper function to find closest rate MIME-Version: 1.0 Message-Id: <20230807-pll-mipi_set_rate_parent-v6-5-f173239a4b59@oltmanns.dev> References: <20230807-pll-mipi_set_rate_parent-v6-0-f173239a4b59@oltmanns.dev> In-Reply-To: <20230807-pll-mipi_set_rate_parent-v6-0-f173239a4b59@oltmanns.dev> To: Maxime Ripard , Michael Turquette , Stephen Boyd , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Andre Przywara , Roman Beranek Cc: linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, Frank Oltmanns X-Developer-Signature: v=1; a=openpgp-sha256; l=2110; i=frank@oltmanns.dev; h=from:subject:message-id; bh=GNz6YFitptd/iU8xYw3UneQLsMtDUEwC7Tg8y73qcgg=; b=owEB7QES/pANAwAIAZppogiUStPHAcsmYgBk0OcKJH/KZtB8NiUE9YPrjmIq0Yfi4KAlgUVWK vYSXi6ILbyJAbMEAAEIAB0WIQQC/SV7f5DmuaVET5aaaaIIlErTxwUCZNDnCgAKCRCaaaIIlErT x+czDACS1qQUFTkA+fXSqlWeYYcYXJMNNT+MBRXjQX4wyMvsNUoPl94gTdVpG085tWfFhY2uWY/ 92iw9E++jfBc5ru8JUJ8iG5AKEUB9YMMpebC+R4YFYuIaowcTPficLov3ysOwJ75qeGJMIhemIp ZpoCvzVV2RtLsljO0yxdYRcacOQOALMkfh+k1fQ3Wwf5bx6hcwZd8Wc1ON9ggNmjTxaj9oXthXG pLF3awM7aiC/fcxsMDDM9VOwflw2mIJG7ZzYq352t9KGKQGCyxJB0pnxot5Ul1mXnUTT6Gpm6Le TZNdTYtcVYFOT+9j1L8ACGa0vU23/CcKyoNKSnT7iJXLbRqMnv0/wOWzOjohrit2eJoxxes88vo A/c39ja4ItA+VQMFGddj+G7Nc6jnqpug9fsx0nj7vmasd5mqaij6e06jkFkH5LFphq0PG3zlChR jORG2gX8aoYc/6BwWdy3O3uigqLj7sqTCoAMp75uPLCZC4YPClf+6OJAJmFEMeOpqIc88= X-Developer-Key: i=frank@oltmanns.dev; a=openpgp; fpr=02FD257B7F90E6B9A5444F969A69A208944AD3C7 X-Rspamd-Queue-Id: 4RKGGg2jgtz9sbF X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230807_054414_402910_585502C2 X-CRM114-Status: GOOD ( 11.88 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The default behaviour of clocks in the sunxi-ng driver is to select a clock rate that is closest to but less than the requested rate. Add the ccu_is_better_rate() helper function that - depending on the fact if thc CCU_FEATURE_CLOSEST_RATE flag is set - decides if a rate is closer than another rate. Acked-by: Maxime Ripard Reviewed-by: Jernej Skrabec Signed-off-by: Frank Oltmanns --- drivers/clk/sunxi-ng/ccu_common.c | 12 ++++++++++++ drivers/clk/sunxi-ng/ccu_common.h | 5 +++++ 2 files changed, 17 insertions(+) diff --git a/drivers/clk/sunxi-ng/ccu_common.c b/drivers/clk/sunxi-ng/ccu_common.c index 8d28a7a079d0..8babce55302f 100644 --- a/drivers/clk/sunxi-ng/ccu_common.c +++ b/drivers/clk/sunxi-ng/ccu_common.c @@ -39,6 +39,18 @@ void ccu_helper_wait_for_lock(struct ccu_common *common, u32 lock) } EXPORT_SYMBOL_NS_GPL(ccu_helper_wait_for_lock, SUNXI_CCU); +bool ccu_is_better_rate(struct ccu_common *common, + unsigned long target_rate, + unsigned long current_rate, + unsigned long best_rate) +{ + if (common->features & CCU_FEATURE_CLOSEST_RATE) + return abs(current_rate - target_rate) < abs(best_rate - target_rate); + + return current_rate <= target_rate && current_rate > best_rate; +} +EXPORT_SYMBOL_NS_GPL(ccu_is_better_rate, SUNXI_CCU); + /* * This clock notifier is called when the frequency of a PLL clock is * changed. In common PLL designs, changes to the dividers take effect diff --git a/drivers/clk/sunxi-ng/ccu_common.h b/drivers/clk/sunxi-ng/ccu_common.h index 5ad219f041d5..942a72c09437 100644 --- a/drivers/clk/sunxi-ng/ccu_common.h +++ b/drivers/clk/sunxi-ng/ccu_common.h @@ -53,6 +53,11 @@ struct sunxi_ccu_desc { void ccu_helper_wait_for_lock(struct ccu_common *common, u32 lock); +bool ccu_is_better_rate(struct ccu_common *common, + unsigned long target_rate, + unsigned long current_rate, + unsigned long best_rate); + struct ccu_pll_nb { struct notifier_block clk_nb; struct ccu_common *common;