From patchwork Thu Aug 10 03:46:41 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jinjie Ruan X-Patchwork-Id: 13348745 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 26F32C001DB for ; Thu, 10 Aug 2023 03:48:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:CC:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=TPHR17hxqmDwNqYeOLIIkM6L7RrQilg5zMicGqtoee4=; b=Ype6BpIlAxlBOA DV2uMOJCdq4yMlA4CSrRy/sXOuUbZmr0V04r9xEjh/d/yY1kkCh85zYvs8fhtrS2gW5rBJQp09Kxr dhxBpO86/cdR3IyJV0r7ZvmpLeuWBNQWFTPv/pXznXefbJmhbWjiItW1gqSOxE0SAw54Bz4VFA8tf pXagzJs9xaK9umIP5j2pA8zYkdCbFjQ/jz1pDkZExEA/tWfk//IS4SUc6X9ml3agf7VKx40/t2BWY 7FHf+tM+HjlWISN5h1U/7ic7ZNq6MoLVGLMbKTk4P/udBRcmxu0UdgWYqvZIYWIOJtfA5/ti6t3N3 0WP1jgQyATPFeNKAuZvw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qTweD-006RMm-0F; Thu, 10 Aug 2023 03:47:41 +0000 Received: from szxga02-in.huawei.com ([45.249.212.188]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qTwe4-006RJ9-1Q for linux-arm-kernel@lists.infradead.org; Thu, 10 Aug 2023 03:47:33 +0000 Received: from kwepemi500008.china.huawei.com (unknown [172.30.72.55]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4RLt7s11SBzNmsD; Thu, 10 Aug 2023 11:43:53 +0800 (CST) Received: from huawei.com (10.90.53.73) by kwepemi500008.china.huawei.com (7.221.188.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Thu, 10 Aug 2023 11:47:21 +0800 From: Ruan Jinjie To: , , , , , , , , , CC: Subject: [PATCH -next v2 2/2] media: nxp: Remove a redundant dev_err() for platform_get_irq() Date: Thu, 10 Aug 2023 11:46:41 +0800 Message-ID: <20230810034641.1384352-3-ruanjinjie@huawei.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230810034641.1384352-1-ruanjinjie@huawei.com> References: <20230810034641.1384352-1-ruanjinjie@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.90.53.73] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To kwepemi500008.china.huawei.com (7.221.188.139) X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230809_204732_650686_A7B00072 X-CRM114-Status: GOOD ( 10.44 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org There is no need to call the dev_err() function directly to print a custom message when handling an error from platform_get_irq() function as it is going to display an appropriate error message in case of a failure. Signed-off-by: Ruan Jinjie Reviewed-by: Laurent Pinchart Reviewed-by: Mirela Rabulea --- v2: - Update the commit title. - Split into 2 patches. --- drivers/media/platform/nxp/imx8-isi/imx8-isi-pipe.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/media/platform/nxp/imx8-isi/imx8-isi-pipe.c b/drivers/media/platform/nxp/imx8-isi/imx8-isi-pipe.c index c4454aa1cb34..65d20e9bae69 100644 --- a/drivers/media/platform/nxp/imx8-isi/imx8-isi-pipe.c +++ b/drivers/media/platform/nxp/imx8-isi/imx8-isi-pipe.c @@ -791,7 +791,6 @@ int mxc_isi_pipe_init(struct mxc_isi_dev *isi, unsigned int id) irq = platform_get_irq(to_platform_device(isi->dev), id); if (irq < 0) { - dev_err(pipe->isi->dev, "Failed to get IRQ (%d)\n", irq); ret = irq; goto error; }