From patchwork Tue Aug 15 15:27:08 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Amit Singh Tomar X-Patchwork-Id: 13353922 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 67DF4C001DB for ; Tue, 15 Aug 2023 15:29:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:CC:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=lPDDr5yoyln9V1xWlkO15wjS/YXHW7dbVokYuBXj+5o=; b=evtxhLPq0zWuIn lrTN0biiyQWZLrHYI9J3DyCCXZ/aWJS/LeFdCcmM5f9Rmr7Gbmvb1QcTttBxQl7o0UBdF9U/kuAe+ P/dnWlmMPY23NaaRxKLUCtvP/3/c/BQPBaKURAEYJntizTfGM6AMC69NeiN6ZNcCObST3c3oqh9tx l1aRHlh+Cqs/miF0CuOdJ5odVHDOqc3AjRj/7PJsC+PkxqCBsRCb2IeBUyMG4NJnpn/j01lZHqWwv thfU/q+Vg3GxsIVF7mtyHXM6HdnjIIvuqP1AgdUu7AcZMELrCzQMjYIlp1ixSplg2AissXXpW/3IE weiBoAjJzlcgxN2kJSsQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qVvyK-001rSC-0U; Tue, 15 Aug 2023 15:28:40 +0000 Received: from mx0a-0016f401.pphosted.com ([67.231.148.174] helo=mx0b-0016f401.pphosted.com) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qVvxz-001rHz-2i for linux-arm-kernel@lists.infradead.org; Tue, 15 Aug 2023 15:28:21 +0000 Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 37FEGDav009581; Tue, 15 Aug 2023 08:28:09 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-transfer-encoding : content-type; s=pfpt0220; bh=asH4VG1rGKa6TkvnGN1MYErwMVnT8I4Q1dhZqaGW3dU=; b=g2Ii2jy5x61i2oHXlwBBc9VBl7svxA5Sn1n9uRk+QvGBjwuF5l5kuFlbTaA/LMqM7y5/ xF3n4DiQqsLkaTjVzA+NgIxyXcu8VYIQ7Skmx19YLoP8c02I9NPq/azc/qJXN9m4gK15 +2U9AKt+MQbGNkJ6mwTGcI06/5sMdE6Lvy3Ej+RAeJDcsYt4eyzXPBdncNaj991p5WEh FHoV9oTBMbnbLqGrgPuIyF4BbGxsCubxnRnrEIyf2R2WGxtBOAMfk7diwvj4csKX1cV5 Ufaj9Z6y9SAov93MXd7iOx0DdJqCiuvJuaeR7l5PdtPya+QT6fngpFp5D1WzMEwiwgmH +g== Received: from dc5-exch01.marvell.com ([199.233.59.181]) by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 3sgaydr8ag-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Tue, 15 Aug 2023 08:28:09 -0700 Received: from DC5-EXCH02.marvell.com (10.69.176.39) by DC5-EXCH01.marvell.com (10.69.176.38) with Microsoft SMTP Server (TLS) id 15.0.1497.48; Tue, 15 Aug 2023 08:28:07 -0700 Received: from maili.marvell.com (10.69.176.80) by DC5-EXCH02.marvell.com (10.69.176.39) with Microsoft SMTP Server id 15.0.1497.48 via Frontend Transport; Tue, 15 Aug 2023 08:28:07 -0700 Received: from localhost.localdomain (unknown [10.28.36.167]) by maili.marvell.com (Postfix) with ESMTP id 838203F7063; Tue, 15 Aug 2023 08:28:04 -0700 (PDT) From: Amit Singh Tomar To: , CC: , , , , , , Amit Singh Tomar Subject: [RFC 08/12] fs/resctrl: Schemata write only for intended resource Date: Tue, 15 Aug 2023 20:57:08 +0530 Message-ID: <20230815152712.1760046-9-amitsinght@marvell.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230815152712.1760046-1-amitsinght@marvell.com> References: <20230815152712.1760046-1-amitsinght@marvell.com> MIME-Version: 1.0 X-Proofpoint-GUID: cKQIw9HIp8d4U9z8Dm66O8f6HbV9_9Br X-Proofpoint-ORIG-GUID: cKQIw9HIp8d4U9z8Dm66O8f6HbV9_9Br X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.267,Aquarius:18.0.957,Hydra:6.0.601,FMLib:17.11.176.26 definitions=2023-08-15_16,2023-08-15_02,2023-05-22_02 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230815_082819_895594_10432EED X-CRM114-Status: GOOD ( 15.74 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org At present, schemata write (for Cache Portion Bit Map or Memory Bandwidth Allocation) goes through list of all the resources (supported by schemata), and regardless of write for one resource, it attempts to write for all other resources. As an example, When the intended write is for only MBA resource, it attempts (by calling resctrl_arch_update_domains) to write for CPBM as well. Fix it, by doing schemata write based on input schemata supplied from user. Signed-off-by: Amit Singh Tomar --- fs/resctrl/ctrlmondata.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/fs/resctrl/ctrlmondata.c b/fs/resctrl/ctrlmondata.c index 8c8a4d09d22c..ffeb68270968 100644 --- a/fs/resctrl/ctrlmondata.c +++ b/fs/resctrl/ctrlmondata.c @@ -354,9 +354,11 @@ ssize_t rdtgroup_schemata_write(struct kernfs_open_file *of, if (is_mba_sc(r)) continue; - ret = resctrl_arch_update_domains(r, rdtgrp->closid); - if (ret) - goto out; + if (!strcmp(resname, s->name)) { + ret = resctrl_arch_update_domains(r, rdtgrp->closid); + if (ret) + goto out; + } } if (rdtgrp->mode == RDT_MODE_PSEUDO_LOCKSETUP) {