From patchwork Wed Aug 16 20:04:07 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yann Sionneau X-Patchwork-Id: 13355627 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8269DC25B79 for ; Wed, 16 Aug 2023 20:11:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=CirB2S4NdQWq3ArCO38fGX+5E5+27rlB4G5muyO6lk4=; b=whbDL6Zv6ynsFk B8YhzCd7Pejno9SIRBUQOsHFkfa24lKwphv9R4txFiqudBf1imA19GtGP1M5OhDtk7ocJOkerXE4N mNUw+cPXiDGqzK5VLkM7SVxBo0vpYO0Xtp7k1VdJF5jcr8gSKbcow9Zjs89jn5IYnMF8gU7K7/Wx2 pjvzkRMa79d1P4ha/Mvc0sxsAnaKILa02sH813VvAFIrHtNBLtNXqOFdLbrw7fvfVSJL7UdOLsxPa FN6SypofkL60SbTALjEREYUpZPgWlr4tQi/gBQiAB0NlAMmX+ZfompYFasSmXra3JS+pgpr/utvd/ e+PPMTlsYwcJUvWqe0tg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qWMrF-004vt7-1H; Wed, 16 Aug 2023 20:11:09 +0000 Received: from mx4.sionneau.net ([51.15.250.1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qWMr8-004vqn-1z for linux-arm-kernel@lists.infradead.org; Wed, 16 Aug 2023 20:11:03 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sionneau.net; s=selectormx4; t=1692216262; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZyPwLzsO5Iq18JykTf6YehEkeDl4Bvn+ZZAZBGf+JIM=; b=PWgD44hKBNwvnR/2y9IyD/C+e96cOmyQJRqYvith4gpGhFq0j8i3KPzo/pjCslMT7BcgrE QeM2SAkHTlYEM59jP6XP7eVUDHzJagCyS74SKDmflbCZ7wEpU654N2eTkp4lv8IxlAP7Nm k7e/ukCccQLpcohO0P8FE0iKLyG5GK8= Received: from fallen-ThinkPad-X260.hotspot.hub-one.net ( [37.169.176.143]) by mx4.sionneau.net (OpenSMTPD) with ESMTPSA id 8204e85d (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Wed, 16 Aug 2023 20:04:21 +0000 (UTC) From: Yann Sionneau To: Andi Shyti , Codrin Ciubotariu , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Michal Simek , Oleksij Rempel , Pengutronix Kernel Team , Shawn Guo , Sascha Hauer , Fabio Estevam , NXP Linux Team Cc: linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Yann Sionneau Subject: [PATCH 1/4] i2c: mv64xxx: devm_pinctrl_get() cannot return NULL Date: Wed, 16 Aug 2023 22:04:07 +0200 Message-Id: <20230816200410.62131-2-yann@sionneau.net> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230816200410.62131-1-yann@sionneau.net> References: <20230816200410.62131-1-yann@sionneau.net> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230816_131102_928512_BB950D7E X-CRM114-Status: UNSURE ( 8.67 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Remove unnecessary check against NULL for devm_pinctrl_get() return value. Signed-off-by: Yann Sionneau --- drivers/i2c/busses/i2c-mv64xxx.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/i2c/busses/i2c-mv64xxx.c b/drivers/i2c/busses/i2c-mv64xxx.c index fd8403b07fa6..0c4a0110978f 100644 --- a/drivers/i2c/busses/i2c-mv64xxx.c +++ b/drivers/i2c/busses/i2c-mv64xxx.c @@ -947,8 +947,6 @@ static int mv64xxx_i2c_init_recovery_info(struct mv64xxx_i2c_data *drv_data, return -EPROBE_DEFER; dev_info(dev, "can't get pinctrl, bus recovery not supported\n"); return PTR_ERR(rinfo->pinctrl); - } else if (!rinfo->pinctrl) { - return -ENODEV; } drv_data->adapter.bus_recovery_info = rinfo;