| Message ID | 20230901071328.1322235-1-ruanjinjie@huawei.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [-next] clocksource/drivers/sun5i: Remove redundant dev_err() for platform_get_irq() | expand |
On Friday, September 1, 2023 9:13:28 AM CEST Jinjie Ruan wrote: > Since commit 7723f4c5ecdb ("driver core: platform: Add an error message > to platform_get_irq*()") and commit 2043727c2882 ("driver core: > platform: Make use of the helper function dev_err_probe()"), there is > no need to call the dev_err() function directly to print a custom > message when handling an error from platform_get_irq() function as it is > going to display an appropriate error message in case of a failure. > > Fixes: 7e5bac610d2f ("clocksource/drivers/sun5i: Convert to platform device > driver") Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com> This was already submitted one day earlier: https://lore.kernel.org/all/20230831041414.66434-1-yang.lee@linux.alibaba.com/ Best regards, Jernej > --- > drivers/clocksource/timer-sun5i.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/clocksource/timer-sun5i.c > b/drivers/clocksource/timer-sun5i.c index 69fee3540d37..0d229a9058da 100644 > --- a/drivers/clocksource/timer-sun5i.c > +++ b/drivers/clocksource/timer-sun5i.c > @@ -256,10 +256,8 @@ static int sun5i_timer_probe(struct platform_device > *pdev) } > > irq = platform_get_irq(pdev, 0); > - if (irq < 0) { > - dev_err(dev, "Can't get IRQ\n"); > + if (irq < 0) > return irq; > - } > > clk = devm_clk_get_enabled(dev, NULL); > if (IS_ERR(clk)) {
diff --git a/drivers/clocksource/timer-sun5i.c b/drivers/clocksource/timer-sun5i.c index 69fee3540d37..0d229a9058da 100644 --- a/drivers/clocksource/timer-sun5i.c +++ b/drivers/clocksource/timer-sun5i.c @@ -256,10 +256,8 @@ static int sun5i_timer_probe(struct platform_device *pdev) } irq = platform_get_irq(pdev, 0); - if (irq < 0) { - dev_err(dev, "Can't get IRQ\n"); + if (irq < 0) return irq; - } clk = devm_clk_get_enabled(dev, NULL); if (IS_ERR(clk)) {
Since commit 7723f4c5ecdb ("driver core: platform: Add an error message to platform_get_irq*()") and commit 2043727c2882 ("driver core: platform: Make use of the helper function dev_err_probe()"), there is no need to call the dev_err() function directly to print a custom message when handling an error from platform_get_irq() function as it is going to display an appropriate error message in case of a failure. Fixes: 7e5bac610d2f ("clocksource/drivers/sun5i: Convert to platform device driver") Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com> --- drivers/clocksource/timer-sun5i.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)