| Message ID | 20230916003118.2540661-19-seanjc@google.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | KVM: vfio: Hide KVM internals from others | expand |
On 16/09/2023 02.31, Sean Christopherson wrote: > Don't add virt/kvm to KVM s390's include path, the headers in virt/kvm are > intended to be used only by other code in virt/kvm, i.e. are "private" to > the core KVM code. It's not clear that s390 *ever* included a header from > virt/kvm, i.e. odds are good the "-Ivirt/kvm" was copied from a x86's > Makefile when s390 support was first added. > > The only headers in virt/kvm at the time were the x86 specific ioapic.h, > and iodev.h, neither of which shows up as an #include in the diff for the > commit range 37817f2982d0f..e976a2b997fc4. > > Signed-off-by: Sean Christopherson <seanjc@google.com> > --- > arch/s390/kvm/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/s390/kvm/Makefile b/arch/s390/kvm/Makefile > index 02217fb4ae10..f17249ab2a72 100644 > --- a/arch/s390/kvm/Makefile > +++ b/arch/s390/kvm/Makefile > @@ -5,7 +5,7 @@ > > include $(srctree)/virt/kvm/Makefile.kvm > > -ccflags-y := -Ivirt/kvm -Iarch/s390/kvm > +ccflags-y := -Iarch/s390/kvm > > kvm-y += kvm-s390.o intercept.o interrupt.o priv.o sigp.o > kvm-y += diag.o gaccess.o guestdbg.o vsie.o pv.o Reviewed-by: Thomas Huth <thuth@redhat.com>
On Fri, 15 Sep 2023 17:31:10 -0700 Sean Christopherson <seanjc@google.com> wrote: > Don't add virt/kvm to KVM s390's include path, the headers in virt/kvm are > intended to be used only by other code in virt/kvm, i.e. are "private" to > the core KVM code. It's not clear that s390 *ever* included a header from > virt/kvm, i.e. odds are good the "-Ivirt/kvm" was copied from a x86's > Makefile when s390 support was first added. > > The only headers in virt/kvm at the time were the x86 specific ioapic.h, > and iodev.h, neither of which shows up as an #include in the diff for the > commit range 37817f2982d0f..e976a2b997fc4. > > Signed-off-by: Sean Christopherson <seanjc@google.com> > --- > arch/s390/kvm/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/s390/kvm/Makefile b/arch/s390/kvm/Makefile > index 02217fb4ae10..f17249ab2a72 100644 > --- a/arch/s390/kvm/Makefile > +++ b/arch/s390/kvm/Makefile > @@ -5,7 +5,7 @@ > > include $(srctree)/virt/kvm/Makefile.kvm > > -ccflags-y := -Ivirt/kvm -Iarch/s390/kvm > +ccflags-y := -Iarch/s390/kvm > > kvm-y += kvm-s390.o intercept.o interrupt.o priv.o sigp.o > kvm-y += diag.o gaccess.o guestdbg.o vsie.o pv.o Acked-by: Claudio Imbrenda <imbrenda@linux.ibm.com>
diff --git a/arch/s390/kvm/Makefile b/arch/s390/kvm/Makefile index 02217fb4ae10..f17249ab2a72 100644 --- a/arch/s390/kvm/Makefile +++ b/arch/s390/kvm/Makefile @@ -5,7 +5,7 @@ include $(srctree)/virt/kvm/Makefile.kvm -ccflags-y := -Ivirt/kvm -Iarch/s390/kvm +ccflags-y := -Iarch/s390/kvm kvm-y += kvm-s390.o intercept.o interrupt.o priv.o sigp.o kvm-y += diag.o gaccess.o guestdbg.o vsie.o pv.o
Don't add virt/kvm to KVM s390's include path, the headers in virt/kvm are intended to be used only by other code in virt/kvm, i.e. are "private" to the core KVM code. It's not clear that s390 *ever* included a header from virt/kvm, i.e. odds are good the "-Ivirt/kvm" was copied from a x86's Makefile when s390 support was first added. The only headers in virt/kvm at the time were the x86 specific ioapic.h, and iodev.h, neither of which shows up as an #include in the diff for the commit range 37817f2982d0f..e976a2b997fc4. Signed-off-by: Sean Christopherson <seanjc@google.com> --- arch/s390/kvm/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)