From patchwork Wed Sep 20 19:10:36 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Serge Semin X-Patchwork-Id: 13393262 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7BAFFC04FEC for ; Wed, 20 Sep 2023 19:12:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=VbQosTo6dXRbvDJ3yTaaR/TIR/OPBhDLagEb18Scdjw=; b=rL/JwEswSqEFkj nH8YRbrh1DxmSdy4QRKZjsv5D7luOaLMyCZum9u2z4pw9+pumAIxW2LwJvBESwBkMMGPHCFtBFMVM fEmlVH1op7wqJK0aCZHzXR/G5KSycsHMaaZHBARatIK25+XxKTiFekwcIiMmPLLRzppwGkD9A/oBr GQPCckGgeMlY65OZKobseT7hjZEfcaEnYOEsxvWxjsgo20JHWgn47ccqFHX7AkhIX79xGSadsCiXj rWqzCrR2Ox8JvFkZRSxMe17mHzfs+fj1Eto11Rlts8rUYivpDA88HrPYGIHRCctd0K9BYAzBJi1aS Hbg/AfPWrJ7n/Dzx53EA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qj2ce-003xZ8-1J; Wed, 20 Sep 2023 19:12:28 +0000 Received: from mail-lf1-x131.google.com ([2a00:1450:4864:20::131]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qj2c6-003x8X-1b for linux-arm-kernel@lists.infradead.org; Wed, 20 Sep 2023 19:11:56 +0000 Received: by mail-lf1-x131.google.com with SMTP id 2adb3069b0e04-502defbb0c3so363594e87.0 for ; Wed, 20 Sep 2023 12:11:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1695237113; x=1695841913; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=fcL6jVEgRGh/qyB/fYgM+LhUsSDKaUSeMRlsor46jHo=; b=jv/EdHe1vm/XeHlGAkZha7HZnRSZ5/8wHqUxF3q6Z1Bsxx7Rby2omAfEtFtAV8a34T FGFfxO11k4cFBHZ9eUiTLBkN+X+p3X+GDJvjOk1lDdcH1/Q/+jxhRxYpDcNtIxNhmmDG KIFOsZziZ4mXkzj2lv32tLM0rC2usvH0bCjj3Rx+1OhAWHUWeoI0nUy+15omuwMLqdVw tgQJXrmK6d1m0zb1+icHkB7/AerCCp6RrsG3vSh0W61NBi8K64Y3z2r9/skAlUNAuywh R4Ug+myqxZ9UxgtJ+X/hoClAVOlb7CZGH5v6W2KeP3iLzkDmCBQqxIn1jxgLAZXxkq+u YVNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695237113; x=1695841913; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=fcL6jVEgRGh/qyB/fYgM+LhUsSDKaUSeMRlsor46jHo=; b=bODEcJB2EEg+d//ied5EocCaqrjhg1CKvM+5truh38XZ4Cok8sN5Vr3ms7dGZYue7Q QAB5kUD3J2X4JriqCvVXX1iwS7oGvow+UaNqv/ZP1e5dlq0X2hgwPFzbuQ2cVxoyt9Dq 3o+Jtsgm3EuxomBBEs7uommb6IeCWVWyNjf3uwy3e8B6fsQWeMTqkZHATU9AYMHeVAb3 mKvBG7LbvF5hft/c9eQzLhvP+0Vfm2M1BLa6LOcPzX+w1/1EoS1pdy7fPbJxLTJVGpRy 7cd38E6o8+3K2Ufl1/M1EuNzkojcj4aZARrJ7X3Yv/YGagh6XwB2Uj7cXMDBxMm52xsj LFkA== X-Gm-Message-State: AOJu0YywptJcpKK35JtDpFf8GTvevtI8+kc19VboIMxFIdCrLQpCHjMJ E9OQq31mqTwFaX1l1gmK5hw= X-Google-Smtp-Source: AGHT+IHkTSYPsgKsNJY3ThE2JEfP39gTJq7Sqe3B+h1DLraWjnV2B9+b5fyyV5SzFtu+I00UXiAL6w== X-Received: by 2002:a05:6512:3254:b0:4fd:8976:5fc9 with SMTP id c20-20020a056512325400b004fd89765fc9mr3089136lfr.23.1695237113037; Wed, 20 Sep 2023 12:11:53 -0700 (PDT) Received: from localhost ([85.26.234.178]) by smtp.gmail.com with ESMTPSA id k8-20020ac24568000000b00502ae6b8ebcsm568414lfm.304.2023.09.20.12.11.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Sep 2023 12:11:52 -0700 (PDT) From: Serge Semin To: Michal Simek , Alexander Stein , Borislav Petkov , Tony Luck , James Morse , Mauro Carvalho Chehab , Robert Richter Cc: Serge Semin , Punnaiah Choudary Kalluri , Dinh Nguyen , Arnd Bergmann , Greg Kroah-Hartman , linux-arm-kernel@lists.infradead.org, linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v4 12/20] EDAC/synopsys: Drop redundant info from the error messages Date: Wed, 20 Sep 2023 22:10:36 +0300 Message-ID: <20230920191059.28395-13-fancer.lancer@gmail.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230920191059.28395-1-fancer.lancer@gmail.com> References: <20230920191059.28395-1-fancer.lancer@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230920_121154_548715_EBF81FC3 X-CRM114-Status: GOOD ( 13.34 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Currently the custom error messages are needlessly long so the logged text gets to be printed in several lines in console. There is some duplicated/redundant information which can be freely removed from it: drop the message prefix "DDR ECC error type:%s" since the resultant text printed to the log by the edac_mc_printk() method will contain the error type and the memory controller id referring to the device detected the error anyway; with no harm to readability shorten out the phrase "Bit Position" to being just "Bit". Signed-off-by: Serge Semin --- drivers/edac/synopsys_edac.c | 19 +++++++++---------- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/drivers/edac/synopsys_edac.c b/drivers/edac/synopsys_edac.c index f1ec44cdd87f..62f498b6dfed 100644 --- a/drivers/edac/synopsys_edac.c +++ b/drivers/edac/synopsys_edac.c @@ -479,13 +479,13 @@ static void handle_error(struct mem_ctl_info *mci, struct synps_ecc_status *p) pinf = &p->ceinfo; if (priv->p_data->quirks & DDR_ECC_INTR_SUPPORT) { snprintf(priv->message, SYNPS_EDAC_MSG_SIZE, - "DDR ECC error type:%s Row %d Col %d Bank %d Bank Group %d Bit Position: %d Data: 0x%08x", - "CE", pinf->row, pinf->col, pinf->bank, - pinf->bankgrp, pinf->bitpos, pinf->data); + "Row %d Col %d Bank %d Bank Group %d Bit %d Data 0x%08x", + pinf->row, pinf->col, pinf->bank, pinf->bankgrp, + pinf->bitpos, pinf->data); } else { snprintf(priv->message, SYNPS_EDAC_MSG_SIZE, - "DDR ECC error type:%s Row %d Bank %d Col %d Bit Position: %d Data: 0x%08x", - "CE", pinf->row, pinf->bank, pinf->col, + "Row %d Bank %d Col %d Bit: %d Data: 0x%08x", + pinf->row, pinf->bank, pinf->col, pinf->bitpos, pinf->data); } @@ -498,13 +498,12 @@ static void handle_error(struct mem_ctl_info *mci, struct synps_ecc_status *p) pinf = &p->ueinfo; if (priv->p_data->quirks & DDR_ECC_INTR_SUPPORT) { snprintf(priv->message, SYNPS_EDAC_MSG_SIZE, - "DDR ECC error type :%s Row %d Col %d Bank %d Bank Group %d", - "UE", pinf->row, pinf->col, pinf->bank, - pinf->bankgrp); + "Row %d Col %d Bank %d Bank Group %d", + pinf->row, pinf->col, pinf->bank, pinf->bankgrp); } else { snprintf(priv->message, SYNPS_EDAC_MSG_SIZE, - "DDR ECC error type :%s Row %d Bank %d Col %d ", - "UE", pinf->row, pinf->bank, pinf->col); + "Row %d Bank %d Col %d", + pinf->row, pinf->bank, pinf->col); } edac_mc_handle_error(HW_EVENT_ERR_UNCORRECTED, mci,