Message ID | 20230920191059.28395-4-fancer.lancer@gmail.com (mailing list archive) |
---|---|
State | New, archived |
Headers | show
Return-Path: <linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org> X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D02F1C04FEF for <linux-arm-kernel@archiver.kernel.org>; Wed, 20 Sep 2023 19:12:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=s6CpaEfOB0Vmi2Coh97hDhH9lPFoC6OxgyNV4wOwSt0=; b=aCyfyBOo0V5gfd L43qcga8J/Z0hM3DuIvrb6L7dlhKSmsNp0SXCBH8A24Smt7DbUPvNL2h3IqWbdr0vc7znWc1rX4C6 hs2aVj9875YA764734uliMaKyZDNE3XuGeMNQkjT+Rnb6kTqbmoU/kqkMZ8lB5RRQyJVrFLQK89Gt wMmDcw3TXJAxVHhiqDlX7OHCBYd4nhCgmKtQjEgjZbGdbaIwi+oWlBK1ZqrWNOhS1EyD1BpkfqVlO njFiYyhHfRTlauJ4m6qQd3/GAxrJaDC2XRItw0XVbZVzJINFChJ4MMIPdNser4GCcWE1vmgtfeYBf K4Kp4lZVxSfAGQDhMwWw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qj2bm-003wvw-3C; Wed, 20 Sep 2023 19:11:34 +0000 Received: from mail-lf1-x136.google.com ([2a00:1450:4864:20::136]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qj2bi-003wrq-1g for linux-arm-kernel@lists.infradead.org; Wed, 20 Sep 2023 19:11:31 +0000 Received: by mail-lf1-x136.google.com with SMTP id 2adb3069b0e04-50336768615so383506e87.0 for <linux-arm-kernel@lists.infradead.org>; Wed, 20 Sep 2023 12:11:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1695237086; x=1695841886; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ZnR6l+vYOh9Csf9eBwgQHTo/sUEkvBg0hJ7+UGZ8t70=; b=cOXW4Sk8/6izbOzM/1jYVBMWb5ib5swVq5BOZCTrv0X/TAtIY6fQfOTJGuGvbo5jT3 Q30YRnOzxfFsnYfJjljft/PlIcQmo84Usi7bG2DFKuD1pJh6BBWCTkJ/WBCHwJCgyEcS 5MCnRay8Cgi0eI3x/MOEHT7HDPXf205CGG2Koi5rdfPGAmI3cxsC0QV7U0jwOBlBF4/B IkciZt2sLs5gNVhsF+ABBoDMxBKnkQFKTcD2pEGK6cRpKKUSuc5dub7b1tWgkdnY6ydN L6rpWeLSWpVLp2J9+mPs5a6eAo5D6fJHzgWQC7wdk9ve8++n2B94HuUxQQpZUyF1WFcN iNwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695237086; x=1695841886; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ZnR6l+vYOh9Csf9eBwgQHTo/sUEkvBg0hJ7+UGZ8t70=; b=WtPrGlULasRKDgdjMABFlknEUlA6zFWKlVDNphEpjee6ROZKDgGYgUieGZGQ+8V1Dh qH9IncbfUNpB6sUPnjLNeCqXbccEyRK3vRPC4lvoPjdgpGSHpVwMed4f74DP2Xqs5MlN +6z18AeGEfFKc6XynLE/TCUaSVXH5FyOxfXGMWfUXpYIr4xFSrGJSehF0Y9txgKRnhwJ ho8zUr+jhfGq7LTYyrANrW44wsCH7ge/uKc1wGMMr+fI/LGmJwb94Rk9QuozYn0cPYDa yLXQiDa3bZ3S73X4VRVUiYyCNpoyq0jfa4WKflgZuiqTgY0D2pdoylnnDBHx+hI3FN15 6tWQ== X-Gm-Message-State: AOJu0YyeUaNUrZTiHLtmGtGpLuzHP4CWhFdAHk3gkoHRSiAXdg4YKc2E FzE3ZXG80RnZFd+K6j+IrVo= X-Google-Smtp-Source: AGHT+IExfWuCoa4RzHs2lEM9AIkEJYLw9ooHlfGZM2+IIUrULkxRvC9LOMmRYav56Pnn28/FK1GUFA== X-Received: by 2002:ac2:5dd3:0:b0:500:78ee:4cd7 with SMTP id x19-20020ac25dd3000000b0050078ee4cd7mr3193711lfq.23.1695237086256; Wed, 20 Sep 2023 12:11:26 -0700 (PDT) Received: from localhost ([85.140.6.11]) by smtp.gmail.com with ESMTPSA id f9-20020ac251a9000000b00501c1794883sm2812429lfk.251.2023.09.20.12.11.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Sep 2023 12:11:25 -0700 (PDT) From: Serge Semin <fancer.lancer@gmail.com> To: Michal Simek <michal.simek@amd.com>, Alexander Stein <alexander.stein@ew.tq-group.com>, Borislav Petkov <bp@alien8.de>, Tony Luck <tony.luck@intel.com>, James Morse <james.morse@arm.com>, Mauro Carvalho Chehab <mchehab@kernel.org>, Robert Richter <rric@kernel.org>, Punnaiah Choudary Kalluri <punnaiah.choudary.kalluri@xilinx.com> Cc: Serge Semin <fancer.lancer@gmail.com>, Dinh Nguyen <dinguyen@kernel.org>, Arnd Bergmann <arnd@arndb.de>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, linux-arm-kernel@lists.infradead.org, linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org, Borislav Petkov <bp@suse.de> Subject: [PATCH v4 03/20] EDAC/synopsys: Fix mci->scrub_cap field setting Date: Wed, 20 Sep 2023 22:10:27 +0300 Message-ID: <20230920191059.28395-4-fancer.lancer@gmail.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230920191059.28395-1-fancer.lancer@gmail.com> References: <20230920191059.28395-1-fancer.lancer@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230920_121130_581591_2088BB76 X-CRM114-Status: GOOD ( 15.81 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: <linux-arm-kernel.lists.infradead.org> List-Unsubscribe: <http://lists.infradead.org/mailman/options/linux-arm-kernel>, <mailto:linux-arm-kernel-request@lists.infradead.org?subject=unsubscribe> List-Archive: <http://lists.infradead.org/pipermail/linux-arm-kernel/> List-Post: <mailto:linux-arm-kernel@lists.infradead.org> List-Help: <mailto:linux-arm-kernel-request@lists.infradead.org?subject=help> List-Subscribe: <http://lists.infradead.org/mailman/listinfo/linux-arm-kernel>, <mailto:linux-arm-kernel-request@lists.infradead.org?subject=subscribe> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" <linux-arm-kernel-bounces@lists.infradead.org> Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org |
Series |
EDAC/mc/synopsys: Various fixes and cleanups
|
expand
|
diff --git a/drivers/edac/synopsys_edac.c b/drivers/edac/synopsys_edac.c index b463bd802961..65790097beb2 100644 --- a/drivers/edac/synopsys_edac.c +++ b/drivers/edac/synopsys_edac.c @@ -856,7 +856,7 @@ static void mc_init(struct mem_ctl_info *mci, struct platform_device *pdev) /* Initialize controller capabilities and configuration */ mci->mtype_cap = MEM_FLAG_DDR3 | MEM_FLAG_DDR2; mci->edac_ctl_cap = EDAC_FLAG_NONE | EDAC_FLAG_SECDED; - mci->scrub_cap = SCRUB_HW_SRC; + mci->scrub_cap = SCRUB_FLAG_HW_SRC; mci->scrub_mode = SCRUB_NONE; mci->edac_cap = EDAC_FLAG_SECDED;
The mem_ctl_info.scrub_cap field is supposed to be set with the ECC scrub-related flags. Instead the driver erroneously initializes it with the SCRUB_HW_SRC flag ID. It's definitely wrong, though it hasn't caused any problem so far since the structure field isn't used by the EDAC core. Fix it anyway by using the SCRUB_FLAG_HW_SRC macro to initialize the field. Fixes: ae9b56e3996d ("EDAC, synps: Add EDAC support for zynq ddr ecc controller") Signed-off-by: Serge Semin <fancer.lancer@gmail.com> --- drivers/edac/synopsys_edac.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)