From patchwork Wed Sep 20 19:10:28 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Serge Semin X-Patchwork-Id: 13393254 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A52AAC04FEC for ; Wed, 20 Sep 2023 19:12:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=PhU1FvIfxewO5IWLO/w0ZIMDF9LMMeSD5bSwE/GHZwA=; b=dmza3LuMK4C9zF AKMPTBAy6d8meoEtYK1C/9Gg+y0QIx/50sp4frnVtGPRK9wsjyKt3TDeqsZmc4SzJV3kJtPb9J9fp soPvp6jPwW44g7pK9s4cG8AszHy8/31ioaVu4MzSty8cFil2raGE8J6wbuU1nfJINcyFOA5bu5xep lnihl8Gef8Z7TtIyNUetPKaLwVuFsqnRHnC4uK8zCAglYS7KDKyLgID9ohH2fIieOVbD7PQosJZit oq+WMOFAOwhrzVoyt/EFY9M3LPah6OEpNTTRgyqgtB+fNt4zi94ibrAc4st0WpZpFcuBjklqPmQes QWBI5Vf21CxptQIyWc7Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qj2by-003x1x-09; Wed, 20 Sep 2023 19:11:46 +0000 Received: from mail-lf1-x130.google.com ([2a00:1450:4864:20::130]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qj2bk-003wt7-2u for linux-arm-kernel@lists.infradead.org; Wed, 20 Sep 2023 19:11:34 +0000 Received: by mail-lf1-x130.google.com with SMTP id 2adb3069b0e04-5041335fb9cso364806e87.0 for ; Wed, 20 Sep 2023 12:11:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1695237089; x=1695841889; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=CUQlNWBQLKx5ke9/fjvP01zDeVt7MOvvAIgh8fT+a2g=; b=QJRcz9BVFlO3LUoWmZ5bFTDreAj1KnRTI/rsTkWT3pGw/OFj2Y7qx9ll2u1yndVg6a z4NiYypwZIIevE/nfxSzIhbaih892FKlJYd7BDb20cPTPfdjwMXHq/2yiITWfueMBQXy ryvRwx/+aIFABT6SuPqcFfYcmtgosyaGIMG6YQq6KiWodJAVBjtqnIJ/aaMoyrYIACf3 eJOkwEVZGTmRIW1iXpj10HTNixN3618g8bHj5ZAnxNmWKRp5w+vM4rXBYhX1BqkdNmIK /fGxGhbmSVn6M9LIXDaYK2VvX8rzotMpgZNkkHoujWJ6M2XdJjYafmnE/Sq1iHq5OM8u WqaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695237089; x=1695841889; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=CUQlNWBQLKx5ke9/fjvP01zDeVt7MOvvAIgh8fT+a2g=; b=O7pfjOjf8fn13PjqUZ5wLB8ZpJCxisefottVLKKt9DuntnhiNTfbPUlkc3Jy9ahU1l eH+oBpN62WtSALuEbX+nhFCY7khBrYllMwM5pg1V+ioO80OtNh5fe5EGolQwJ9YQMQak ig3/eUD2HjuUst9k19RYTvJoXHKQNaQqplcaHp+4CU5dzFrpQ77xBBjpjTQ655VOkByP XRxqliflIA9gXYUZg5kWxv/U01163qKKx9SNxqNU//H+/9QVPQvESM3CXrK3H20MlJG8 /SDD2B/hGIUVMT6YiTAoNUkiNW2ynjVRdGT8t3SAwQxx1pFdpC8eWizJuMb25ThT4s2w LPSw== X-Gm-Message-State: AOJu0Ywkct1UpfRd9ABOjc57Pae6I0S0/PO9h47qN+jKISyfSo26Uy8K l6e4xQFdk6jkRuifpefPIXM= X-Google-Smtp-Source: AGHT+IGjuWCpw3+WqQsoX1kGIpH5V86XQwheI3EqDlTcV/bf3oj9XgFQeK/GNEeHA27ZLJuzhjolVg== X-Received: by 2002:ac2:5bc7:0:b0:502:a4f4:ced9 with SMTP id u7-20020ac25bc7000000b00502a4f4ced9mr2972681lfn.62.1695237089243; Wed, 20 Sep 2023 12:11:29 -0700 (PDT) Received: from localhost ([178.176.81.142]) by smtp.gmail.com with ESMTPSA id h10-20020ac25d6a000000b004f85d80ca64sm2800653lft.221.2023.09.20.12.11.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Sep 2023 12:11:28 -0700 (PDT) From: Serge Semin To: Michal Simek , Alexander Stein , Borislav Petkov , Tony Luck , James Morse , Mauro Carvalho Chehab , Robert Richter , Manish Narani Cc: Serge Semin , Punnaiah Choudary Kalluri , Dinh Nguyen , Arnd Bergmann , Greg Kroah-Hartman , linux-arm-kernel@lists.infradead.org, linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org, Borislav Petkov Subject: [PATCH v4 04/20] EDAC/synopsys: Drop erroneous ADDRMAP4.addrmap_col_b10 parse Date: Wed, 20 Sep 2023 22:10:28 +0300 Message-ID: <20230920191059.28395-5-fancer.lancer@gmail.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230920191059.28395-1-fancer.lancer@gmail.com> References: <20230920191059.28395-1-fancer.lancer@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230920_121132_989026_06E62997 X-CRM114-Status: GOOD ( 13.60 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Currently the ADDRMAP4.addrmap_col_b10 field gets to be parsed in case of the LPDDR3 memory and Quarter DQ bus width mode. It's wrong since that field is marked as unused for that mode in all the available DW uMCTL2 DDRC releases (up to IP-core v3.91a). Most likely the field parsing was added by mistake as a result of the copy-paste from the Half DQ bus width mode part of the same function. Even though the field is supposed to be always set to the UNUSED value (0x1F) drop parsing it anyway so to simplify the setup_column_address_map() method a tiny bit. Fixes: 1a81361f75d8 ("EDAC, synopsys: Add Error Injection support for ZynqMP DDR controller") Signed-off-by: Serge Semin --- drivers/edac/synopsys_edac.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/edac/synopsys_edac.c b/drivers/edac/synopsys_edac.c index 65790097beb2..308da6f82d3d 100644 --- a/drivers/edac/synopsys_edac.c +++ b/drivers/edac/synopsys_edac.c @@ -1237,10 +1237,6 @@ static void setup_column_address_map(struct synps_edac_priv *priv, u32 *addrmap) COL_MAX_VAL_MASK) == COL_MAX_VAL_MASK) ? 0 : (((addrmap[3] >> 24) & COL_MAX_VAL_MASK) + COL_B9_BASE); - priv->col_shift[13] = ((addrmap[4] & - COL_MAX_VAL_MASK) == COL_MAX_VAL_MASK) ? 0 : - ((addrmap[4] & COL_MAX_VAL_MASK) + - COL_B10_BASE); } else { priv->col_shift[11] = (((addrmap[3] >> 16) & COL_MAX_VAL_MASK) == COL_MAX_VAL_MASK) ? 0 :