diff mbox series

[RFC] ARM: dts: at91: sama5d3_eds: remove TDES use

Message ID 20230928145655.215481-1-nicolas.ferre@microchip.com (mailing list archive)
State New, archived
Headers show
Series [RFC] ARM: dts: at91: sama5d3_eds: remove TDES use | expand

Commit Message

Nicolas Ferre Sept. 28, 2023, 2:56 p.m. UTC 
From: Nicolas Ferre <nicolas.ferre@microchip.com>

TDES doesn't probe because of lack of DMA channels left on this
controller. As we don't need TDES HW engine, we prefer to keep DMA
channels for other usage.
Disable TDES for this board.

Signed-off-by: Nicolas Ferre <nicolas.ferre@microchip.com>
---
Hi,

Tell me what you think about this move. I think it makes sense but tell me if
application could suffer from this lack of TDES engine.

Regards,
  Nicolas

 arch/arm/boot/dts/microchip/at91-sama5d3_eds.dts | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Claudiu Beznea Oct. 6, 2023, 8:15 a.m. UTC | #1 
Hi, Nicolas, Jerry,

On 28.09.2023 17:56, nicolas.ferre@microchip.com wrote:
> From: Nicolas Ferre <nicolas.ferre@microchip.com>
> 
> TDES doesn't probe because of lack of DMA channels left on this
> controller. As we don't need TDES HW engine, we prefer to keep DMA
> channels for other usage.
> Disable TDES for this board.
> 
> Signed-off-by: Nicolas Ferre <nicolas.ferre@microchip.com>
> ---
> Hi,
> 
> Tell me what you think about this move. I think it makes sense but tell me if
> application could suffer from this lack of TDES engine.

It anyway fails to probe. I have nothing against unless its probing could
be fixed. Jerry, are you good with applying this?

Thank you,
Claudiu Beznea

> 
> Regards,
>   Nicolas
> 
>  arch/arm/boot/dts/microchip/at91-sama5d3_eds.dts | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/microchip/at91-sama5d3_eds.dts b/arch/arm/boot/dts/microchip/at91-sama5d3_eds.dts
> index c287b03d768b..fddd786f8483 100644
> --- a/arch/arm/boot/dts/microchip/at91-sama5d3_eds.dts
> +++ b/arch/arm/boot/dts/microchip/at91-sama5d3_eds.dts
> @@ -284,6 +284,10 @@ timer1: timer@1 {
>  	};
>  };
>  
> +&tdes {
> +	status = "disabled";
> +};
> +
>  &usb0 {	/* USB Device port with VBUS detection. */
>  	atmel,vbus-gpio = <&pioE 9 GPIO_ACTIVE_HIGH>;
>  	pinctrl-names = "default";
diff mbox series

Patch

diff --git a/arch/arm/boot/dts/microchip/at91-sama5d3_eds.dts b/arch/arm/boot/dts/microchip/at91-sama5d3_eds.dts
index c287b03d768b..fddd786f8483 100644
--- a/arch/arm/boot/dts/microchip/at91-sama5d3_eds.dts
+++ b/arch/arm/boot/dts/microchip/at91-sama5d3_eds.dts
@@ -284,6 +284,10 @@  timer1: timer@1 {
 	};
 };
 
+&tdes {
+	status = "disabled";
+};
+
 &usb0 {	/* USB Device port with VBUS detection. */
 	atmel,vbus-gpio = <&pioE 9 GPIO_ACTIVE_HIGH>;
 	pinctrl-names = "default";