diff mbox series

[2/2] ARM: dts: imx23: Remove dma interrupt-names

Message ID 20231002003239.1341144-2-festevam@gmail.com (mailing list archive)
State New, archived
Headers show
Series [1/2] ARM: dts: mxs: Use dma-controller as node name | expand

Commit Message

Fabio Estevam Oct. 2, 2023, 12:32 a.m. UTC
From: Fabio Estevam <festevam@denx.de>

Per fsl,mxs-dma.yaml, 'interrupt-names' is not a valid property.

Remove it to fix the following schema warning:

dma-apbx@80024000: 'interrupt-names' does not match any of the regexes: 'pinctrl-[0-9]+'
from schema $id: http://devicetree.org/schemas/dma/fsl,mxs-dma.yaml#

Signed-off-by: Fabio Estevam <festevam@denx.de>
---
 arch/arm/boot/dts/nxp/mxs/imx23.dtsi | 4 ----
 1 file changed, 4 deletions(-)

Comments

Stefan Wahren Oct. 2, 2023, 9:05 a.m. UTC | #1
Hi Fabio,

Am 02.10.23 um 02:32 schrieb Fabio Estevam:
> From: Fabio Estevam <festevam@denx.de>
>
> Per fsl,mxs-dma.yaml, 'interrupt-names' is not a valid property.
>
> Remove it to fix the following schema warning:
>
> dma-apbx@80024000: 'interrupt-names' does not match any of the regexes: 'pinctrl-[0-9]+'
> from schema $id: http://devicetree.org/schemas/dma/fsl,mxs-dma.yaml#
>
> Signed-off-by: Fabio Estevam <festevam@denx.de>
> ---
>   arch/arm/boot/dts/nxp/mxs/imx23.dtsi | 4 ----
>   1 file changed, 4 deletions(-)
>
> diff --git a/arch/arm/boot/dts/nxp/mxs/imx23.dtsi b/arch/arm/boot/dts/nxp/mxs/imx23.dtsi
> index 9cba1d0224f4..f98ee2e42431 100644
> --- a/arch/arm/boot/dts/nxp/mxs/imx23.dtsi
> +++ b/arch/arm/boot/dts/nxp/mxs/imx23.dtsi
> @@ -419,10 +419,6 @@ dma_apbx: dma-controller@80024000 {
>   					     <19>, <0>, <25>, <23>,
>   					     <60>, <58>, <9>, <0>,
>   					     <0>, <0>, <0>, <0>;
> -				interrupt-names = "audio-adc", "audio-dac", "spdif-tx", "i2c",
> -						  "saif0", "empty", "auart0-rx", "auart0-tx",
> -						  "auart1-rx", "auart1-tx", "saif1", "empty",
> -						  "empty", "empty", "empty", "empty";
dropping these useful information looks wrong to me and also there is a
chance to break possible users beside Mainline Linux. I would prefer to
fix the schema by making interrupt-names optional.

Best regards
>   				#dma-cells = <1>;
>   				dma-channels = <16>;
>   				clocks = <&clks 16>;
diff mbox series

Patch

diff --git a/arch/arm/boot/dts/nxp/mxs/imx23.dtsi b/arch/arm/boot/dts/nxp/mxs/imx23.dtsi
index 9cba1d0224f4..f98ee2e42431 100644
--- a/arch/arm/boot/dts/nxp/mxs/imx23.dtsi
+++ b/arch/arm/boot/dts/nxp/mxs/imx23.dtsi
@@ -419,10 +419,6 @@  dma_apbx: dma-controller@80024000 {
 					     <19>, <0>, <25>, <23>,
 					     <60>, <58>, <9>, <0>,
 					     <0>, <0>, <0>, <0>;
-				interrupt-names = "audio-adc", "audio-dac", "spdif-tx", "i2c",
-						  "saif0", "empty", "auart0-rx", "auart0-tx",
-						  "auart1-rx", "auart1-tx", "saif1", "empty",
-						  "empty", "empty", "empty", "empty";
 				#dma-cells = <1>;
 				dma-channels = <16>;
 				clocks = <&clks 16>;