From patchwork Mon Oct 9 15:34:15 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bartosz Golaszewski X-Patchwork-Id: 13413931 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E3D98E95A91 for ; Mon, 9 Oct 2023 15:35:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=YUCyusaV8nRY1sqTYW6xDZRJz+7A0qs7poiCx0aCPBE=; b=WfjWvr0Vt767Oz MOBXEVo6EV+23kzdgepOi0So6PQneWyl0NAj3HgzYOS+oB1GJFeam63VsPRREPxnnql1oXiyyRBz7 yzCJbUCH/aE+Q047AmozyCBc8cN20i0r/MraVqN77UoW/B3mNSctG6nJECwH698/bAFGZCOAoD4nQ 41voIpvjaLf+MSyqS/LKEoe+szvzZ+by3u81IKSfolpVUyQUWuCJInHzmx79PFOrFXTq8TP4E2lhf TuX24YLpe46bj3KumrjkfWkIopVP9FnFABRMTCsn8afNqJ+Gy02ClxwhGvLLKfSlaEp6UK6R8SS0Y oPYAuhGGXRrRczo74YRg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qpsHU-00B40l-2Z; Mon, 09 Oct 2023 15:34:52 +0000 Received: from mail-wr1-x42e.google.com ([2a00:1450:4864:20::42e]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qpsHP-00B3wc-2i for linux-arm-kernel@lists.infradead.org; Mon, 09 Oct 2023 15:34:49 +0000 Received: by mail-wr1-x42e.google.com with SMTP id ffacd0b85a97d-307d20548adso4306847f8f.0 for ; Mon, 09 Oct 2023 08:34:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1696865683; x=1697470483; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=D6eAwp+/NLgzsLQxQqIe9/6ILdI8QAjkHJ9+by+NSlg=; b=ibk3iDgTJMXU/7Jh3ZAxwWaS3FMxLwn6fN+RNsKAGOfgjPGxfVN+VndXsdogsCaBvZ zwXNztuqe7Tw6PhXFKX5OssZxUmDbUMuaBGphwu1cW0MoSQRKwEop8+OQHpJpMtHZVPM Co10i7mw1MdjtALbsd7aPwt+gf1PHcx7k90WEC3GHVHOFrxmhYYjsNCkqLe/L+WEj0yJ 7EXQgEJGQrULgxQnRQwcS9TL30u3aPsvYHKYDSojSWA9Aoq3ptUhGWyIgmzc/OAiUOng WqZWWEMcMVt2wzeG5ePd86sLduyP6T+NlMh76TnlM3H4MX19r5Lae4g6kFLPAEIYhtmO FJFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696865683; x=1697470483; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=D6eAwp+/NLgzsLQxQqIe9/6ILdI8QAjkHJ9+by+NSlg=; b=KRHwcOZTeT5ujEcqF4guwGMaCuLmwT3HFLxCszNuj1mpygJQ7oebEi+RlUizNHlkE0 ihJMVcP1DMz8LN8RVB5JAtRk+2yb9kyeGb4/LqyZDv9RUU7vF+iLNiscX4Mh1+q9+HGO QyGutCX8FKtQJi75zkeSoTnOpI6b28zWcHYszQeayeBU7X+HSfr7a1UQy42xQzXN6+t/ ZqmG8csXPRvYeTyKf23mwHR1qdw5OlkC4BYDAArUZn4hP7hJc38OICH+ZjA/0hJ9gJQs UnnDrPFsDGf3bxJiNPJAoMKLLuNjfIVsbPaSpYgy7pXIkpbPPE6BrBCQ8wArD/EGhH4p o9wA== X-Gm-Message-State: AOJu0YxnH03BTAWm/zLG9olskGR6J7q9E82EGrAUmC8BeO3i4oJezfRR J9Zet+bLyUM+wxHu3oLK4V4eZkURfh11iCOiv757Vg== X-Google-Smtp-Source: AGHT+IGQPbmjtWzlwmkDpMj8BrV+CGMweKgLmWJRazlR2GfQlg6tpQhTsj0X/JeH7Ks7AF7tx4ODyw== X-Received: by 2002:adf:f407:0:b0:31f:eed7:2fdc with SMTP id g7-20020adff407000000b0031feed72fdcmr14360253wro.35.1696865683428; Mon, 09 Oct 2023 08:34:43 -0700 (PDT) Received: from brgl-uxlite.home ([2a01:cb1d:334:ac00:f20d:2959:7545:e99f]) by smtp.gmail.com with ESMTPSA id b3-20020adff243000000b0031431fb40fasm10016521wrp.89.2023.10.09.08.34.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Oct 2023 08:34:43 -0700 (PDT) From: Bartosz Golaszewski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Elliot Berman , Krzysztof Kozlowski , Guru Das Srinagesh , Andrew Halaney , Maximilian Luz , Alex Elder , Srini Kandagatla Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kernel@quicinc.com, Bartosz Golaszewski Subject: [PATCH v3 03/15] firmware: qcom: scm: remove unneeded 'extern' specifiers Date: Mon, 9 Oct 2023 17:34:15 +0200 Message-Id: <20231009153427.20951-4-brgl@bgdev.pl> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20231009153427.20951-1-brgl@bgdev.pl> References: <20231009153427.20951-1-brgl@bgdev.pl> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231009_083447_883128_D3CCFF47 X-CRM114-Status: GOOD ( 10.88 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Bartosz Golaszewski 'extern' specifiers do nothing for function declarations. Remove them from the private qcom-scm header. Signed-off-by: Bartosz Golaszewski Reviewed-by: Andrew Halaney --- drivers/firmware/qcom/qcom_scm.h | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/drivers/firmware/qcom/qcom_scm.h b/drivers/firmware/qcom/qcom_scm.h index c88e29051d20..4532907e8489 100644 --- a/drivers/firmware/qcom/qcom_scm.h +++ b/drivers/firmware/qcom/qcom_scm.h @@ -66,18 +66,17 @@ int qcom_scm_wait_for_wq_completion(u32 wq_ctx); int scm_get_wq_ctx(u32 *wq_ctx, u32 *flags, u32 *more_pending); #define SCM_SMC_FNID(s, c) ((((s) & 0xFF) << 8) | ((c) & 0xFF)) -extern int __scm_smc_call(struct device *dev, const struct qcom_scm_desc *desc, - enum qcom_scm_convention qcom_convention, - struct qcom_scm_res *res, bool atomic); +int __scm_smc_call(struct device *dev, const struct qcom_scm_desc *desc, + enum qcom_scm_convention qcom_convention, + struct qcom_scm_res *res, bool atomic); #define scm_smc_call(dev, desc, res, atomic) \ __scm_smc_call((dev), (desc), qcom_scm_convention, (res), (atomic)) #define SCM_LEGACY_FNID(s, c) (((s) << 10) | ((c) & 0x3ff)) -extern int scm_legacy_call_atomic(struct device *dev, - const struct qcom_scm_desc *desc, - struct qcom_scm_res *res); -extern int scm_legacy_call(struct device *dev, const struct qcom_scm_desc *desc, +int scm_legacy_call_atomic(struct device *dev, const struct qcom_scm_desc *desc, struct qcom_scm_res *res); +int scm_legacy_call(struct device *dev, const struct qcom_scm_desc *desc, + struct qcom_scm_res *res); #define QCOM_SCM_SVC_BOOT 0x01 #define QCOM_SCM_BOOT_SET_ADDR 0x01