From patchwork Thu Oct 12 10:04:59 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christian Marangi X-Patchwork-Id: 13418799 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C1AFACDB47E for ; Thu, 12 Oct 2023 10:09:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=P4kRgfyq9lsa+pHJsbqHRsTJzyNHHQSUdvhaftYD/hc=; b=MiZpTLa5x+nr/+ PTP0t6Ct0LwQJm7nBQflnj4uo+Hb9dwro5kIoJ4gR0rYrHcw7xklYgxPjXTOgULh02UR1vI51Pkh4 NxkRceilDoPsxhF84PC6FHPfwbqKg78d/QdJVLtgJA/htZLxh3X7nzbFB8RMf9ROEEGMxyBf8k7E/ aMFLkj6mkOLDyOYMDFOIzm1bGbq253hwqWY3n8ZXV8TT3pNp6IBt1NNV/XO0oS8wxc1+IBMCL5Jc/ wGH/4zUegyQc+eRM7Go91kXcN2aIesmUWLD68rLPL6tMR0dGxuH8fGoI00ioH2C9Id+02vnivLZ3p olEy640OpjmB0EfOAg2w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qqsca-000X8C-1Q; Thu, 12 Oct 2023 10:08:48 +0000 Received: from mail-lf1-x135.google.com ([2a00:1450:4864:20::135]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qqscV-000X1w-07 for linux-arm-kernel@lists.infradead.org; Thu, 12 Oct 2023 10:08:44 +0000 Received: by mail-lf1-x135.google.com with SMTP id 2adb3069b0e04-50573e85ee0so1056866e87.3 for ; Thu, 12 Oct 2023 03:08:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697105320; x=1697710120; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=SSAhxNCccBDPfEaHOYwSm94ZHYVqbuNn4mUPNvHQg0g=; b=SAqRa+XUA5fkc5ByzUPIFoW62D6fE7eR40H5ozsfgHJ3mPm9H8DJQU5GiScK40h/kn 6/hI/Y1MMNOUsPWUdectpZsu10apiIu8wUlDls8xoDQG328Kp+V0bIWfVUj+wf7E0Mvy NsyptTJMiv8A1Ar6TIpzTlw/O9+Pt+YEJJ3o+1BSTqO/C8YTJZzGyQUCEAM0I4I9kQX9 DjZ8bnY1aqDukqazpbUr+nNnOcwgK0UYFU7xbVQWRWdDb4PCA8MtalfTY5pRLMAXemym gLkZd2JWFfjl40m5asoLMvKkNZJjell7LhQ+VLj98aPqP580bf46KoGby98b/6hAjeUF 7jTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697105320; x=1697710120; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=SSAhxNCccBDPfEaHOYwSm94ZHYVqbuNn4mUPNvHQg0g=; b=lopuZfd4yyGB2NZpY1g8haIf1OP+jY2zg6Csw78ffpW/GfHU1SAg7IXI5GtIFEKo0V FPHv9FROMykFSaNgdI1hIzyU0Cr15iwqcaQyc9ySSwpCz7/gDat9O9dlPLap2bq7Y4FF 1JcfnPAEYL913RhEBcOBMXuWFhgvY3A2W4ix9oTUXhNVZGeBr73i8TSSomDWqSBCx9L6 74Ca7WorSRpEgAxkDsT75+ETdNY0O3Eaj91v8eQS2N6gUlfEGgltPah06r8nvTY7WFa9 /+luPgm+r9HRY59JvFL9mLSSPA3zOboD99pdqjzECvhRvEi1Zh/L7L4mLb1xA0JLLqfU 2fOw== X-Gm-Message-State: AOJu0YzYfVEjgDUKTZ0b/K1/B6fnY5MJVL6yJqp65egHXfWtBbwJdJ6+ fVGnCmF6kIUDOtLEUexUkgY= X-Google-Smtp-Source: AGHT+IFS5wYVsErszFbLHXbccvljCxec7tsdB2hdb2nVZS6k8/mqAnVjAi0sisagLq6W9E03Rccilg== X-Received: by 2002:a05:6512:210c:b0:503:36cb:5436 with SMTP id q12-20020a056512210c00b0050336cb5436mr18333699lfr.9.1697105320566; Thu, 12 Oct 2023 03:08:40 -0700 (PDT) Received: from localhost.localdomain (93-34-89-13.ip49.fastwebnet.it. [93.34.89.13]) by smtp.googlemail.com with ESMTPSA id dj16-20020a0560000b1000b003198a9d758dsm922737wrb.78.2023.10.12.03.08.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Oct 2023 03:08:40 -0700 (PDT) From: Christian Marangi To: Raju Rangoju , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Alexandre Torgue , Jose Abreu , Maxime Coquelin , Ping-Ke Shih , Kalle Valo , Simon Horman , Daniel Borkmann , Jiri Pirko , Hangbin Liu , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-wireless@vger.kernel.org Cc: Christian Marangi Subject: [net-next PATCH v2 4/4] net: stmmac: increase TX coalesce timer to 5ms Date: Thu, 12 Oct 2023 12:04:59 +0200 Message-Id: <20231012100459.6158-5-ansuelsmth@gmail.com> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20231012100459.6158-1-ansuelsmth@gmail.com> References: <20231012100459.6158-1-ansuelsmth@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231012_030843_087171_5C5E905B X-CRM114-Status: GOOD ( 14.84 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Commit 8fce33317023 ("net: stmmac: Rework coalesce timer and fix multi-queue races") decreased the TX coalesce timer from 40ms to 1ms. This caused some performance regression on some target (regression was reported at least on ipq806x) in the order of 600mbps dropping from gigabit handling to only 200mbps. The problem was identified in the TX timer getting armed too much time. While this was fixed and improved in another commit, performance can be improved even further by increasing the timer delay a bit moving from 1ms to 5ms. The value is a good balance between battery saving by prevending too much interrupt to be generated and permitting good performance for internet oriented devices. Signed-off-by: Christian Marangi --- drivers/net/ethernet/stmicro/stmmac/common.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/common.h b/drivers/net/ethernet/stmicro/stmmac/common.h index 1e996c29043d..e3f650e88f82 100644 --- a/drivers/net/ethernet/stmicro/stmmac/common.h +++ b/drivers/net/ethernet/stmicro/stmmac/common.h @@ -293,7 +293,7 @@ struct stmmac_safety_stats { #define MIN_DMA_RIWT 0x10 #define DEF_DMA_RIWT 0xa0 /* Tx coalesce parameters */ -#define STMMAC_COAL_TX_TIMER 1000 +#define STMMAC_COAL_TX_TIMER 5000 #define STMMAC_MAX_COAL_TX_TICK 100000 #define STMMAC_TX_MAX_FRAMES 256 #define STMMAC_TX_FRAMES 25