From patchwork Fri Oct 13 11:48:31 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bartosz Golaszewski X-Patchwork-Id: 13420782 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 27615CDB47E for ; Fri, 13 Oct 2023 11:49:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=G52lCfrfXvV3IMtgI5vNqVt91ZQIKwhXrXAtLYoDi/4=; b=yDI3QB6x7D2JxI rdRDKnr9f4VNMS11AqhKBAGGBv8fx6HWKD2lGJ3q/FN149RcpaDZmb6LPFt/ggKTrazMGxMt/4UEJ kaAPHCRr16lDdwOVGbhOYo53iuByFIzihRlp+3kxtC7WEvk5LK8CmiuutuVriyMiPl3/rbzHw+eHP Bcp/ybchVzfUDi/Qm7riohcnE5+0uLbShPu4Oq3/YfOakV+fhBKUdLDYrrKKRADL+R1F//BeVtgzS 8m2rSeSDlJxz5XkfpW9xE/3/diScy1COe2WpLEufa4HDZyhASRPW5JfSvGGrP57t2j8iKVL819zXA JXiamF3GCBfPF28+Z/3A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qrGfD-003LWc-1b; Fri, 13 Oct 2023 11:49:07 +0000 Received: from mail-wm1-x335.google.com ([2a00:1450:4864:20::335]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qrGf5-003LPz-0t for linux-arm-kernel@lists.infradead.org; Fri, 13 Oct 2023 11:49:00 +0000 Received: by mail-wm1-x335.google.com with SMTP id 5b1f17b1804b1-40535597f01so20533585e9.3 for ; Fri, 13 Oct 2023 04:48:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1697197735; x=1697802535; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=4lyOHM/RBgmuxKTo/vmZ0oW2gfmzXsxTpr43TXFONHQ=; b=N+CG223jZKAZj2rfS+ypF0CTt+rvo4dqRa2QPZQVTdkKFrPslQM6DUV1TgQlS8rEzz +1OTmwCY3czefemKQ5G41UAkDx4wsm9lvLAE/tyeZzlS23IrT0FN+TcOYQOcvv0OOn7N NqrR8fMWmVfXzO6g83S1wvcwckAvUlOOrAIWITZ+dMRt5RSKcIn7nUUNexkMSG/D//PJ OxstLw8Gj0424C81Ub6ZoOTHdMmlqtMlZrshT/VXXmLUqebSRjF0mHJsddQ0Tw2GK3tq WfhVwE2TdUFJHl0CwfO4vjyEj+T7+zS0BwGLoy3hyVV6WIAZ6GRIYIjC1+u81gG1OBbe xKPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697197735; x=1697802535; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4lyOHM/RBgmuxKTo/vmZ0oW2gfmzXsxTpr43TXFONHQ=; b=Au7jIgcrMwldvEVx6jg2YzfdzuTcS2yi0oJ1U8QmnwZRcs2FnXvXceQHaGEG7KYzrO mbBlST9WsNMjiradwafLXZ7B7/lrRIi4XuQKP+yXcrXKZxZY8bIU3mpjIv0QRljy/G7C oYih1tMUTOVM7FYjsy5PmSFwpaHOpk098Tdc1obUsq1QSBhO09aa4SOQ9DKrjMH1df77 cNqHDxE8MbgG//HyIwEEo3+nV/39IiqBHmKd65GVNLYL5AeUu9RXmDrhB0sz4uIH2Ahv 4Q1wYxOC9uU3XdxP9lXnD4MpGNUru8op+k/XCoHVtPnFqp2SXVBdwqkVPOTlGXn2A7WX jC9w== X-Gm-Message-State: AOJu0Yw3+Dw+wlQYuoziaqyUcYw89x3oJIBny6KX8/2pqmt01MBd9QhD mbsLYIF20bNXGZDXZwhDosk+UQ== X-Google-Smtp-Source: AGHT+IGwfVRxhdaPcrTgZudW4uBmd9NjhkZBeH0ym5/LLLLuWLxGrB4YZsbUy/eulNORH0ETqJvBVg== X-Received: by 2002:a05:600c:2a4e:b0:3fe:fc0f:52e2 with SMTP id x14-20020a05600c2a4e00b003fefc0f52e2mr23680112wme.37.1697197735644; Fri, 13 Oct 2023 04:48:55 -0700 (PDT) Received: from brgl-uxlite.home ([2a01:cb1d:334:ac00:4209:13a:988d:80be]) by smtp.gmail.com with ESMTPSA id j23-20020a05600c1c1700b00407754b998dsm974509wms.27.2023.10.13.04.48.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Oct 2023 04:48:55 -0700 (PDT) From: Bartosz Golaszewski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Elliot Berman , Krzysztof Kozlowski , Guru Das Srinagesh , Andrew Halaney , Maximilian Luz , Alex Elder , Srini Kandagatla Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kernel@quicinc.com, Bartosz Golaszewski Subject: [PATCH v4 03/15] firmware: qcom: scm: remove unneeded 'extern' specifiers Date: Fri, 13 Oct 2023 13:48:31 +0200 Message-Id: <20231013114843.63205-4-brgl@bgdev.pl> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20231013114843.63205-1-brgl@bgdev.pl> References: <20231013114843.63205-1-brgl@bgdev.pl> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231013_044859_315413_14F9C78D X-CRM114-Status: GOOD ( 10.80 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Bartosz Golaszewski 'extern' specifiers do nothing for function declarations. Remove them from the private qcom-scm header. Signed-off-by: Bartosz Golaszewski Reviewed-by: Andrew Halaney --- drivers/firmware/qcom/qcom_scm.h | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/drivers/firmware/qcom/qcom_scm.h b/drivers/firmware/qcom/qcom_scm.h index c88e29051d20..4532907e8489 100644 --- a/drivers/firmware/qcom/qcom_scm.h +++ b/drivers/firmware/qcom/qcom_scm.h @@ -66,18 +66,17 @@ int qcom_scm_wait_for_wq_completion(u32 wq_ctx); int scm_get_wq_ctx(u32 *wq_ctx, u32 *flags, u32 *more_pending); #define SCM_SMC_FNID(s, c) ((((s) & 0xFF) << 8) | ((c) & 0xFF)) -extern int __scm_smc_call(struct device *dev, const struct qcom_scm_desc *desc, - enum qcom_scm_convention qcom_convention, - struct qcom_scm_res *res, bool atomic); +int __scm_smc_call(struct device *dev, const struct qcom_scm_desc *desc, + enum qcom_scm_convention qcom_convention, + struct qcom_scm_res *res, bool atomic); #define scm_smc_call(dev, desc, res, atomic) \ __scm_smc_call((dev), (desc), qcom_scm_convention, (res), (atomic)) #define SCM_LEGACY_FNID(s, c) (((s) << 10) | ((c) & 0x3ff)) -extern int scm_legacy_call_atomic(struct device *dev, - const struct qcom_scm_desc *desc, - struct qcom_scm_res *res); -extern int scm_legacy_call(struct device *dev, const struct qcom_scm_desc *desc, +int scm_legacy_call_atomic(struct device *dev, const struct qcom_scm_desc *desc, struct qcom_scm_res *res); +int scm_legacy_call(struct device *dev, const struct qcom_scm_desc *desc, + struct qcom_scm_res *res); #define QCOM_SCM_SVC_BOOT 0x01 #define QCOM_SCM_BOOT_SET_ADDR 0x01