From patchwork Sat Oct 14 09:29:54 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christian Marangi X-Patchwork-Id: 13421956 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3E6ECCDB465 for ; Sat, 14 Oct 2023 09:31:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=P4kRgfyq9lsa+pHJsbqHRsTJzyNHHQSUdvhaftYD/hc=; b=ZO4QS6aPpl4NzD Q0vzqOHdiHbDNHlWXJxbQm13UpJADRppEphB/B/IDHN5JHA1MaKaIu+XfUYfeoig2UpuD1EvClYqp /5nAJpo+4IBvCEEy2G5VLPxO5caAUmtg+ALHbsAMpUnz4KanegcCSz3btEWtyUupM6YqJM64cLs5z zCQQ6cDMGHXsFMwt80AfuDYQzC2A6kFnpECSz2WQcEaHm1NitLqVJWqtf4zrvzhfZ+avjf2XmK5ep GKEw/9oHK9qdyGiMJQKWI11UpGv8qkCGAMYliN76x1xBO+qSagBbWKUObe9bA1RhBka5px7SD4XfA c7rMPbXh1hXbTUG6sXFw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qrayp-0052kS-21; Sat, 14 Oct 2023 09:30:43 +0000 Received: from mail-wm1-x32c.google.com ([2a00:1450:4864:20::32c]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qrayj-0052fz-1r for linux-arm-kernel@lists.infradead.org; Sat, 14 Oct 2023 09:30:39 +0000 Received: by mail-wm1-x32c.google.com with SMTP id 5b1f17b1804b1-4075c58ac39so29464455e9.3 for ; Sat, 14 Oct 2023 02:30:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697275831; x=1697880631; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=SSAhxNCccBDPfEaHOYwSm94ZHYVqbuNn4mUPNvHQg0g=; b=VHJbB2lp5XZWljm+nGf9zEGngI1sf6ZYU9R87u1MwKXbASxbc+9Y63DUFf7h+ltMyI aRxsnEhein/v6w539BnrW50NOGrDQKZT0KN5TKcs1laJq9+EIXL6elfCpF7VjK7MvR8h HvYwJXRCGySbJ+kYu5MQ+6vsBmidu6PRk8fTPMN3TnEQgT+8zQ0qm+UmRAQDNYNGA16t B8coNdhhKPD29Jf0tdZjcKBrAAwl3Labb0gJ5O3GVvdXnRluGCwJ1CMzz4VOkjltlycY j5EJI9wtmwr9e40R16ao2BL+NnWBCu+9M1mvsrGKChL5rx+pOLiwUN/UZUeYsugXX9+e PzEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697275831; x=1697880631; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=SSAhxNCccBDPfEaHOYwSm94ZHYVqbuNn4mUPNvHQg0g=; b=ChmVJSa+Nl6aSt+hVueLqTNY2BH8hZqRoztmkWE91uuCejaX1Y84wuNPmuWsrz1IHG OwGBqzEE68BWB8OF/zfklvcID0Y92Wan7S4xhK3E+99/lHvHcXfXPOC7AR+uhCplWGYb IUROtaMCLTt3aRnKyJxxE70OLiTvErStghvOOajBcedGSw/xMSZVW+IMn9nfm98BRu6M dKhpNUINQH4qjah4H8KF5KqyPY/O/CcYZicR/hL1RxWD2ejKrKP+oKWgbH77u/NMDQUX fYq72zjBL/BlWUeIT9Z1L498bmZyySVShXG4jlXTyA4ikEjJHqrqBa887tkZHwj3F9pw KQJw== X-Gm-Message-State: AOJu0Yzga3e+apoti73MCIxIHYKPoAXQNajWTJ/xamaNGwCBiWL3zkSc hEojK0VCQQlDhyOPhtyFpzs= X-Google-Smtp-Source: AGHT+IFpFx9x4EPEvCFdXGS/SpNKLQq7KRgOHBLFfKy+KqvZNLFbEiecbXCUkuM9Sz82toMeuJ08jw== X-Received: by 2002:adf:f084:0:b0:314:a3f:9c08 with SMTP id n4-20020adff084000000b003140a3f9c08mr24141801wro.39.1697275831283; Sat, 14 Oct 2023 02:30:31 -0700 (PDT) Received: from localhost.localdomain (93-34-89-13.ip49.fastwebnet.it. [93.34.89.13]) by smtp.googlemail.com with ESMTPSA id u12-20020adff88c000000b0032d9a1f2ec3sm3691564wrp.27.2023.10.14.02.30.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 14 Oct 2023 02:30:31 -0700 (PDT) From: Christian Marangi To: Raju Rangoju , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Alexandre Torgue , Jose Abreu , Maxime Coquelin , Ping-Ke Shih , Kalle Valo , Simon Horman , Daniel Borkmann , Jiri Pirko , Hangbin Liu , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-wireless@vger.kernel.org Cc: Christian Marangi Subject: [net-next PATCH v3 4/4] net: stmmac: increase TX coalesce timer to 5ms Date: Sat, 14 Oct 2023 11:29:54 +0200 Message-Id: <20231014092954.1850-5-ansuelsmth@gmail.com> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20231014092954.1850-1-ansuelsmth@gmail.com> References: <20231014092954.1850-1-ansuelsmth@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231014_023037_616085_6451152D X-CRM114-Status: GOOD ( 14.46 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Commit 8fce33317023 ("net: stmmac: Rework coalesce timer and fix multi-queue races") decreased the TX coalesce timer from 40ms to 1ms. This caused some performance regression on some target (regression was reported at least on ipq806x) in the order of 600mbps dropping from gigabit handling to only 200mbps. The problem was identified in the TX timer getting armed too much time. While this was fixed and improved in another commit, performance can be improved even further by increasing the timer delay a bit moving from 1ms to 5ms. The value is a good balance between battery saving by prevending too much interrupt to be generated and permitting good performance for internet oriented devices. Signed-off-by: Christian Marangi --- drivers/net/ethernet/stmicro/stmmac/common.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/common.h b/drivers/net/ethernet/stmicro/stmmac/common.h index 1e996c29043d..e3f650e88f82 100644 --- a/drivers/net/ethernet/stmicro/stmmac/common.h +++ b/drivers/net/ethernet/stmicro/stmmac/common.h @@ -293,7 +293,7 @@ struct stmmac_safety_stats { #define MIN_DMA_RIWT 0x10 #define DEF_DMA_RIWT 0xa0 /* Tx coalesce parameters */ -#define STMMAC_COAL_TX_TIMER 1000 +#define STMMAC_COAL_TX_TIMER 5000 #define STMMAC_MAX_COAL_TX_TICK 100000 #define STMMAC_TX_MAX_FRAMES 256 #define STMMAC_TX_FRAMES 25