| Message ID | 20231016-bt-bcm4377-quirk-broken-le-coded-v1-1-52ea69d3c979@jannau.net (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Bluetooth: hci_bcm4377: Mark bcm4378/bcm4387 as BROKEN_LE_CODED | expand |
On Mon, 16 Oct 2023 at 08:21, Janne Grunau via B4 Relay <devnull+j.jannau.net@kernel.org> wrote: > > From: Janne Grunau <j@jannau.net> > > bcm4378 and bcm4387 claim to support LE Coded PHY but fail to pair > (reliably) with BLE devices if it is enabled. > On bcm4378 pairing usually succeeds after 2-3 tries. On bcm4387 > pairing appears to be completely broken. > > Cc: stable@vger.kernel.org # 6.4.y+ > Link: https://discussion.fedoraproject.org/t/mx-master-3-bluetooth-mouse-doesnt-connect/87072/33 > Link: https://github.com/AsahiLinux/linux/issues/177 > Fixes: 288c90224eec ("Bluetooth: Enable all supported LE PHY by default") > Signed-off-by: Janne Grunau <j@jannau.net> > --- Reviewed-by: Eric Curtin <ecurtin@redhat.com> Is mise le meas/Regards, Eric Curtin > drivers/bluetooth/hci_bcm4377.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/bluetooth/hci_bcm4377.c b/drivers/bluetooth/hci_bcm4377.c > index 19ad0e788646..a61757835695 100644 > --- a/drivers/bluetooth/hci_bcm4377.c > +++ b/drivers/bluetooth/hci_bcm4377.c > @@ -512,6 +512,7 @@ struct bcm4377_hw { > unsigned long disable_aspm : 1; > unsigned long broken_ext_scan : 1; > unsigned long broken_mws_transport_config : 1; > + unsigned long broken_le_coded : 1; > > int (*send_calibration)(struct bcm4377_data *bcm4377); > int (*send_ptb)(struct bcm4377_data *bcm4377, > @@ -2372,6 +2373,8 @@ static int bcm4377_probe(struct pci_dev *pdev, const struct pci_device_id *id) > set_bit(HCI_QUIRK_BROKEN_MWS_TRANSPORT_CONFIG, &hdev->quirks); > if (bcm4377->hw->broken_ext_scan) > set_bit(HCI_QUIRK_BROKEN_EXT_SCAN, &hdev->quirks); > + if (bcm4377->hw->broken_le_coded) > + set_bit(HCI_QUIRK_BROKEN_LE_CODED, &hdev->quirks); > > pci_set_drvdata(pdev, bcm4377); > hci_set_drvdata(hdev, bcm4377); > @@ -2461,6 +2464,7 @@ static const struct bcm4377_hw bcm4377_hw_variants[] = { > .bar0_core2_window2 = 0x18107000, > .has_bar0_core2_window2 = true, > .broken_mws_transport_config = true, > + .broken_le_coded = true, > .send_calibration = bcm4378_send_calibration, > .send_ptb = bcm4378_send_ptb, > }, > @@ -2474,6 +2478,7 @@ static const struct bcm4377_hw bcm4377_hw_variants[] = { > .has_bar0_core2_window2 = true, > .clear_pciecfg_subsystem_ctrl_bit19 = true, > .broken_mws_transport_config = true, > + .broken_le_coded = true, > .send_calibration = bcm4387_send_calibration, > .send_ptb = bcm4378_send_ptb, > }, > > --- > base-commit: 0bb80ecc33a8fb5a682236443c1e740d5c917d1d > change-id: 20231016-bt-bcm4377-quirk-broken-le-coded-599688e3c4a0 > > Best regards, > -- > Janne Grunau <j@jannau.net> > >
On Mon, Oct 16, 2023 at 3:13 AM Janne Grunau via B4 Relay <devnull+j.jannau.net@kernel.org> wrote: > > From: Janne Grunau <j@jannau.net> > > bcm4378 and bcm4387 claim to support LE Coded PHY but fail to pair > (reliably) with BLE devices if it is enabled. > On bcm4378 pairing usually succeeds after 2-3 tries. On bcm4387 > pairing appears to be completely broken. > > Cc: stable@vger.kernel.org # 6.4.y+ > Link: https://discussion.fedoraproject.org/t/mx-master-3-bluetooth-mouse-doesnt-connect/87072/33 > Link: https://github.com/AsahiLinux/linux/issues/177 > Fixes: 288c90224eec ("Bluetooth: Enable all supported LE PHY by default") > Signed-off-by: Janne Grunau <j@jannau.net> > --- > drivers/bluetooth/hci_bcm4377.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/bluetooth/hci_bcm4377.c b/drivers/bluetooth/hci_bcm4377.c > index 19ad0e788646..a61757835695 100644 > --- a/drivers/bluetooth/hci_bcm4377.c > +++ b/drivers/bluetooth/hci_bcm4377.c > @@ -512,6 +512,7 @@ struct bcm4377_hw { > unsigned long disable_aspm : 1; > unsigned long broken_ext_scan : 1; > unsigned long broken_mws_transport_config : 1; > + unsigned long broken_le_coded : 1; > > int (*send_calibration)(struct bcm4377_data *bcm4377); > int (*send_ptb)(struct bcm4377_data *bcm4377, > @@ -2372,6 +2373,8 @@ static int bcm4377_probe(struct pci_dev *pdev, const struct pci_device_id *id) > set_bit(HCI_QUIRK_BROKEN_MWS_TRANSPORT_CONFIG, &hdev->quirks); > if (bcm4377->hw->broken_ext_scan) > set_bit(HCI_QUIRK_BROKEN_EXT_SCAN, &hdev->quirks); > + if (bcm4377->hw->broken_le_coded) > + set_bit(HCI_QUIRK_BROKEN_LE_CODED, &hdev->quirks); > > pci_set_drvdata(pdev, bcm4377); > hci_set_drvdata(hdev, bcm4377); > @@ -2461,6 +2464,7 @@ static const struct bcm4377_hw bcm4377_hw_variants[] = { > .bar0_core2_window2 = 0x18107000, > .has_bar0_core2_window2 = true, > .broken_mws_transport_config = true, > + .broken_le_coded = true, > .send_calibration = bcm4378_send_calibration, > .send_ptb = bcm4378_send_ptb, > }, > @@ -2474,6 +2478,7 @@ static const struct bcm4377_hw bcm4377_hw_variants[] = { > .has_bar0_core2_window2 = true, > .clear_pciecfg_subsystem_ctrl_bit19 = true, > .broken_mws_transport_config = true, > + .broken_le_coded = true, > .send_calibration = bcm4387_send_calibration, > .send_ptb = bcm4378_send_ptb, > }, > > --- > base-commit: 0bb80ecc33a8fb5a682236443c1e740d5c917d1d > change-id: 20231016-bt-bcm4377-quirk-broken-le-coded-599688e3c4a0 > LGTM. Reviewed-by: Neal Gompa <neal@gompa.dev>
Hello: This patch was applied to bluetooth/bluetooth-next.git (master) by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>: On Mon, 16 Oct 2023 09:13:08 +0200 you wrote: > From: Janne Grunau <j@jannau.net> > > bcm4378 and bcm4387 claim to support LE Coded PHY but fail to pair > (reliably) with BLE devices if it is enabled. > On bcm4378 pairing usually succeeds after 2-3 tries. On bcm4387 > pairing appears to be completely broken. > > [...] Here is the summary with links: - Bluetooth: hci_bcm4377: Mark bcm4378/bcm4387 as BROKEN_LE_CODED https://git.kernel.org/bluetooth/bluetooth-next/c/b00d44276894 You are awesome, thank you!
diff --git a/drivers/bluetooth/hci_bcm4377.c b/drivers/bluetooth/hci_bcm4377.c index 19ad0e788646..a61757835695 100644 --- a/drivers/bluetooth/hci_bcm4377.c +++ b/drivers/bluetooth/hci_bcm4377.c @@ -512,6 +512,7 @@ struct bcm4377_hw { unsigned long disable_aspm : 1; unsigned long broken_ext_scan : 1; unsigned long broken_mws_transport_config : 1; + unsigned long broken_le_coded : 1; int (*send_calibration)(struct bcm4377_data *bcm4377); int (*send_ptb)(struct bcm4377_data *bcm4377, @@ -2372,6 +2373,8 @@ static int bcm4377_probe(struct pci_dev *pdev, const struct pci_device_id *id) set_bit(HCI_QUIRK_BROKEN_MWS_TRANSPORT_CONFIG, &hdev->quirks); if (bcm4377->hw->broken_ext_scan) set_bit(HCI_QUIRK_BROKEN_EXT_SCAN, &hdev->quirks); + if (bcm4377->hw->broken_le_coded) + set_bit(HCI_QUIRK_BROKEN_LE_CODED, &hdev->quirks); pci_set_drvdata(pdev, bcm4377); hci_set_drvdata(hdev, bcm4377); @@ -2461,6 +2464,7 @@ static const struct bcm4377_hw bcm4377_hw_variants[] = { .bar0_core2_window2 = 0x18107000, .has_bar0_core2_window2 = true, .broken_mws_transport_config = true, + .broken_le_coded = true, .send_calibration = bcm4378_send_calibration, .send_ptb = bcm4378_send_ptb, }, @@ -2474,6 +2478,7 @@ static const struct bcm4377_hw bcm4377_hw_variants[] = { .has_bar0_core2_window2 = true, .clear_pciecfg_subsystem_ctrl_bit19 = true, .broken_mws_transport_config = true, + .broken_le_coded = true, .send_calibration = bcm4387_send_calibration, .send_ptb = bcm4378_send_ptb, },