diff mbox series

[net-next,5/8] dt-bindings: net: ethernet-switch: Rename $defs "base" to 'ethernet-ports'

Message ID 20231016-dt-net-cleanups-v1-5-a525a090b444@kernel.org (mailing list archive)
State New, archived
Headers show
Series dt-bindings: net: Child node schema cleanups | expand

Commit Message

Rob Herring Oct. 16, 2023, 9:44 p.m. UTC
The name "base" is misleading as the definition is for a complete schema
definition without additional properties allowed, not a "base class".
Align the same to be the same as dsa.yaml. This schema file without any
json pointer path is the base schema which can be extended.

There are not yet any references to $defs/base to update.

Signed-off-by: Rob Herring <robh@kernel.org>
---
 Documentation/devicetree/bindings/net/ethernet-switch.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Arınç ÜNAL Oct. 17, 2023, 6:35 a.m. UTC | #1
On 17.10.2023 00:44, Rob Herring wrote:
> The name "base" is misleading as the definition is for a complete schema
> definition without additional properties allowed, not a "base class".
> Align the same to be the same as dsa.yaml. This schema file without any

Align the same to be the same -> Align the name to be the same

> json pointer path is the base schema which can be extended.
> 
> There are not yet any references to $defs/base to update.
> 
> Signed-off-by: Rob Herring <robh@kernel.org>

Acked-by: Arınç ÜNAL <arinc.unal@arinc9.com>

Arınç
Vladimir Oltean Oct. 19, 2023, 1:36 p.m. UTC | #2
On Mon, Oct 16, 2023 at 04:44:24PM -0500, Rob Herring wrote:
> The name "base" is misleading as the definition is for a complete schema
> definition without additional properties allowed, not a "base class".
> Align the same to be the same as dsa.yaml. This schema file without any
> json pointer path is the base schema which can be extended.
> 
> There are not yet any references to $defs/base to update.
> 
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---

Reviewed-by: Vladimir Oltean <vladimir.oltean@nxp.com>
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/net/ethernet-switch.yaml b/Documentation/devicetree/bindings/net/ethernet-switch.yaml
index 688938c2e261..72ac67ca3415 100644
--- a/Documentation/devicetree/bindings/net/ethernet-switch.yaml
+++ b/Documentation/devicetree/bindings/net/ethernet-switch.yaml
@@ -53,7 +53,7 @@  oneOf:
 additionalProperties: true
 
 $defs:
-  base:
+  ethernet-ports:
     description: An ethernet switch without any extra port properties
     $ref: '#'