From patchwork Tue Oct 17 20:05:11 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Umang Jain X-Patchwork-Id: 13425959 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3FD54CDB474 for ; Tue, 17 Oct 2023 20:06:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=4dN09OuJzRLChZptoEmtjzfee+7MgTjqadBwO9AN8D8=; b=EHcaOCnWjaFvR6 uAeDj5bgTdXYDK1bMHFnNLrILLM2xftoF/YdSUzjuAjXFigmwWMi+RW3LHijV3rqeRNn1LaDEHOIY /HqUgebZoDI9pAF2Q/+72K30agmeOOEEg2RvYA5RG8IQGfU3Gbiis9FEqL9w4YdGQyHpwgIIxsTGM IG+lBCRud3KTYzSV81BRL4kEY5YFXFLhhLun/fb1omcEbctcF0rmiYK8HR+B0fUY8ZpPfxGyPvKOD 4HaSkPsCEvGahL2N3OsuWRzVURU8bnjJ6XHumeaM7dMPwuH762ietnFeyFTp+I87+Fhl7oaDKWvvh g3Y/0onIg1w3sWq6+gbA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qsqK7-00DAIx-1b; Tue, 17 Oct 2023 20:05:51 +0000 Received: from perceval.ideasonboard.com ([213.167.242.64]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qsqJq-00DAFE-2W; Tue, 17 Oct 2023 20:05:36 +0000 Received: from umang.jainideasonboard.com (unknown [103.251.226.39]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 96A26896; Tue, 17 Oct 2023 22:05:24 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1697573126; bh=nd7rHyBKUfldOwcG/wXZdy58DTZYnnBemMWna4eYMUU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=JYm8Xo90ibGFok6hP+jW8+PRHKU9pPiZwYXhW56pCAgVyGRGM9J5Ql6ak1lFYXajr 6ZFCfoBUyUDApFT5VprrMstRaxEdKJRil3NOTzbrAyNAt5c/D0ba1etcsK9iK287A2 e1JyB5brKSMiW3MAy+k5d972sSw14HL16VpNDm1U= From: Umang Jain To: linux-staging@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-rpi-kernel@lists.infradead.org, linux-media@vger.kernel.org Cc: Stefan Wahren , Greg Kroah-Hartman , Dan Carpenter , Kieran Bingham , Laurent Pinchart , Umang Jain Subject: [PATCH 3/3] staging: vc04_services: bcm2835-camera: Drop MODULE_ALIAS Date: Wed, 18 Oct 2023 01:35:11 +0530 Message-Id: <20231017200511.678223-4-umang.jain@ideasonboard.com> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20231017200511.678223-1-umang.jain@ideasonboard.com> References: <20231017200511.678223-1-umang.jain@ideasonboard.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231017_130534_976977_CE956A04 X-CRM114-Status: UNSURE ( 8.38 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Drop MODULE_ALIAS in favour of MODULE_DEVICE_TABLE as the module alias should be picked from there. Signed-off-by: Umang Jain --- .../staging/vc04_services/bcm2835-camera/bcm2835-camera.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.c b/drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.c index c873eace1437..3c18376003ff 100644 --- a/drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.c +++ b/drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.c @@ -1995,9 +1995,15 @@ static void bcm2835_mmal_remove(struct vchiq_device *device) vchiq_mmal_finalise(instance); } +static const struct vchiq_bus_device_id id_table[] = { + { .name = "bcm2835-camera" } +}; +MODULE_DEVICE_TABLE(vchiq_bus, id_table); + static struct vchiq_driver bcm2835_camera_driver = { .probe = bcm2835_mmal_probe, .remove = bcm2835_mmal_remove, + .id_table = id_table, .driver = { .name = "bcm2835-camera", }, @@ -2008,4 +2014,3 @@ module_vchiq_driver(bcm2835_camera_driver) MODULE_DESCRIPTION("Broadcom 2835 MMAL video capture"); MODULE_AUTHOR("Vincent Sanders"); MODULE_LICENSE("GPL"); -MODULE_ALIAS("bcm2835-camera");