| Message ID | 20231023-marvell-88e6152-wan-led-v5-2-0e82952015a7@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Create a binding for the Marvell MV88E6xxx DSA switches | expand |
On Mon, 23 Oct 2023 09:18:53 +0200, Linus Walleij wrote: > When adding a proper schema for the Marvell mx88e6xxx switch, > the scripts start complaining about this embedded example: > > dtschema/dtc warnings/errors: > net/marvell,mvusb.example.dtb: switch@0: ports: '#address-cells' > is a required property > from schema $id: http://devicetree.org/schemas/net/dsa/marvell,mv88e6xxx.yaml# > net/marvell,mvusb.example.dtb: switch@0: ports: '#size-cells' > is a required property > from schema $id: http://devicetree.org/schemas/net/dsa/marvell,mv88e6xxx.yaml# > > Fix this up by extending the example with those properties in > the ports node. > > While we are at it, rename "ports" to "ethernet-ports" and rename > "switch" to "ethernet-switch" as this is recommended practice. > > Reviewed-by: Andrew Lunn <andrew@lunn.ch> > Reviewed-by: Vladimir Oltean <vladimir.oltean@nxp.com> > Signed-off-by: Linus Walleij <linus.walleij@linaro.org> > --- > Documentation/devicetree/bindings/net/marvell,mvusb.yaml | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > Reviewed-by: Rob Herring <robh@kernel.org>
diff --git a/Documentation/devicetree/bindings/net/marvell,mvusb.yaml b/Documentation/devicetree/bindings/net/marvell,mvusb.yaml index 3a3325168048..ab838c1ffeed 100644 --- a/Documentation/devicetree/bindings/net/marvell,mvusb.yaml +++ b/Documentation/devicetree/bindings/net/marvell,mvusb.yaml @@ -50,11 +50,14 @@ examples: #address-cells = <1>; #size-cells = <0>; - switch@0 { + ethernet-switch@0 { compatible = "marvell,mv88e6190"; reg = <0x0>; - ports { + ethernet-ports { + #address-cells = <1>; + #size-cells = <0>; + /* Port definitions */ };