| Message ID | 20231025103300.340572-2-umang.jain@ideasonboard.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | staging: vc04_services: Remove completed TODO items | expand |
Hi Umang, Am 25.10.23 um 12:32 schrieb Umang Jain: > Drop the TODO item which deals with non-essential global > structures and per-device structure. All this has been > handled now through vchiq-bus and struct vchiq_device. > > Signed-off-by: Umang Jain <umang.jain@ideasonboard.com> > --- > drivers/staging/vc04_services/interface/TODO | 8 -------- > 1 file changed, 8 deletions(-) > > diff --git a/drivers/staging/vc04_services/interface/TODO b/drivers/staging/vc04_services/interface/TODO > index 6d9d4a800aa7..9c79ed549831 100644 > --- a/drivers/staging/vc04_services/interface/TODO > +++ b/drivers/staging/vc04_services/interface/TODO > @@ -46,14 +46,6 @@ The code follows the 80 characters limitation yet tends to go 3 or 4 levels of > indentation deep making it very unpleasant to read. This is specially relevant > in the character driver ioctl code and in the core thread functions. > > -* Get rid of all non essential global structures and create a proper per > -device structure at first thank for all the great work. Currently i don't have much time to give a feedback for everything :-( Tbh this TODO is not finished yet. There are still global structures. Please look at variables starting with g_* in vchiq_arm.c and vchiq_connected.c Unfortunately i cannot tell which of them are easy to move into the device structure. > - > -The first thing one generally sees in a probe function is a memory allocation > -for all the device specific data. This structure is then passed all over the > -driver. This is good practice since it makes the driver work regardless of the > -number of devices probed. > - > * Clean up Sparse warnings from __user annotations. See > vchiq_irq_queue_bulk_tx_rx(). Ensure that the address of "&waiter->bulk_waiter" > is never disclosed to userspace.
diff --git a/drivers/staging/vc04_services/interface/TODO b/drivers/staging/vc04_services/interface/TODO index 6d9d4a800aa7..9c79ed549831 100644 --- a/drivers/staging/vc04_services/interface/TODO +++ b/drivers/staging/vc04_services/interface/TODO @@ -46,14 +46,6 @@ The code follows the 80 characters limitation yet tends to go 3 or 4 levels of indentation deep making it very unpleasant to read. This is specially relevant in the character driver ioctl code and in the core thread functions. -* Get rid of all non essential global structures and create a proper per -device structure - -The first thing one generally sees in a probe function is a memory allocation -for all the device specific data. This structure is then passed all over the -driver. This is good practice since it makes the driver work regardless of the -number of devices probed. - * Clean up Sparse warnings from __user annotations. See vchiq_irq_queue_bulk_tx_rx(). Ensure that the address of "&waiter->bulk_waiter" is never disclosed to userspace.
Drop the TODO item which deals with non-essential global structures and per-device structure. All this has been handled now through vchiq-bus and struct vchiq_device. Signed-off-by: Umang Jain <umang.jain@ideasonboard.com> --- drivers/staging/vc04_services/interface/TODO | 8 -------- 1 file changed, 8 deletions(-)