From patchwork Wed Oct 25 10:33:00 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Umang Jain X-Patchwork-Id: 13435945 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8D9D8C25B47 for ; Wed, 25 Oct 2023 10:33:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=aV2nW/b7fV9WqabHgcmYcQRDrdvIueDHRpiwKCe+lj4=; b=Byjr3ju4TU8Kkj gR2whg/ios7zUZKkYyixi2a8tzk6Qg7nhDqU0ZYuqAMa5v8qovjuc8vLEIWsLLQwq+94serqWgNsf JmX0HSqREkAvbtkENzuqu/AYGVrJARXtTarVEgTCqf/YrsLSAR+CxK3XUnaxElYtJx2ho6ZhpMb1i h3pI876OOeaO4YR7LSFXVPKPmrMi+8lsDT9GZWztGAD29wwAyW/pi0YkWpwy64OzTDDWoRTZNg5Kg pIdBtiPvAgjatLXtMD57s1leuKJ+vnQ5SkGLWVH7F2BDdlxgW5u6HPewyKQvhHrlmtaw8rUBWRbQL jc4+8unSf9GyoOnSBfPw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qvbCU-00C3in-0x; Wed, 25 Oct 2023 10:33:22 +0000 Received: from perceval.ideasonboard.com ([213.167.242.64]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qvbCL-00C3gK-0N; Wed, 25 Oct 2023 10:33:14 +0000 Received: from umang.jain (unknown [103.251.226.9]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 19FF5EF2; Wed, 25 Oct 2023 12:32:57 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1698229980; bh=lN/b6aBQlp0QJ2/bKG+wfQaYXsqIJPtPWZLmBnXQuiI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=DOn2lz3WYp55/+mOCeR5fxgCT8m4Wo34DWUe5MsErrp552yrvALfsTb82mD826qmy QbaD3Vn+Kq9hAZdH0urr6LRzGFYF25nDWkKEGiSBdJbCQpawJILIPTqmbkGypLzCOq GldqMDWPDOH4IOV3vsZ2PegQBTkigPHW4Me/Xw2A= From: Umang Jain To: linux-staging@lists.linux.dev, linux-rpi-kernel@lists.infradead.org, linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: Stefan Wahren , Greg Kroah-Hartman , Kieran Bingham , Laurent Pinchart , Dan Carpenter , Umang Jain Subject: [PATCH 2/2] staging: vc04_services: Drop completed TODO item Date: Wed, 25 Oct 2023 06:33:00 -0400 Message-ID: <20231025103300.340572-3-umang.jain@ideasonboard.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20231025103300.340572-1-umang.jain@ideasonboard.com> References: <20231025103300.340572-1-umang.jain@ideasonboard.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231025_033313_311992_05D200CA X-CRM114-Status: UNSURE ( 8.55 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Memory barries and remote_event_*() are documented. Drop the TODO item related to them. Signed-off-by: Umang Jain --- drivers/staging/vc04_services/interface/TODO | 7 ------- 1 file changed, 7 deletions(-) diff --git a/drivers/staging/vc04_services/interface/TODO b/drivers/staging/vc04_services/interface/TODO index 9c79ed549831..2d51f6928e0f 100644 --- a/drivers/staging/vc04_services/interface/TODO +++ b/drivers/staging/vc04_services/interface/TODO @@ -33,13 +33,6 @@ such as dev_info, dev_dbg, and friends. A short top-down description of this driver's architecture (function of kthreads, userspace, limitations) could be very helpful for reviewers. -* Review and comment memory barriers - -There is a heavy use of memory barriers in this driver, it would be very -beneficial to go over all of them and, if correct, comment on their merits. -Extra points to whomever confidently reviews the remote_event_*() family of -functions. - * Reformat core code with more sane indentations The code follows the 80 characters limitation yet tends to go 3 or 4 levels of